Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp838878imj; Fri, 15 Feb 2019 07:38:58 -0800 (PST) X-Google-Smtp-Source: AHgI3IbIOBxxyy21mgca1w7T91lDaCYDgXf3z5dy9EWYqAEBs8ytzZVBX44mL1522QVfXpYwb789 X-Received: by 2002:a63:ce16:: with SMTP id y22mr5952583pgf.296.1550245138863; Fri, 15 Feb 2019 07:38:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550245138; cv=none; d=google.com; s=arc-20160816; b=X/p2JXGkSK/8Wfjvb1U8K99NS3OKZbJsfUminEbE9hx8WXRJKrfo0P+7NQDzvYGjUW KCsmxscX5yD+XF1aEL7sdQLghEVxyAsxVcij4C1F/2F8UJlFE2YRIpBpGju1ywqgbUjr pSgRvDUlemGU0QcTJXmVHtY7x6AI6GbfB7Xssh9dwcumx2THIgucZBGPF3Tfhe2BsgGf tal3b0dtn1WZFgbTRe0phEts23zmzyvH74YNi0xwTefBTYiX3bhNarACdtB8uX3EjET7 Cylfsx+d9bFur/nSvtczL6vA7aWEjF4iY4dGPz2SJdPjMytfCHZ03qzZM9/tLPjXR2tP 7oCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=9FAKN/BEQu3ANfpK3k6qS74j2VR/opY09GB2IejS2PM=; b=ZtzENQVNv9JjfpkRZFYt+gE4Y6l42vnAgAgveozVJ6hCSRjWU/UwswqFWmCg0kNorf VamQxNiiaqeec2CUdEEpKgGEOdqhh5T2ugr5c6h1KJKQ1gc7QB563Of9OZdRrInFPGSS AAr5GGnDEgJh2ROl9RL0D05zg17lQ2oXsxyJ2fIgEjTdYVJOLmWyzFBRHRzLd4LVJnBW bN2jBk5y0PIdk1E6B1oRXFnwmGDbqgM0pqUffIczNy0nza2d/9B4sDg0atKcSx3mPvts Ps6aENqTLwww4RId50lYwVfvTgGLFi4EKai1cyMOIoKWmJdWqczAVDd48bbkk8pJhUXB CjFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iXqO2Niu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o8si5666428pll.365.2019.02.15.07.38.42; Fri, 15 Feb 2019 07:38:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=iXqO2Niu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404506AbfBOIoM (ORCPT + 99 others); Fri, 15 Feb 2019 03:44:12 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:46710 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404001AbfBOIoL (ORCPT ); Fri, 15 Feb 2019 03:44:11 -0500 Received: by mail-ot1-f67.google.com with SMTP id w25so15216190otm.13; Fri, 15 Feb 2019 00:44:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9FAKN/BEQu3ANfpK3k6qS74j2VR/opY09GB2IejS2PM=; b=iXqO2NiuAHscWN9GZ+B09fBiHQLgp/90ZdVDmn9SDqUIoooy+wo/YVF9fFiNOnM+Iv OzQjLBVDBU8D1AJb1ZcmCpe9BLAsievmp35ZcG5K2uNkGewOGrLjEI8NKyLlwiMwBv00 pED+A7s6R/K7T6UYmuYT2XuztiG+s12zxMt8+1pOpUNzMF25ujTdPbVUV1MLQA/fc5fy xtShjXfZ3HaXFvW7QqxkEOL8y6g4LmsLHnwBHDbVH38Da/8Q7bbMXRzVU1nFN1auvSi2 CMYj0bNVjj5R+nPXzZU0nOwgUq2P+knXwUJZugTWWRNVzcP4PvFQEzCYO2WZjLx0an9h xQRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9FAKN/BEQu3ANfpK3k6qS74j2VR/opY09GB2IejS2PM=; b=fgiSjDVZoqJ5JgXxvG9VXxe6Es1Gy+5cTSxzCIuR0CodpWhKrhNvpT6BKZ5hjxctqX ViZB+O3EuLx0Eks+xAjctut7uroqAV0vxxa0+BPjEgv5XJO9NXzgrThV611FhD9OyQHs uY7Ic3EJzOUeU1fpLQGp8JaWfHRg6IyXYT53/b8RpyFiRDcasHm6v/S8FX986nGNyCj8 lCY1JAjlZV+kANHfd6F2ILWi0xRpB5DbAle8CvzZBf4/g3XWSLfyXxR0MZoJNUMP4vwd QTqd6NjCHPeeFEhyXIqEDoeLHVICRboXPwWbY7pjczVtZVSI+XQY7Xwch/3CJdUnOqLX rLIw== X-Gm-Message-State: AHQUAuaAGAycZfhKAxdl3gZ+2cu16dVZjGExSFIW5cMzfjEmaB5meeQh UIqcabV23pmi8e0m5RFa77vQmC+4C+9mQE1ny9A= X-Received: by 2002:aca:cd93:: with SMTP id d141mr5179779oig.163.1550220250349; Fri, 15 Feb 2019 00:44:10 -0800 (PST) MIME-Version: 1.0 References: <20190213214052.2427-1-linux.amoon@gmail.com> <20190213214052.2427-2-linux.amoon@gmail.com> In-Reply-To: From: Anand Moon Date: Fri, 15 Feb 2019 14:13:55 +0530 Message-ID: Subject: Re: [RFC 1/2] ARM: dts: exynos: Add proper regulator states for suspend-to-mem for odroid-u3 To: Krzysztof Kozlowski Cc: devicetree , linux-arm-kernel , "linux-samsung-soc@vger.kernel.org" , Linux Kernel , Rob Herring , Kukjin Kim , Marek Szyprowski , Tomasz Figa , Chanwoo Choi , Pankaj Dubey Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Fri, 15 Feb 2019 at 13:01, Krzysztof Kozlowski wrote: > > On Thu, 14 Feb 2019 at 19:35, Anand Moon wrote: > > > > hi Krzysztof, > > > > Thanks fro your review comments. > > > > On Thu, 14 Feb 2019 at 18:11, Krzysztof Kozlowski wrote: > > > > > > Hi Anand, > > > > > > Thanks for the patch. See comments below. > > > > > > On Wed, 13 Feb 2019 at 22:41, Anand Moon wrote: > > > > > > > > Add suspend-to-mem node to regulator core to be enabled or disabled > > > > during system suspend and also support changing the regulator operating > > > > mode during runtime and when the system enter sleep mode. > > > > > > > > Cc: Marek Szyprowski > > > > Cc: Krzysztof Kozlowski > > > > Cc: Chanwoo Choi > > > > Signed-off-by: Anand Moon > > > > --- > > > > > > > > Changes from previos patch > > > > [0] https://patchwork.kernel.org/patch/10712549/ > > > > > > > > Set all the WAKEUP source regulator in suspend-on state. > > > > LD04, LD012, LD015, LD020, LD022 > > > > Set all the non used regulator in suspend-odd state > > > > LD02, LD03, LD05, LD06, LD07, LD011, LD013, LDO14, LD016 > > > > > > > > BUCK5, BUCK6, BUCK7 and not confirable as per driver max77686-regulator > > > > > > > > Tested on microSD card and it resumes correcly after suspend. > > > > eMMC is not able to resume after entering into suspend state, > > > > which need to be investigated and how to debug more. > > > > --- > > > > .../boot/dts/exynos4412-odroid-common.dtsi | 63 +++++++++++++++++++ > > > > arch/arm/boot/dts/exynos4412-odroidu3.dts | 3 + > > > > 2 files changed, 66 insertions(+) > > > > > > > > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > > > > index 08d3a0a7b4eb..e984461c37d9 100644 > > > > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > > > > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > > > > @@ -288,6 +288,9 @@ > > > > regulator-min-microvolt = <1800000>; > > > > regulator-max-microvolt = <1800000>; > > > > regulator-always-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > > > I see my comment from previous patch was not addressed. > > > > I left this unchanged since this regulator is not active linked and used. > > Ok I will change this to regulator-on-in-suspend, > > Why? > > Previous patch was setting this to "on". I said that this is noop and > if you want to add it, I need explanation why this regulator has to > stay on during suspend. > > So you changed to "off"... which is still noop... and you did not > provide explanation. Now you replied that you will change to "on"... > so this will be circle. Still without explanation. > I will re check with my previous patch and the driver code which support suspend state. Ok check the regulator driver max77686-regulator and enable the logs their. > > > > From documentation device tree binding regulator.txt > > "- regulator-always-on: boolean, regulator should never be disabled" > > > > But some regulator switches to a low power mode under light current loads > > and the device automatically switches back to a fast response mode as the > > output load increases. > > > > > > > > > }; > > > > > > > > ldo3_reg: LDO3 { > > > > @@ -295,6 +298,9 @@ > > > > regulator-min-microvolt = <1800000>; > > > > regulator-max-microvolt = <1800000>; > > > > regulator-always-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > > > The same... > > > > Ok I will change this to regulator-on-in-suspend, > > The same - why changing this to on or off? I need explanation why this > should be in first place. I will check in the driver code. > > > > > > > > }; > > > > > > > > ldo4_reg: LDO4 { > > > > @@ -302,6 +308,9 @@ > > > > regulator-min-microvolt = <2800000>; > > > > regulator-max-microvolt = <2800000>; > > > > regulator-boot-on; > > > > + regulator-state-mem { > > > > + regulator-on-in-suspend; > > > > + }; > > > > }; > > > > > > > > ldo5_reg: LDO5 { > > > > @@ -310,6 +319,9 @@ > > > > regulator-max-microvolt = <1800000>; > > > > regulator-always-on; > > > > regulator-boot-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > }; > > > > > > > > ldo6_reg: LDO6 { > > > > @@ -317,6 +329,9 @@ > > > > regulator-min-microvolt = <1000000>; > > > > regulator-max-microvolt = <1000000>; > > > > regulator-always-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > }; > > > > > > > > ldo7_reg: LDO7 { > > > > @@ -324,18 +339,27 @@ > > > > regulator-min-microvolt = <1000000>; > > > > regulator-max-microvolt = <1000000>; > > > > regulator-always-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > }; > > > > > > > > ldo8_reg: LDO8 { > > > > regulator-name = "VDD10_HDMI_1.0V"; > > > > regulator-min-microvolt = <1000000>; > > > > regulator-max-microvolt = <1000000>; > > > > + regulator-state-mem { > > > > + regulator-on-in-suspend; > > > > + }; > > > > }; > > > > > > > > ldo10_reg: LDO10 { > > > > regulator-name = "VDDQ_MIPIHSI_1.8V"; > > > > regulator-min-microvolt = <1800000>; > > > > regulator-max-microvolt = <1800000>; > > > > + regulator-state-mem { > > > > + regulator-on-in-suspend; > > > > + }; > > > > }; > > > > > > > > ldo11_reg: LDO11 { > > > > @@ -343,6 +367,9 @@ > > > > regulator-min-microvolt = <1800000>; > > > > regulator-max-microvolt = <1800000>; > > > > regulator-always-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > }; > > > > > > > > ldo12_reg: LDO12 { > > > > @@ -351,6 +378,9 @@ > > > > regulator-max-microvolt = <3300000>; > > > > regulator-always-on; > > > > regulator-boot-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > }; > > > > > > > > ldo13_reg: LDO13 { > > > > @@ -359,6 +389,9 @@ > > > > regulator-max-microvolt = <1800000>; > > > > regulator-always-on; > > > > regulator-boot-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > }; > > > > > > > > ldo14_reg: LDO14 { > > > > @@ -367,6 +400,9 @@ > > > > regulator-max-microvolt = <1800000>; > > > > regulator-always-on; > > > > regulator-boot-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > }; > > > > > > > > ldo15_reg: LDO15 { > > > > @@ -375,6 +411,9 @@ > > > > regulator-max-microvolt = <1000000>; > > > > regulator-always-on; > > > > regulator-boot-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > }; > > > > > > > > ldo16_reg: LDO16 { > > > > @@ -383,6 +422,9 @@ > > > > regulator-max-microvolt = <1800000>; > > > > regulator-always-on; > > > > regulator-boot-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > }; > > > > > > > > ldo20_reg: LDO20 { > > > > @@ -396,6 +438,9 @@ > > > > regulator-min-microvolt = <2800000>; > > > > regulator-max-microvolt = <2800000>; > > > > regulator-boot-on; > > > > + regulator-state-mem { > > > > + regulator-on-in-suspend; > > > > + }; > > > > > > > > > The same... any comments? > > > > I left this on for mshc_0 (emmc) regulator, > > since I could not get suspend resume working on eMMc > > In general eMMC can be turned off during suspend. However eMMC layer > may be handling this (manually turning off/on). So after checking and > confirming it, please document it. I will check in the driver code. > > > > > > > > }; > > > > > > > > ldo22_reg: LDO22 { > > > > @@ -405,6 +450,9 @@ > > > > */ > > > > regulator-name = "LDO22"; > > > > regulator-boot-on; > > > > + regulator-state-mem { > > > > + regulator-on-in-suspend; > > > > + }; > > > > }; > > > > > > > > ldo25_reg: LDO25 { > > > > @@ -413,6 +461,9 @@ > > > > regulator-max-microvolt = <1800000>; > > > > regulator-always-on; > > > > regulator-boot-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > }; > > > > > > > > buck1_reg: BUCK1 { > > > > @@ -421,6 +472,9 @@ > > > > regulator-max-microvolt = <1100000>; > > > > regulator-always-on; > > > > regulator-boot-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > > > Again, you did not address my comments. > > > > > > > Buck1 support entering into LPM setting, > > But I will set this to regulator-on-in-suspend; in next patch. > > Why? I will check in the driver code. > > > > > + }; > > > > }; > > > > > > > > buck2_reg: BUCK2 { > > > > @@ -429,6 +483,9 @@ > > > > regulator-max-microvolt = <1350000>; > > > > regulator-always-on; > > > > regulator-boot-on; > > > > + regulator-state-mem { > > > > + regulator-on-in-suspend; > > > > + }; > > > > }; > > > > > > > > buck3_reg: BUCK3 { > > > > @@ -437,6 +494,9 @@ > > > > regulator-max-microvolt = <1050000>; > > > > regulator-always-on; > > > > regulator-boot-on; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > > > The same... > > > > Buck3 support entering into LPM setting, > > But I will set this to regulator-on-in-suspend; in next patch. > > Again - why this should be on or off? > > > > > > > > }; > > > > > > > > buck4_reg: BUCK4 { > > > > @@ -444,6 +504,9 @@ > > > > regulator-min-microvolt = <900000>; > > > > regulator-max-microvolt = <1100000>; > > > > regulator-microvolt-offset = <50000>; > > > > + regulator-state-mem { > > > > + regulator-off-in-suspend; > > > > + }; > > > > }; > > > > > > > > buck5_reg: BUCK5 { > > > > diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts > > > > index 2bdf899df436..4ebde09fc51d 100644 > > > > --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts > > > > +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts > > > > @@ -82,6 +82,9 @@ > > > > regulator-name = "LDO22_VDDQ_MMC4_2.8V"; > > > > regulator-min-microvolt = <2800000>; > > > > regulator-max-microvolt = <2800000>; > > > > + regulator-state-mem { > > > > + regulator-on-in-suspend; > > > > > > Why? > > > > > > > I chose not to disable mshc_0 (emmc) regulator, > > since I could not get suspend resume working on eMMC. > > Having "regulator-on-in-suspend" is not the same as not disabling > regulator during suspend. This property means you will explicitly > enable it during suspend. To me it looks wrong so I would be happy to > see explanations. > Ok I will disable this and check this help me fix the issue I am observing. > Best regards, > Krzysztof *Sorry for wasting your time* I know I have the improve a lot of things. Best regards -Anand