Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp839909imj; Fri, 15 Feb 2019 07:40:00 -0800 (PST) X-Google-Smtp-Source: AHgI3IYvaL42PBHwz7OYJtadWerwTHEVddxZSzbZYRtz5ErlEX2E2S4WeXTpWZK77NiTvjsAeZzc X-Received: by 2002:a62:1a8c:: with SMTP id a134mr8713359pfa.182.1550245200513; Fri, 15 Feb 2019 07:40:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550245200; cv=none; d=google.com; s=arc-20160816; b=dHnc4g1QETSse/Qzo5WgTwdNeftPLso8GCrQusP5xsbF2QvJham/PFfIT2oPILcgQg Fg1rr6AVNO0j6EdR4xCxSt0FXjiUg9AX93CfLSw6AUaC7YP2gs199fg1nymf4bZ6imkE jjjPbZJDom/HUKHu3aQj7c9fH7Oin9s7rx9n3Ez8R5mRNEi0Zwtg/c/A3SUVy5w2ZdYm ltY7m7iK1e3k5DG23E7Lb+TDzgl1HL+t8jSTGvNtJNUEYZNDMUmRu6l+FbdTDSeXUAdf dELrlLc82MGOxacVdBDGblveF41sP9eDbQImo7IbdH/afHW/HSXY5pagR1YjeyVMwD6q pphg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=lC0sJXKkNVKrNcwoJXfFFpIZaHgwwYjVNEpuiQ0lz3E=; b=qc5UYSSDnf2x+lzyYa3uCld548/6DSMvn3eV7i+sQT14DhYkROYCk/7ZgQWmzMgLmX svHMWLhRHMbr2tcXfpA64/3dx69txgz5e+DnBCq6R8YUmqRDEjkrGxTWntUZoB46jk4U gv1MXBIeoe8hZzz5yyBrY7bFVbYUJPKP3ArnXfDK6YXS5ayZ06tpFqq9R31FQ3e2k6PL T6oT9CH1GN9i1KLaTvaVI+UG6cK0DDNoEZbg5KBBiz0mefIhmBpK7NJNeUNPWBU14RIB Y1Trbl3qnTuV/JPloX1PmVMfXsWka5+AJGJ4jRVC29GoAKeZEZCbNDtUcnw/vSqs3R4/ fARw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=gT8IzfYM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y9si5378274pfm.36.2019.02.15.07.39.44; Fri, 15 Feb 2019 07:40:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=gT8IzfYM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391711AbfBOI5q (ORCPT + 99 others); Fri, 15 Feb 2019 03:57:46 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:37196 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbfBOI5q (ORCPT ); Fri, 15 Feb 2019 03:57:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lC0sJXKkNVKrNcwoJXfFFpIZaHgwwYjVNEpuiQ0lz3E=; b=gT8IzfYM0rLFTG1VADzNxWfkL 0eTJScOywY+BgA5bL80r6zjO1AZl0H1zn29CTmFlZpu9sIc1WYqCtNA2bv/sLQy+V7B5KSUJL9kBf Mjc3XlxeAS2Al3t6/Whmm/lamblTaQI4AOdXw4EJkWBnRgFshT9ee/IpFzmm8tY1oqVPt1WRJewMQ wg8kTdGA4sk4TirfNw88ZtdtbGnDMH45veEYZy1uMspmPpNxOUFG+XJ9YCgDMkUqaGfGURYZIExdP N88tGKmHqC9VA5C/vAfXJZLPzY1ecvbeTU9gZV2OI7fGkQGeoFyBBHE8kTs/NXjsX9OU67Bl1b2ZI 4/Q6jy/xQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1guZJT-0000As-Ke; Fri, 15 Feb 2019 08:57:39 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id EE255201A8970; Fri, 15 Feb 2019 09:57:36 +0100 (CET) Date: Fri, 15 Feb 2019 09:57:36 +0100 From: Peter Zijlstra To: Igor Stoppa Cc: Igor Stoppa , Andy Lutomirski , Nadav Amit , Matthew Wilcox , Kees Cook , Dave Hansen , Mimi Zohar , Thiago Jung Bauermann , Ahmed Soliman , linux-integrity@vger.kernel.org, kernel-hardening@lists.openwall.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v5 03/12] __wr_after_init: Core and default arch Message-ID: <20190215085736.GO32494@hirez.programming.kicks-ass.net> References: <20190214112849.GM32494@hirez.programming.kicks-ass.net> <6e9ec71c-ee75-9b1e-9ff8-a3210030e85d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e9ec71c-ee75-9b1e-9ff8-a3210030e85d@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 15, 2019 at 01:10:33AM +0200, Igor Stoppa wrote: > > > On 14/02/2019 13:28, Peter Zijlstra wrote: > > On Thu, Feb 14, 2019 at 12:41:32AM +0200, Igor Stoppa wrote: > > [...] > > > > +#define wr_rcu_assign_pointer(p, v) ({ \ > > > + smp_mb(); \ > > > + wr_assign(p, v); \ > > > + p; \ > > > +}) > > > > This requires that wr_memcpy() (through wr_assign) is single-copy-atomic > > for native types. There is not a comment in sight that states this. > > Right, I kinda expected native-aligned <-> atomic, but it's not necessarily > true. It should be confirmed when enabling write rare on a new architecture. > I'll add the comment. > > > Also, is this true of x86/arm64 memcpy ? > > > For x86_64: > https://elixir.bootlin.com/linux/v5.0-rc6/source/arch/x86/include/asm/uaccess.h#L462 > the mov"itype" part should deal with atomic copy of native, aligned types. > > > For arm64: > https://elixir.bootlin.com/linux/v5.0-rc6/source/arch/arm64/lib/copy_template.S#L110 > .Ltiny15 deals with copying less than 16 bytes, which includes pointers. > When the data is aligned, the copy of a pointer should be atomic. > Where are the comments and Changelog notes ? How is an arch maintainer to be aware of this requirement when adding support for his/her arch?