Date: Fri, 12 Mar 2004 20:19:33 +0000
From: Christoph Hellwig <hch@infradead.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390 (8/10): zfcp fixes.
Message-ID: <20040312201933.A19244@infradead.org>
Mail-Followup-To: Christoph Hellwig <hch@infradead.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>, akpm@osdl.org,
	linux-kernel@vger.kernel.org
References: <20040312193816.GI2757@mschwid3.boeblingen.de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20040312193816.GI2757@mschwid3.boeblingen.de.ibm.com>; from schwidefsky@de.ibm.com on Fri, Mar 12, 2004 at 08:38:16PM +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 900
Lines: 19

On Fri, Mar 12, 2004 at 08:38:16PM +0100, Martin Schwidefsky wrote:
>  - Replace release function for device structures by kfree. Move struct
>    device to the start of struct zfcp_port/zfcp_unit to make it work.

That's ugly as hell.  Actually even more ugly.  It's not that ->release
is such a performance critical path that you absolutely need to avoid one
level of function calls.  So please put a simple wrapper back instead of
the horrible casts and suddenly the silly placement restrictions are gone,
too.

And *please* send any scsi driver changes to linux-scsi@vger.kernel.org.

While we're at it, what's the reason zfcp isn't in drivers/scsi/?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/