Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp877752imj; Fri, 15 Feb 2019 08:15:47 -0800 (PST) X-Google-Smtp-Source: AHgI3Ib+24uA56M0Mt/yPP5aH/Wgn2r1SHJ/XJOuNigPLm0WjEjisZ3uDWnjNY5Gl8vIixiWJNCI X-Received: by 2002:a17:902:a582:: with SMTP id az2mr10522532plb.275.1550247347597; Fri, 15 Feb 2019 08:15:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550247347; cv=none; d=google.com; s=arc-20160816; b=h3w4aQvhza0BU+rSQb5zXVb7SR7F/f/D1W3LhmvdSW9zMXaX1vCA/J4ziIUMNNHQxA fVF9K/DZECa+GJv4cuKHRGwvy9rfzQcdr+QgsYwrK+z8Dzk+zAMyxQMH5XJNzXWe7vyk 03xyjfs4SbUk6LTTI9jW052o2DDmlwnEx7xJyzwxzzum8Cq5wKjlX6sxjGiTSwlq1HQC YdOPu1uAMg5pJmGS5qc8QvD8GggiV8ebQrs/NCPi7dY0Vp5GjcmdBcoH7JXj8s772iSU 6o5hhUrqvfEe+sDgeuvXFAd1KDCq2fzctPl4A/ShkrFRxX1n6nBHBsr9l9EXTwc5IZso I88Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:organization :subject:cc:to:from:dkim-signature; bh=3kTgHTCfsk0cL9N0ODEgQNqUR4tlICgbFlXl7ximvDI=; b=rPIB8F0SgI2hHKLW4T75bYEBpJxmG9RVRmwQejL4Jggl5RYmQ1cOYbxJrtv08WrtYd j58SEWDa0wLn3e/2uu7PM8a9NcW0ybqnpCk9rpJoGRKmgICxEpQQ1HCGUFgPzXvhXy/B 54YOGI4USrwaCpyzMBpTRuJtMhhTHqd5cxFAKH9rSBU8dPPYpTz3VDXZOEk3tkKLcnmc X24ckRgviUgw3sgGoe68FkmHmZuWVj7X6nZnQy2roYwkmaeoYH3ZNfvuxJ65Ipf2gkh0 i2IQb8B7SS2VcjAwPJKUTsHUBx3mxkhC3eFUROkdTBRzm9Sbzc9Eds3Ylbcd+HrXzf+B FW0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mork.no header.s=b header.b=C4uF2YuR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mork.no Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v19si6112528pfa.80.2019.02.15.08.15.31; Fri, 15 Feb 2019 08:15:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@mork.no header.s=b header.b=C4uF2YuR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mork.no Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406135AbfBOMdD (ORCPT + 99 others); Fri, 15 Feb 2019 07:33:03 -0500 Received: from canardo.mork.no ([148.122.252.1]:54323 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725818AbfBOMdC (ORCPT ); Fri, 15 Feb 2019 07:33:02 -0500 Received: from miraculix.mork.no ([IPv6:2a02:2121:2c1:c222:14c6:42ff:fe4d:851f]) (authenticated bits=0) by canardo.mork.no (8.15.2/8.15.2) with ESMTPSA id x1FCWpoT001733 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 15 Feb 2019 13:32:52 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mork.no; s=b; t=1550233972; bh=3kTgHTCfsk0cL9N0ODEgQNqUR4tlICgbFlXl7ximvDI=; h=From:To:Cc:Subject:References:Date:Message-ID:From; b=C4uF2YuRmvTbhm1nLVb3hR727B61Yn8hCjMebEOKFjq5BNnDSZnMkw46XMarR/yIs KcLq7890BSOqi7E3vlmfnkzxte5Oy1Mm81FOcBP2lHvu8lNXM54J01ORSBNGdVZfGB yiMZQ7KV/Rryx9AVAjKeHH6m3BEMYMPOENr0AssY= Received: from bjorn by miraculix.mork.no with local (Exim 4.89) (envelope-from ) id 1gucfe-0002p0-4V; Fri, 15 Feb 2019 13:32:46 +0100 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Beniamino Galvani Cc: "David S . Miller" , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qmi_wwan: apply SET_DTR quirk to Sierra WP7607 Organization: m References: <20190215122042.23195-1-bgalvani@redhat.com> Date: Fri, 15 Feb 2019 13:32:46 +0100 In-Reply-To: <20190215122042.23195-1-bgalvani@redhat.com> (Beniamino Galvani's message of "Fri, 15 Feb 2019 13:20:42 +0100") Message-ID: <87pnrtut8x.fsf@miraculix.mork.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.100.2 at canardo X-Virus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Beniamino Galvani writes: > The 1199:68C0 USB ID is reused by Sierra WP7607 which requires the DTR > quirk to be detected. Apply QMI_QUIRK_SET_DTR unconditionally as > already done for other IDs shared between different devices. > > Signed-off-by: Beniamino Galvani Thanks. Looks like it's time to consider applying this unconditionally to all devices. Feel free to propose something like that the next time this issue comes up. Acked-by: Bj=C3=B8rn Mork