Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp880315imj; Fri, 15 Feb 2019 08:18:03 -0800 (PST) X-Google-Smtp-Source: AHgI3IbcDqfcuSIWMQ9iclHXzzQ8Gv+q0iZtz2h2k6nBBZXP/J3Nm8lhI3d3DzlfVk957bAyJBCK X-Received: by 2002:a63:6984:: with SMTP id e126mr6186071pgc.143.1550247483869; Fri, 15 Feb 2019 08:18:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550247483; cv=none; d=google.com; s=arc-20160816; b=ItKYLFpBgEpa8MNbOKHlT8WD8VGamoYUc6uP0SkVxU7VCmuP9CGbd1M5nsQ5OSjPsb k/qfPrPG+lKY32Smk7mtQYPluOexpm7aiztDuAdjOiUWkBMoVjoj3ehEEj7bmuEt5dYt FKhl4CSWVW4rZldVIoJpFq4f/ExRXSY6snXVrfPMDTJOx0BtDYix6oveHRAN2UWq3kAy HBCz6hl129risjXY3UvRzQ9AE0VVFbuI+a8sMN3b+lLAlrM/qWXimX+A7V1yQnalABNq rKoxNeysFgtWbrnmfMVT3MMXm8Ptg4fS1ZcDHXCYJNLvgQ5UFM5z2wEd/Fte3bRljNud scIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=vEWEfyi+qciWUPwtr4PbulPVWchEEKsUrWhVZNxdp6Y=; b=QOy+lBZtr+GeSwp7DVPHbFCwCYB5u05cF5EeAXqM7moR5/eG62+Mx9VrIUe1MVF7P/ 6ZhmKjH8TvO7p+6zksRj0dXeEzrFMkaOtyiz5UqH1j3gf1hOXaHi3kYUt/cdsQ/WH7/Y WIAjWazLvQWpMqQckbSR4xEnWoPWXUoF5kHjxaePlUmkzk6ik+3boPJCdgAAV3mNMdll e9JjO2mTZCPU+A0MsdRyasb6h2NEc5/XjDnN4kJ8S/XC3QFwXHiiwdgbISDi8afTKLCZ Md1+ucprOq1CwZ+IHSlTS1orvx0NyFeMonlzvqPKStbcMin8Q4BdDX2SeMWw/4FkcHHQ 2Kig== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=bfD9ar+r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b13si6028245plm.63.2019.02.15.08.17.48; Fri, 15 Feb 2019 08:18:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=bfD9ar+r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729991AbfBONYe (ORCPT + 99 others); Fri, 15 Feb 2019 08:24:34 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:53631 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729262AbfBONYd (ORCPT ); Fri, 15 Feb 2019 08:24:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vEWEfyi+qciWUPwtr4PbulPVWchEEKsUrWhVZNxdp6Y=; b=bfD9ar+r0fwX3s2DGzXMFQ1o0Y V00Ue/GnhTIs3iAjQuUJozweLEXrcBAbr/Kam4r0pnL4Piu308uv51qkNx/bAUnOdCL/HSLDkYcSn be0XULdNqumS84qm3Fee4oJvD2Lx3xQNjn6pzv0oIzncS6oer9VU8aHYUpvf4KJj4p8o=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gudTg-0004v8-Ja; Fri, 15 Feb 2019 14:24:28 +0100 Date: Fri, 15 Feb 2019 14:24:28 +0100 From: Andrew Lunn To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Antoine Tenart , thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com Subject: Re: [PATCH net-next] net: phy: marvell10g: Don't explicitly set Pause and Asym_Pause Message-ID: <20190215132428.GG5699@lunn.ch> References: <20190215083347.5886-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190215083347.5886-1-maxime.chevallier@bootlin.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 15, 2019 at 09:33:47AM +0100, Maxime Chevallier wrote: > The PHY core expects PHY drivers not to set Pause and Asym_Pause bits, > unless the driver only wants to specify one of them due to HW > limitation. In the case of the Marvell10g driver, we don't need to set > them. > > Signed-off-by: Maxime Chevallier > Suggested-by: Andrew Lunn Thanks Maxime Reviewed-by: Andrew Lunn Andrew