Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262992AbUCLVtl (ORCPT ); Fri, 12 Mar 2004 16:49:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262993AbUCLVtl (ORCPT ); Fri, 12 Mar 2004 16:49:41 -0500 Received: from 162.100.172.209.cust.nextweb.net ([209.172.100.162]:32977 "EHLO jlundell.local") by vger.kernel.org with ESMTP id S262992AbUCLVtk (ORCPT ); Fri, 12 Mar 2004 16:49:40 -0500 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <40511868.4060109@usa.net> <4051EB42.8060903@pobox.com> Date: Fri, 12 Mar 2004 13:48:54 -0800 To: linux-kernel@vger.kernel.org From: Jonathan Lundell Subject: Re: [PATCH] ethtool.h should use userspace-accessible types Content-Type: text/plain; charset="us-ascii" ; format="flowed" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 18 At 10:06 AM -0700 3/12/04, Eric W. Biederman wrote: >My intent was to say: Why change the types when there is no #ifdef >__KERNEL__ in the header. With no #ifdef __KERNEL__ it exports >definitions that are private to the kernel making it not safe for >userspace to use. With kernel private definitions in there it will >generate name space pollution if included by user space. Presumably because it *is* included by userspace, because it defines the interface between the kernel and userspace; of course userspace will (does) include it. -- /Jonathan Lundell. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/