Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp931131imj; Fri, 15 Feb 2019 09:09:03 -0800 (PST) X-Google-Smtp-Source: AHgI3IbnxfRDe+M+/OVX/bemg7lzPPGb/18PGZeLw/lUdVj9647I8hwcLlXNW2IWIejXWlLzNcXP X-Received: by 2002:a62:8d46:: with SMTP id z67mr10604296pfd.249.1550250543852; Fri, 15 Feb 2019 09:09:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550250543; cv=none; d=google.com; s=arc-20160816; b=LHKjb3yMdtNDafNItfpvzHn9+vwnNKHjKZ5qlzJbCuAwv9s8f1Q5x4QoTkCwDI/Mp/ ueLkTKwaMIifjgk1Pbpn8Oh+mMuB4prKaY9HXwX7/qv/sSi5PJumgdxz8xUM4uuj8qB/ T/SF6MK98VZayyIDpy0S5a5edd/uqGFWF+kOLv8jdupZyYFoj1v1AHKqD07dASzzjTS9 5mtZmv7ivm8YOAHnFZBtbODCBQ32EA2/NnXDYnYahCn361PW6WOluNHg8HA+wili3O9x twJ7YC6n8n/fHvFLE+dAIDV6eYpEg7wi7x8lKzQupRRSRl/omfOwenOiNUX3Gk2w/3bu K75Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=NXbLxkVEjkUC98nDqbwMu9XwBnfr8Fy+W9xUz87hsi8=; b=e6kigMMF7r1waHTGDwmVCgmngBe6DwisJxNJ+UjDlOzIFKCcltZE+sVQW655SIbtaV 08IBeymUCOY/ed3B7bGtvyl8tLZElg6Nj9MehxFixQ/Eo/BHRKWS5qErp333H2o9X7l8 gU7xX28KqyIio6x6k/o2igRwpxYhvMJjp642iRJvIoXAawVa55cYFKk5y3lLpni+M1U3 sldY0U53rJzLecXUIw9E591tAv/uIpTg3IsUxkg0/SZs/LPJO2L9ihZ2GWaXqjru4M4M x+GIANzTPlzK8C07VPdtK1oqD3KdeeHePXDg6aw+oLPgPWzn5c0taJR4czovOlIln8+K KynQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si5875520plo.254.2019.02.15.09.08.48; Fri, 15 Feb 2019 09:09:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730510AbfBORD0 (ORCPT + 99 others); Fri, 15 Feb 2019 12:03:26 -0500 Received: from foss.arm.com ([217.140.101.70]:35748 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbfBORDW (ORCPT ); Fri, 15 Feb 2019 12:03:22 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D806115BF; Fri, 15 Feb 2019 09:03:21 -0800 (PST) Received: from e112269-lin.arm.com (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E40033F557; Fri, 15 Feb 2019 09:03:18 -0800 (PST) From: Steven Price To: linux-mm@kvack.org Cc: Steven Price , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Dave Hansen , Ingo Molnar , James Morse , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Peter Zijlstra , Thomas Gleixner , Will Deacon , x86@kernel.org, "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/13] mm: pagewalk: Allow walking without vma Date: Fri, 15 Feb 2019 17:02:26 +0000 Message-Id: <20190215170235.23360-6-steven.price@arm.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190215170235.23360-1-steven.price@arm.com> References: <20190215170235.23360-1-steven.price@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since 48684a65b4e3: "mm: pagewalk: fix misbehavior of walk_page_range for vma(VM_PFNMAP)", page_table_walk() will report any kernel area as a hole, because it lacks a vma. This means each arch has re-implemented page table walking when needed, for example in the per-arch ptdump walker. Remove the requirement to have a vma except when trying to split huge pages. Signed-off-by: Steven Price --- mm/pagewalk.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/mm/pagewalk.c b/mm/pagewalk.c index 98373a9f88b8..dac0c848b458 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -36,7 +36,7 @@ static int walk_pmd_range(pud_t *pud, unsigned long addr, unsigned long end, do { again: next = pmd_addr_end(addr, end); - if (pmd_none(*pmd) || !walk->vma) { + if (pmd_none(*pmd)) { if (walk->pte_hole) err = walk->pte_hole(addr, next, walk); if (err) @@ -59,9 +59,14 @@ static int walk_pmd_range(pud_t *pud, unsigned long addr, unsigned long end, if (!walk->pte_entry) continue; - split_huge_pmd(walk->vma, pmd, addr); - if (pmd_trans_unstable(pmd)) - goto again; + if (walk->vma) { + split_huge_pmd(walk->vma, pmd, addr); + if (pmd_trans_unstable(pmd)) + goto again; + } else if (pmd_large(*pmd)) { + continue; + } + err = walk_pte_range(pmd, addr, next, walk); if (err) break; @@ -81,7 +86,7 @@ static int walk_pud_range(p4d_t *p4d, unsigned long addr, unsigned long end, do { again: next = pud_addr_end(addr, end); - if (pud_none(*pud) || !walk->vma) { + if (pud_none(*pud)) { if (walk->pte_hole) err = walk->pte_hole(addr, next, walk); if (err) @@ -95,9 +100,13 @@ static int walk_pud_range(p4d_t *p4d, unsigned long addr, unsigned long end, break; } - split_huge_pud(walk->vma, pud, addr); - if (pud_none(*pud)) - goto again; + if (walk->vma) { + split_huge_pud(walk->vma, pud, addr); + if (pud_none(*pud)) + goto again; + } else if (pud_large(*pud)) { + continue; + } if (walk->pmd_entry || walk->pte_entry) err = walk_pmd_range(pud, addr, next, walk); -- 2.20.1