Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp956920imj; Fri, 15 Feb 2019 09:33:35 -0800 (PST) X-Google-Smtp-Source: AHgI3IbJBJ96oSGcok2wp0kfBEfjWWSa8dGBT1xF6xEck8CUqryF0Iqp+bEkoGHDCzGjNO1JqR9N X-Received: by 2002:a63:6bc1:: with SMTP id g184mr6571077pgc.25.1550252015293; Fri, 15 Feb 2019 09:33:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550252015; cv=none; d=google.com; s=arc-20160816; b=Am4ZY3gAqAcJ9JxpemnGs/ptxX7tOAr60XlqWqoWyycIIA19By1doFApAG5LI8XlaU FajMDUhItxTlpLn8R2MSyugJSjLFlhmaeCQf3CtzFV6rYvKJ8O3b5QIAD2XnSh9w81jM mkuDWaCqgIBqA9RX01AoM4IWzWokVoCzUmUvNm35pD5MNl/F/SwBA436eJjEHYWCxFXu eouUhau2Xp4Z5uCF8NHZz/Ln8JXEYauDY4XD42iZGv2QN8Ga0bzGGv9mgvvdl2RrFHju yUgVGoPV3hUMCMG2amM455zJo1KpVvC3Uv2NwLQETHTBMyJmvFWkofeFT10pij4tjB1c 5odw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=ri3wGGSb3ZjxcvWOJ9kDqmAtUiSO9zTiGqi+iWGaxZY=; b=claM4s65Ejnq6jNuNAdzRW0xIwlgukufbU8lxCLe5CMQsM8jbgL2e9aOWKngNTE2oE Ef9fnFcVRH6m7zqHsNTioWI+lJq/rBuswdIwjIvVX28MoPUGobnIVhoaC3ij8oQbG97u a9hwwnwfFHuZsCcUWdM3ebN8qVa2UfsOyxbdQYAn9XKItwgNLvi6V6N2YP359iRgfFpL ocsBw2ViSZK5uzlCwvwHHrnszNIK2fMJCfu099thcWhLkB7TNkLoeXEvyvuKW6vdWO2X D2FwJnCtu244JtbjFz4/yKGgdE8c0qcWE901otOJEfR8v272sqqwoMiNp42rFfo3Xghc +O9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c142si6059159pfb.33.2019.02.15.09.33.18; Fri, 15 Feb 2019 09:33:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728476AbfBORch (ORCPT + 99 others); Fri, 15 Feb 2019 12:32:37 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:36622 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbfBORch (ORCPT ); Fri, 15 Feb 2019 12:32:37 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA2C5A78; Fri, 15 Feb 2019 09:32:36 -0800 (PST) Received: from [10.1.196.69] (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 02A433F589; Fri, 15 Feb 2019 09:32:33 -0800 (PST) Subject: Re: [PATCH 13/13] x86: mm: Convert dump_pagetables to use walk_page_range To: Dave Hansen , linux-mm@kvack.org Cc: x86@kernel.org, Arnd Bergmann , Ard Biesheuvel , Peter Zijlstra , Catalin Marinas , Dave Hansen , Will Deacon , linux-kernel@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , James Morse , Thomas Gleixner , linux-arm-kernel@lists.infradead.org References: <20190215170235.23360-1-steven.price@arm.com> <20190215170235.23360-14-steven.price@arm.com> <59a6d402-e383-b9d0-499a-7d65b9a2d402@intel.com> From: Steven Price Message-ID: <9d7d1e1f-93de-c9a8-e6bb-63696e162210@arm.com> Date: Fri, 15 Feb 2019 17:32:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <59a6d402-e383-b9d0-499a-7d65b9a2d402@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/02/2019 17:16, Dave Hansen wrote: > On 2/15/19 9:02 AM, Steven Price wrote: >> arch/x86/mm/dump_pagetables.c | 281 ++++++++++++++++++---------------- >> 1 file changed, 146 insertions(+), 135 deletions(-) > > I'll look through this in more detail in a bit. But, I'm a bit bummed > out by the diffstat. When I see patches add a bunch of infrastructure, > I *really* hope for code simplification. > > Looking at the diff, I think it gets there. The code you add is > simpler than the code you remove. But, the diffstat is misleading. I agree, I was disappointed myself by the diffstat. Hopefully the code is simplier though - there's unfortunately quite a bit of boiler plate code in the new version, but that code is at least easier to understand. My hope is that it will be possible to move the boiler plate code into common code (there's a lot of similarity with arm64 here). However I wanted to get some agreement on the approach and make a non-functional change before attempting to unify the different dump_pagetables implementations (which is likely to cause minor functional changes). > I'd probably address this disparity for each patch in the changelogs. Good point, I'll try to remember for next time. Thanks for taking a look, Steve