Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Jeffrey Hugo <jhugo@codeaurora.org>,
        Michael Turquette <mturquette@baylibre.com>
In-Reply-To: <41f8f325-2738-3995-1fc8-354a9412041e@codeaurora.org>
User-Agent: alot/0.8
Subject: Re: [PATCH 2/9] clk: Introduce get_parent_hw clk op
Message-ID: <155025643198.115909.9355230466710329335@swboyd.mtv.corp.google.com>
References: <20190129061021.94775-1-sboyd@kernel.org> <20190129061021.94775-3-sboyd@kernel.org> <41f8f325-2738-3995-1fc8-354a9412041e@codeaurora.org>
Cc:     linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Russell King <linux@armlinux.org.uk>
From:   Stephen Boyd <sboyd@kernel.org>
Date:   Fri, 15 Feb 2019 10:47:11 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Jeffrey Hugo (2019-02-11 08:09:00)
> On 1/28/2019 11:10 PM, Stephen Boyd wrote:
>=20
> > +static int clk_init_parent(struct clk_core *core)
> > +{
> > +     core->parent =3D __clk_init_parent(core, true);
> > +     if (IS_ERR(core->parent))
> > +             return PTR_ERR(core->parent);
> > +
> > +     /*
> > +      * Populate core->parent if parent has already been clk_core_init=
'd. If
> > +      * parent has not yet been clk_core_init'd then place clk in the =
orphan
> > +      * list.  If clk doesn't have any parents then place it in the ro=
ot
> > +      * clk list.
> > +      *
> > +      * Every time a new clk is clk_init'd then we walk the list of or=
phan
> > +      * clocks and re-parent any that are children of the clock curren=
tly
> > +      * being clk_init'd.
> > +      */
> > +     if (core->parent) {
> > +             hlist_add_head(&core->child_node,
> > +                             &core->parent->children);
> > +             core->orphan =3D core->parent->orphan;
> > +     } else if (!core->num_parents) {
> > +             hlist_add_head(&core->child_node, &clk_root_list);
> > +             core->orphan =3D false;
> > +     } else {
> > +             hlist_add_head(&core->child_node, &clk_orphan_list);
>=20
> Missing "core->orphan =3D true;"?
> The snippet below had that line.  Its not clear why it appears to be=20
> dropped here.
>=20

Hmm. Weird. I think I may have been getting ahead of myself and moving
the orphan updating code into __clk_init_parent(). I can't remember why
though, so I guess I'll go all the way and move it all into
__clk_init_parent() now. Thanks for pointing it out.