Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4835360740
Subject: Re: [PATCH 2/9] clk: Introduce get_parent_hw clk op
To:     Stephen Boyd <sboyd@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>
Cc:     linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Russell King <linux@armlinux.org.uk>
References: <20190129061021.94775-1-sboyd@kernel.org>
 <20190129061021.94775-3-sboyd@kernel.org>
 <41f8f325-2738-3995-1fc8-354a9412041e@codeaurora.org>
 <155025643198.115909.9355230466710329335@swboyd.mtv.corp.google.com>
From:   Jeffrey Hugo <jhugo@codeaurora.org>
Message-ID: <488f5033-c7a5-b49b-b973-c1415e533019@codeaurora.org>
Date:   Fri, 15 Feb 2019 12:29:26 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <155025643198.115909.9355230466710329335@swboyd.mtv.corp.google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/15/2019 11:47 AM, Stephen Boyd wrote:
> Quoting Jeffrey Hugo (2019-02-11 08:09:00)
>> On 1/28/2019 11:10 PM, Stephen Boyd wrote:
>>
>>> +static int clk_init_parent(struct clk_core *core)
>>> +{
>>> +     core->parent = __clk_init_parent(core, true);
>>> +     if (IS_ERR(core->parent))
>>> +             return PTR_ERR(core->parent);
>>> +
>>> +     /*
>>> +      * Populate core->parent if parent has already been clk_core_init'd. If
>>> +      * parent has not yet been clk_core_init'd then place clk in the orphan
>>> +      * list.  If clk doesn't have any parents then place it in the root
>>> +      * clk list.
>>> +      *
>>> +      * Every time a new clk is clk_init'd then we walk the list of orphan
>>> +      * clocks and re-parent any that are children of the clock currently
>>> +      * being clk_init'd.
>>> +      */
>>> +     if (core->parent) {
>>> +             hlist_add_head(&core->child_node,
>>> +                             &core->parent->children);
>>> +             core->orphan = core->parent->orphan;
>>> +     } else if (!core->num_parents) {
>>> +             hlist_add_head(&core->child_node, &clk_root_list);
>>> +             core->orphan = false;
>>> +     } else {
>>> +             hlist_add_head(&core->child_node, &clk_orphan_list);
>>
>> Missing "core->orphan = true;"?
>> The snippet below had that line.  Its not clear why it appears to be
>> dropped here.
>>
> 
> Hmm. Weird. I think I may have been getting ahead of myself and moving
> the orphan updating code into __clk_init_parent(). I can't remember why
> though, so I guess I'll go all the way and move it all into
> __clk_init_parent() now. Thanks for pointing it out.
> 

No problem.

Just FYI, I've rebased the 8998 mmcc series on top of this, and as far 
as I can tell, everything seems to be working great.

-- 
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.