Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Jerome Brunet <jbrunet@baylibre.com>,
        Michael Turquette <mturquette@baylibre.com>
In-Reply-To: <121ae6212cd555bc784af675d63f6b190c0bee10.camel@baylibre.com>
User-Agent: alot/0.8
Subject: Re: [PATCH 7/9] clk: Allow parents to be specified without string names
Message-ID: <155026521168.115909.10774224013908368981@swboyd.mtv.corp.google.com>
References: <20190129061021.94775-1-sboyd@kernel.org> <20190129061021.94775-8-sboyd@kernel.org> <2f88e7fb1788f68f7b97d9806d56f9271663bdfc.camel@baylibre.com> <154878820913.136743.9860407353339842831@swboyd.mtv.corp.google.com> <121ae6212cd555bc784af675d63f6b190c0bee10.camel@baylibre.com>
Cc:     linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Russell King <linux@armlinux.org.uk>
From:   Stephen Boyd <sboyd@kernel.org>
Date:   Fri, 15 Feb 2019 13:13:31 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Jerome Brunet (2019-02-13 01:32:23)
> On Tue, 2019-01-29 at 10:56 -0800, Stephen Boyd wrote:
> > > > +/**
> > > > + * struct clk_parent_data - clk parent information
> > > > + * @hw: parent clk_hw pointer (used for clk providers with internal
> > > > clks)
> > > > + * @name: parent name local to provider registering clk
> > > > + * @fallback: globally unique parent name (used as a fallback)
> > > > + */
> > > > +struct clk_parent_data {
> > > > +     struct clk_hw   *hw;
> > > > +     const char      *name;
> > > > +     const char      *fallback;
>=20
> One last nitpick about this structure, because I did not figure it out at
> first.
>=20
> 'fallback' is what we known as 'name' in CCF so far.
>=20
> What do you think about renaming 'fallback' to 'name' and 'name' to somet=
hing
> more obvious, like 'of_name' or 'fw_name' or something else ?

Ok. I'm not super fond of assuming it's the DT specific, so maybe
fw_name is good, or ext_name for external name? Or con_id to match
clkdev?

>=20
> > >=20
> > > If I understand correctly, .name and .fallback will be ignored if hw =
is
> > > provided ? Maybe this should be documented somehow ?
> >=20
> > Sure. I'll add some documentation to the long portion of the kernel-doc
> > here describing priority order.
>=20
> Anyway, with this patch, I should be able to remove a lot of (ugly) code I
> have been writting lately. I'll be happy to test it when you have a v2 re=
ady.
>=20

Great!