Subject: Re: calling flush_scheduled_work()
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Andrew Morton <akpm@osdl.org>
Cc: Tim Hockin <thockin@Sun.COM>, linux-kernel@vger.kernel.org
In-Reply-To: <20040312152747.0b3f74d3.akpm@osdl.org>
References: <20040312205814.GY1333@sun.com>
	 <20040312152747.0b3f74d3.akpm@osdl.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Message-Id: <1079140670.3166.87.camel@lade.trondhjem.org>
Mime-Version: 1.0
Date: Fri, 12 Mar 2004 20:17:50 -0500
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 832
Lines: 22

P? fr , 12/03/2004 klokka 18:27, skreiv Andrew Morton:
> Seems simple enough to fix the workqueue code to handle this situation.
> 
> Wanna test this for me?

What if one of the workloads on the queue has another call to
flush_scheduled_work()? (which again finds itself calling another
instance, ...)
This fix doesn't really resolve the deadlock issue. It just reduces the
possibilities of it having any consequences...

Could you please at least include a dump_stack() before the call to
run_workqueue()) so that we can catch the bug in the act, and attempt to
fix it.

Cheers,
  Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/