Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp350135imj; Sat, 16 Feb 2019 01:38:16 -0800 (PST) X-Google-Smtp-Source: AHgI3IYRVmGqHX08vZvrdxJzHrKx4rlFDkvRieEc3QBR+zk8SaWDc6m4NkE05k4XYVou2c0A3z6P X-Received: by 2002:a63:2f47:: with SMTP id v68mr9295116pgv.144.1550309895931; Sat, 16 Feb 2019 01:38:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550309895; cv=none; d=google.com; s=arc-20160816; b=GFf3lQYpUyvTjMO3xVUEAtQRYPPWaIHvJ9/bXgQ0m25GqjtYELLQE3B8A2vumVckDd oi0gTuLIt9brXNcjKeE7lyNHcj/LjJh4OPcpe2PGOoNocsIZwGixFBTbZUxCgOiegO6S Uy1P3beYfVkZ9E4wc7qCN35QZBY6vWRwXqj+RSlGg2eyBxtdgP3pWumEYoD6xHFMZW9J f/VsoZm/Hdr7RkXgYwuyxzoXkD/DIkLIqmQPr8x+tqpbpMC5QX+GSCBCcrpLg0nobIB+ q3oV6/7B4C4RSoEvfczfBmogZc519KOhkECkr3PsuwK637gZ4JpfyMn5d3HQCAQveWS/ BPmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=7stztTTQE/+WAXvZwsduw1cX+2IcdUP0AmYn2zTVrTY=; b=fmxF70ex47WKSngL/FbkcjtOwko4LSVLNpZDAtxGUpWpnGcIppISKkbRhkPW3Fk3MV V9tnStEejjpmeBp7J8bV8o2SZh5tQ5jdLcgjWbFZdFvOGZu6NeRxUVC3PqHGQ/3B0IC1 eypPwIOSuJoPh2y82Frp89g1MwnWmdBHHKnNHCNePcsQBfQDaZNKOb/FWrBngo2appB3 YeiM6eMci6ZTvvtmCpNEN0nyHf9Do/GvpAErRB3S0GS0QP9pfEHgY873ZepTmtkd0gAj D4Ss7G+YuWuMtkdbEk35+ATXd+9TcHT0rW9sNLIHi/GPsxAwiP4Lt7Fxd5yHeTBsVGAK /0iw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q12si6199758pls.85.2019.02.16.01.38.00; Sat, 16 Feb 2019 01:38:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388314AbfBOX0D (ORCPT + 99 others); Fri, 15 Feb 2019 18:26:03 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:46814 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388134AbfBOX0C (ORCPT ); Fri, 15 Feb 2019 18:26:02 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 4E31180455; Sat, 16 Feb 2019 00:25:54 +0100 (CET) Date: Sat, 16 Feb 2019 00:26:00 +0100 From: Pavel Machek To: Jacek Anaszewski Cc: Hans de Goede , Jacek Anaszewski , Yauhen Kharuzhy , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v2 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs Message-ID: <20190215232600.GA21591@amd> References: <20190212205901.13037-2-jekhor@gmail.com> <1df39a63-533f-bb68-a056-a0241f148be9@redhat.com> <20190213230731.GA8557@amd> <42078a81-e32e-81b7-528f-d1adb60d31c3@redhat.com> <20190213233806.GA11867@amd> <562e2acd-a60a-2aea-4050-6d9414d23a4e@redhat.com> <20190214111423.GE6132@amd> <92cf09b8-726d-4f1b-94ba-368a66af2246@redhat.com> <20190214122840.GA21860@amd> <6beed61c-1fc6-6525-e873-a8978f5fbffb@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline In-Reply-To: <6beed61c-1fc6-6525-e873-a8978f5fbffb@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2019-02-15 22:41:31, Jacek Anaszewski wrote: > Hi Pavel, >=20 > On 2/14/19 1:28 PM, Pavel Machek wrote: > >Hi! > > > >Jacek, could we get you to comment here? I'd prefer "hardware" trigger... >=20 > What prevents use from using pattern trigger with its hw_pattern file? >=20 > Do you remember drivers/leds/leds-sc27xx-bltc.c and its breathing mode, > for which pattern trigger was introduced? Yes, we can do that. But forget heartbeat and blinking now. Problem I'm getting at is that this LED can either be software controlled (showing for example disk activity) or it can show whether the battery is charging (autonomously, in hardware, will work even after kernel crash). Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlxnSogACgkQMOfwapXb+vIFEwCghiDqFaTxqIxtznmzoZHQnXrB J2AAoLuDQcYHggxlTOlNt/WTMKUR/1MI =Sc/n -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X--