Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190211070040.4569-1-jbroadus@gmail.com> <nycvar.YFH.7.76.1902140036400.11598@cbobk.fhfr.pm>
 <CAKgEEwteam5TCWAUtgQKxQpTzTk3+_DktmqwxZTLa=w3xt5i8Q@mail.gmail.com>
 <nycvar.YFH.7.76.1902150834180.11598@cbobk.fhfr.pm> <6280CE2E-0820-48DA-ABA1-621D107511CF@canonical.com>
In-Reply-To: <6280CE2E-0820-48DA-ABA1-621D107511CF@canonical.com>
From:   Jim Broadus <jbroadus@gmail.com>
Date:   Fri, 15 Feb 2019 17:42:14 -0800
Message-ID: <CAKgEEwsO025b1LqQNWqMa7fxEXQWv-4ZjxzCJB2qmBKS8yJG8g@mail.gmail.com>
Subject: Re: [PATCH] Fix resume for ELAN2097 touchscreen.
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@gmail.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Happy new year.

I think you might be right. I found some discussions about Dell
disabling S3 support in a recent bios due to a C-state bug.
I'll try to investigate a bit more this weekend.

Jim

On Fri, Feb 15, 2019 at 1:25 AM Kai-Heng Feng
<kai.heng.feng@canonical.com> wrote:
>
> Hi Jiri and James,
>
> > On Feb 15, 2019, at 15:35, Jiri Kosina <jikos@kernel.org> wrote:
> >
> > On Thu, 14 Feb 2019, james broadus wrote:
> >
> >>> This should be fixed in hid.git#for-5.1/i2c-hid already by commit
> >>> 1475af255e18f. Could you please confirm that?
> >>>
> >>
> >> Hi Jiri. That change mutes the log messages, but I'm still counting
> >> around 35000 interrupts per second after resume and touch does not wor=
k.
> >> With the reset, the device works properly.
> >
> > Ah, I see. Should your patch then actually replace 1475af255e18f?
>
> Sorry for the late reply, was off because of Lunar new year.
>
> Commit 1475af255e18f is to silence the message when using the touchpad, s=
o it=E2=80=99s different to this patch.
>
> I=E2=80=99ve seen similar bugs happens on new platforms that defaults S2I=
dle (Modern Standby), but user uses S3 instead.
> On those systems, S3 was never tested, so the BIOS doesn=E2=80=99t cut th=
e touchpad=E2=80=99s power off during S3, and the IRQ line wasn=E2=80=99t g=
etting properly reset.
>
> So if the platform defaults to S2Idle but user wants to use S3, this issu=
e happens.
> If that=E2=80=99s the case, maybe it=E2=80=99s better to report to the pl=
atform vendor.
>
> Kai-Heng
>
> >
> > Thanks,
> >
> > --
> > Jiri Kosina
> > SUSE Labs
> >
>