Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp454784imj; Sat, 16 Feb 2019 04:12:39 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ/U787c3A12foMVPDtBH6AJ/eV9E9JnWl2mWrA7PTvvUe5Li3I6va07+Sul1R9N99wlq3R X-Received: by 2002:a17:902:b494:: with SMTP id y20mr15559697plr.178.1550319159823; Sat, 16 Feb 2019 04:12:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550319159; cv=none; d=google.com; s=arc-20160816; b=OUFfeF4JMg0n50195L8WL6D5tQYL4EQwqvjQzyu9yvepV6fz0yJjqlsgnGknUiFwsN s4MvfNif+GpWgOeQve69WxFbfiIOkYKSGCJI0UVrFRC397F7QY5bB7nC/Vx7mGDcMo+1 bx3Y8ii5sntc8z7TXtsTSLMP5blTKTdK9oZQBXjmLgVV17JuV1ew0L73OdKSCpb1aDLK MuHhb7kNqVcn4V9Axao/H5ybpJ09RdBOGL6Luagy8Xqsy9M4/jyCQ/4tjiRU3dsLaYLG lhVwpvXLB6sP235IKVVceOX/4Hd6KitDUe40S0/qYyPZTiVTKpgpb+H3xaycfCSXUkfI xwuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=8frFMX7KBKKmdwYMVZFgllDdfgnWuvXdgJpU/B0/sW8=; b=yB9E/m77lXDREAMXWUXniVoXrDYQyTF0gwUJle11632jsnStyvV4e3X88WHV64Buqy 65Pz+re+35cv6hGtFLHKixC3e39MJEwfpcqkl4iHdnN0qnGXWn4RQaCc52n6F/E9BBq2 Yp+Ktw9mw02QiWvEdDNcP/Wg3wL0bA/43FxVSP47/Y+hlEHF5zKOZRvSZ1k7/P3MajGP SAyvV97EpIOXbI/74PDvh6du1sbAtooURe8Ci6W3CDUVoSxm9Q3UzEI7MT+01wgqSc3w VwLIPPnJi0c9mall0tfe7QvJpSFFsVvavYdIsjH8b3av9MzFaAE6/15pXEg6OphqrSmK zXBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=GQTPpAW9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m15si7815255pgb.425.2019.02.16.04.12.23; Sat, 16 Feb 2019 04:12:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=GQTPpAW9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731287AbfBPIod (ORCPT + 99 others); Sat, 16 Feb 2019 03:44:33 -0500 Received: from mout.web.de ([217.72.192.78]:52801 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbfBPIoc (ORCPT ); Sat, 16 Feb 2019 03:44:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1550306647; bh=Wv4RY9Iv2iNuAyTIbgEvXN0i2ER1qisG4NsPV0EopVk=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=GQTPpAW9vlCEYvKqLZ8upOpBHNOqUOFbI841PStRcPUMj9FiUePO6732OWVON+ZEw vjj2xPWtMvbM6ic1PpK0XaQWvhWEbOpnmmtwNeh2+4vjnwnxt14JH7j3NrkS9FNrs1 iOxw1o/qgmVnGv9GLjwdBQxlpdgED5HmpgGVP9Vg= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.3] ([78.48.154.45]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LdF4n-1hKwo20RsX-00iRHJ; Sat, 16 Feb 2019 09:44:07 +0100 Subject: Re: [v5] Coccinelle: semantic code search for missing put_device() To: Julia Lawall , Wen Yang Cc: Gilles Muller , Nicolas Palix , Michal Marek , Yi Wang , Masahiro Yamada , Wen Yang , Cheng Shengyu , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <201902161529041506841@zte.com.cn> <6a07c337-533c-61c2-d033-575539309738@web.de> From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <6c114d10-0d17-6f43-4c33-0f57c230306f@web.de> Date: Sat, 16 Feb 2019 09:44:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:zaR6rqC+H5I2c8ruNGBNcXje4c1H3cY908yNvRAXsJN4lKvSLG8 MfA9s+bZGUtcyevsREmlv9UcfYtlC13IMl30mqYKViRxj1CKL6Pp8MwBzHxCV9rdx4e1cm0 zp/TQGZbR4mZ1FwUngD8HUH0XjG3Pm9QOkWklEcbnUtRGG5ddpJzwqeXpTjJ6q61O5TtyLj ZAyKGPZq0dUC1Ym3OwoPQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:TtvhRHJDssg=:wX+JaFezTjD2yqhAAseERH bcpuR29u4BDbNxFIoMzstmyTVwoB7wIlFHBTRZqI40MmUOb86Vgw+TAVAJnuR9kxgN5XLOCIv GxOaOpo3gaqqH6qEPT9j7whdJhBOj8uoF+kYaguqaJv23nFjshOAFsMwpRMNFtclqEDvcKDGA iDChzxKAPQTe57u/uIhr3BqtsZpUMl/IwPIs0eAMBR99s0O9xLUOX1BC8JeItjl7tcDIA2aHa 0qsEhvK+zgoL2pmuFqtizI1x1FP2OLX+o5PDRmmUKjMlbT4CstqFQeHslJattX7/ExnHL1Tj0 raMwtIds5LyMTyP+SwmimzNDiqAMTcB04KqOowr/aub1jy3IbV7djka/IXvUXfK9sWf5blM5v 7+QZW85dtYp2NVWzLcpvK8hzAnrxRKFqv6Muyc8ainpcoo32IN0BpuZYXVqQj03GwIFT4g01W RE1m5xhKqlRkAdIEV0MiHuKYEzcpvTNLIzoXX3BacHQDaFrjT2IeUyHYzyiDL9ezTUJ+SvS+f bTlQwZNa8uGZb2PkboIuPgkCAkDzOJeXi43v7h6UlUj28767S7Ijkeafrv2jE0093dQb53pTf dkA3RuRomqxIQCAvE3PJALdlASgmiyQUd/ONGjxa8avdARd6nErtwLkDFtza7nAslH8Y692vU dYImuVQ6iNnw7B/QtDOBCMAP+u4W6rMYOpVrRJFNWwFsDrsxh6IWikz1Ln/r9s3+X5KMdjYRt S9/qTgtdAz54l/EBvd/uT1jWLIhFBSKsQ10RutfhkiM+MUFz7N7EOwBHvdlCef8kKEB0TMlF2 SRI4XyW0jetkFaXEMWDicXAUSDVFCJSm9oJR6hDayTbz1RguuOmmOfEvkYtPBpLZr050oYc7b LbruCcayKNRlEiSgc24sYg/dg9aqfgUiPUtAgSFH5h+MMPGR9gPOZfzcygKgkIpbQHhhWrb8t x40AdzSAT3w== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Thus I do not see a need (or requirement) for a duplicate search attemp= t. > > Why don't you actually try it and see what the difference is rather than > repeatedly giving false information? I suggest to clarify this software development disagreement by the followi= ng SmPL code. ... when !=3D put_stuff(my_pointer) when !=3D if (...) { ... put_stuff(my_pointer) ... } Is this a specification for a bit of duplicate code? Or: Do you insist to find such a function call only within a branch of an if s= tatement? Regards, Markus