Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1449451imj; Sun, 17 Feb 2019 06:11:26 -0800 (PST) X-Google-Smtp-Source: AHgI3IYExt3lYSH4VFt5s0F2UK0hVgpt4vmOqMoswsDqRoFfJecvluLIHmlOOTr660OoiDx+wiNI X-Received: by 2002:a63:2706:: with SMTP id n6mr14007375pgn.352.1550412686391; Sun, 17 Feb 2019 06:11:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550412686; cv=none; d=google.com; s=arc-20160816; b=ZfWNvDH1M9qECEScES9QyIKDlYwSTYwFf2LeB5moIw+3/uZwwcsuG8E3e8t5pSyAJj ByTHZniq9c+MJn2cUoMIa1/+V40YZrIKfXRIfze4zkm0zFXjZMbZf0yYpuOgoOrNtXCC ds1KQ8s4XLB6EZNIU3hvz8xK5JrnRpLF+3wAF8fo6OKtC8G+O+VkNdmQdozW2k+iBEAX bf16pjWR6n8an172aWYl7ZhHTe4BZRZA19mQlF6O5OC6/XXqgAjHD9d6gjhueDFNFIN2 Vo3bsckZ18fw8qR1lT75lbXOL8u+Ojd6OA+Aem1dY77y8ES/qVY+65+YIaOTY3cvgWp7 ceyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=idHFXYR6S/qYo2651OVv7ru+dKEcKzkTVcr1oIDeUb0=; b=YJMYACn+SF4Q9250OyKdDwXHYmHDilmg38MDSvogHn3I1G7Ov7lkrav4hJuxZLNLUy e35m4v3seai3xkeYIaThf138VLBPAMIkWBmNx0sokcIkN3oh+8RrNayYLVL+OM5lXxVw BBYtTt6awkDzyjTyb9m2u4VCpg+Q3HehtUFQzBE6B9l5wB57RlwKjx3nDmH9cCJBMZEt ZXihNIxfjSwl7qmlebNWUNmy1N0FUU5ct7iOrQbPyzTmHKwnus13NmSe4JT2RmC89bk3 ZReenjjJwf8OHZNXbyHaI6gStEY90GGuIJjmLY+oSSuVYjQ4gIdvJwuTP+6M+xu2p4MH DEZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 137si8648095pgc.237.2019.02.17.06.11.09; Sun, 17 Feb 2019 06:11:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728773AbfBQNKu (ORCPT + 99 others); Sun, 17 Feb 2019 08:10:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36282 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727656AbfBQNKu (ORCPT ); Sun, 17 Feb 2019 08:10:50 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6FEABC051685; Sun, 17 Feb 2019 13:10:49 +0000 (UTC) Received: from ming.t460p (ovpn-8-16.pek2.redhat.com [10.72.8.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 931F8101E846; Sun, 17 Feb 2019 13:10:28 +0000 (UTC) Date: Sun, 17 Feb 2019 21:10:23 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com Subject: Re: [PATCH V15 00/18] block: support multi-page bvec Message-ID: <20190217131022.GA7296@ming.t460p> References: <20190215111324.30129-1-ming.lei@redhat.com> <20190215145126.GA16717@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190215145126.GA16717@lst.de> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sun, 17 Feb 2019 13:10:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 15, 2019 at 03:51:26PM +0100, Christoph Hellwig wrote: > I still don't understand why mp_bvec_last_segment isn't simply > called bvec_last_segment as there is no conflict. But I don't > want to hold this series up on that as there only are two users > left and we can always just fix it up later. mp_bvec_last_segment() is one bvec helper, so better to keep its name consistent with other bvec helpers. Thanks, Ming