Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: RE: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle
 first
Thread-Topic: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle
 first
Thread-Index: AQHUxUqvA6eOAzVWPUW+Xl7987JiyqXk4fzA
Date:   Mon, 18 Feb 2019 03:04:17 +0000
Message-ID: <VI1PR04MB53274C03CD18C3D3ADB767408B630@VI1PR04MB5327.eurprd04.prod.outlook.com>
References: <20190215162225.19284-1-paul.kocialkowski@bootlin.com>
In-Reply-To: <20190215162225.19284-1-paul.kocialkowski@bootlin.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d39ff746-698d-473d-165c-08d6954dc5b3
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2019 03:04:18.0331
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1648
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
> According to the chipidea driver bindings, the USB PHY is specified via t=
he "phys"
> phandle node. However, this only takes effect for USB PHYs that use the c=
ommon
> PHY framework. For legacy USB PHYs, a simple lookup based on the USB PHY
> type is done instead.
>=20
> This does not play out well when more than one USB PHY is registered, sin=
ce the
> first registered PHY matching the type will always be returned regardless=
 of what
> the driver was bound to.
>=20
> Fix this by looking up the PHY based on the "phys" phandle node.
> Although generic PHYs are rather matched by their "phys-name" and not the=
 "phys"
> phandle directly, there is no helper for similar lookup on legacy PHYs an=
d it's
> probably not worth the effort to add it.
>=20
> When no legacy USB PHY is found by phandle, fallback to grabbing any regi=
stered
> USB2 PHY. This ensures backward compatibility if some users were actually=
 relying
> on this mechanism.
>=20
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
> Changes since v2:
> * Fixed typos in commit message.
>=20
> Changes since v1:
> * Only consider legacy USB PHY error for fallback as suggested;
> * Checked against EPROBE_DEFER before entering fallback.
>=20
>  drivers/usb/chipidea/core.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c in=
dex
> 7bfcbb23c2a4..016e4004fe9d 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -954,8 +954,15 @@ static int ci_hdrc_probe(struct platform_device *pde=
v)
>  	} else if (ci->platdata->usb_phy) {
>  		ci->usb_phy =3D ci->platdata->usb_phy;
>  	} else {
> +		ci->usb_phy =3D devm_usb_get_phy_by_phandle(dev->parent, "phys",
> +							  0);
>  		ci->phy =3D devm_phy_get(dev->parent, "usb-phy");
> -		ci->usb_phy =3D devm_usb_get_phy(dev->parent,
> USB_PHY_TYPE_USB2);
> +
> +		/* Fallback to grabbing any registered USB2 PHY */
> +		if (IS_ERR(ci->usb_phy) &&
> +		    PTR_ERR(ci->usb_phy) !=3D -EPROBE_DEFER)
> +			ci->usb_phy =3D devm_usb_get_phy(dev->parent,
> +						       USB_PHY_TYPE_USB2);
>=20

I think you may need to do above if ci->phy is error, and not the error is =
-EPROBE_DEFER.

Peter

>  		/* if both generic PHY and USB PHY layers aren't enabled */
>  		if (PTR_ERR(ci->phy) =3D=3D -ENOSYS &&
> --
> 2.20.1