Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190214145231.8750-1-brgl@bgdev.pl> <20190214145231.8750-34-brgl@bgdev.pl>
 <681a7831-8c20-d634-a1cb-04064e3077b8@lechnology.com>
In-Reply-To: <681a7831-8c20-d634-a1cb-04064e3077b8@lechnology.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Mon, 18 Feb 2019 09:12:23 +0100
Message-ID: <CAMpxmJXvqTCYCHwJujx=A4Ga+bZP+fKpJTf++FkmYdQHR5HJew@mail.gmail.com>
Subject: Re: [PATCH v4 33/37] ARM: davinci: cp-intc: use readl/writel_relaxed()
To:     David Lechner <david@lechnology.com>
Cc:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Sekhar Nori <nsekhar@ti.com>,
        Kevin Hilman <khilman@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>,
        arm-soc <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

niedz., 17 lut 2019 o 11:01 David Lechner <david@lechnology.com> napisa=C5=
=82(a):
>
> On 2/14/19 8:52 AM, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > Raplace all calls to __raw_readl() & __raw_writel() with readl_relaxed(=
)
>
> s/Raplace/Replace/
>
> > and writel_relaxed() respectively. It's safe to do as there's no
> > endianness conversion being done in the code.
>
> Should this be combined with patch 14/37?
>

No, this is for cp-intc and the other one is for aintc. I'd keep them separ=
ate.

Bart

> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > ---
> >   arch/arm/mach-davinci/cp_intc.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-davinci/cp_intc.c b/arch/arm/mach-davinci/cp=
_intc.c
> > index 1bf11fa8be76..f88b7f0978aa 100644
> > --- a/arch/arm/mach-davinci/cp_intc.c
> > +++ b/arch/arm/mach-davinci/cp_intc.c
> > @@ -45,13 +45,13 @@ static struct irq_domain *davinci_cp_intc_irq_domai=
n;
> >
> >   static inline unsigned int davinci_cp_intc_read(unsigned int offset)
> >   {
> > -     return __raw_readl(davinci_cp_intc_base + offset);
> > +     return readl_relaxed(davinci_cp_intc_base + offset);
> >   }
> >
> >   static inline void davinci_cp_intc_write(unsigned long value,
> >                                        unsigned int offset)
> >   {
> > -     __raw_writel(value, davinci_cp_intc_base + offset);
> > +     writel_relaxed(value, davinci_cp_intc_base + offset);
> >   }
> >
> >   static void davinci_cp_intc_ack_irq(struct irq_data *d)
> >