Subject: possible kernel bug in signal transit.
From: Alex Lyashkov <shadow@psoft.net>
To: linux-kernel@vger.kernel.org
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Organization: PSoft
Message-Id: <1079197336.13835.15.camel@berloga.shadowland>
Mime-Version: 1.0
Date: Sat, 13 Mar 2004 19:02:17 +0200
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 970
Lines: 30

Hello All

I analyze kernel vanila 2.6.4 and found one possible bug in
__kill_pg_info function.

        for_each_task_pid(pgrp, PIDTYPE_PGID, p, l, pid) {
                err = group_send_sig_info(sig, info, p);
                if (retval)
                        retval = err;
        }
but I think if (retval) is incorrect check. possible this cycle must be
        for_each_task_pid(pgrp, PIDTYPE_PGID, p, l, pid) {
                err = group_send_sig_info(sig, info, p);
                if (ret) {
                        retval = err;
			break;
		}
        }
because in original variant me assign to retval only first value from
ret and other be ignored if this value be 0.


-- 
Alex Lyashkov <shadow@psoft.net>
PSoft
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/