Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2299454imj; Mon, 18 Feb 2019 03:40:36 -0800 (PST) X-Google-Smtp-Source: AHgI3IZcdnivtbhRZbivJkN1hqsAsglP+mjALQ7w//mFmjPvL5BH3Ssur7c4Yr/KWvUkBtmhex6+ X-Received: by 2002:a17:902:6b8a:: with SMTP id p10mr25119482plk.109.1550490036825; Mon, 18 Feb 2019 03:40:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550490036; cv=none; d=google.com; s=arc-20160816; b=KY/OFAqbCdECTip6ygaJADuI3GIZ5bwOWEdVzcWshqMtHLADVicWlTNFO1fswUagvT mkVVmv7LhqFti9z3rFk6Nw5qpXlk0a2w+M9T07O6E41/pjP9GyEz2oslEqDT65B8m/Vt 9bvFjGr9fnhcTJ5iWtj6i1RE2OezBMPgZCTiykc3iVgJAoeX+g4oT4EkAC5vW7Z49P/8 j8qSg8N6qC+AbQfECJ1eFEyXJSxdxmk+GZfa5ojcG9kTzGYIQzpnt9QY5A9gCCXbbjoQ G8LPxuRO82z39LussnzbIotxrRiFsb7NUcbWozd0kO2H5kRbLXCPok9xfJ1miZObSHZs eg+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=oKffzBACjkSj6o9w5aZt7Px1P4l0HPVu2+Xyfumag+E=; b=p9rqOy+Aw+ka/0/CMVhf79JLL3Evfoa814IwuugIUmB3uUQMhXbX9Ge2CYubCfEQyW 4Dczb+PecU9z/DYq+nI6oxcuYLfb3uCZ/PttZkVeEyjWjzvP1x3ev2IUqk5hZh+mJB+Q MRwg3OWeYsYpCaKgJwl7omShAblGl6KDiHXsVhAa6+HWkyecyczzYmHfqHqnVueJlLSX SFEFOQ6mYBkSj8z+efQ9aCG/+EX8rBAeKe//HwCJApnRZEg9mjF9NLMSafiASEIep6r/ 20Q5rmd2tSsl4Qr7OczaQsRfwKFlkfU3+hpDQxLzfl2qjfniW2m38yrprSOLnXtjVBnO 9p/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=dJE0dmec; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p9si12845587pfe.167.2019.02.18.03.40.20; Mon, 18 Feb 2019 03:40:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=dJE0dmec; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729681AbfBRLbs (ORCPT + 99 others); Mon, 18 Feb 2019 06:31:48 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:45284 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729467AbfBRLbr (ORCPT ); Mon, 18 Feb 2019 06:31:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oKffzBACjkSj6o9w5aZt7Px1P4l0HPVu2+Xyfumag+E=; b=dJE0dmec0vzaWeeAGiwYX0sX5 nTF4DE3finLImKyx8Rlxnu7yd/tEDz+Wv8tZxIxlixjmWGgRCzpOMEQJB5Xw/W055+MGcXyPmyfSG IhVmVYTUO9XF1yKO/npu5E2EJDOuJawlJLGG3lmEh74A//1DSdhV9zkLXXKHoDwN3E9jF9hzqU8kt N6jeDN4rIhzAsPwEX0kBhUdPR4Itcl5eZZpn88O7HU94itGvbIi1SXdA9D1XBzxxKPQwQBIxhNb/v JMK9clZRMvsyKeXWSpPqBf0BZ14S2k6Svs2UBj8gMFXeugRLTMPseVXLBH1BjxnZBrx9RBLZChFzu Wjs0KXdWA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gvh96-0001st-Ep; Mon, 18 Feb 2019 11:31:38 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id E8BBF23EAF75C; Mon, 18 Feb 2019 12:31:34 +0100 (CET) Date: Mon, 18 Feb 2019 12:31:34 +0100 From: Peter Zijlstra To: Steven Price Cc: linux-mm@kvack.org, Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Dave Hansen , Ingo Molnar , James Morse , =?iso-8859-1?B?Suly9G1l?= Glisse , Thomas Gleixner , Will Deacon , x86@kernel.org, "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kan.liang@linux.intel.com, kirill@shutemov.name Subject: Re: [PATCH 03/13] mm: Add generic p?d_large() macros Message-ID: <20190218113134.GU32477@hirez.programming.kicks-ass.net> References: <20190215170235.23360-1-steven.price@arm.com> <20190215170235.23360-4-steven.price@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190215170235.23360-4-steven.price@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 15, 2019 at 05:02:24PM +0000, Steven Price wrote: > From: James Morse > > Exposing the pud/pgd levels of the page tables to walk_page_range() means > we may come across the exotic large mappings that come with large areas > of contiguous memory (such as the kernel's linear map). > > For architectures that don't provide p?d_large() macros, provided a > does nothing default. Kan was going to fix that for all archs I think.. See: http://lkml.kernel.org/r/20190204105409.GA17550@hirez.programming.kicks-ass.net > Signed-off-by: James Morse > Signed-off-by: Steven Price > --- > include/asm-generic/pgtable.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h > index 05e61e6c843f..7630d663cd51 100644 > --- a/include/asm-generic/pgtable.h > +++ b/include/asm-generic/pgtable.h > @@ -1186,4 +1186,14 @@ static inline bool arch_has_pfn_modify_check(void) > #define mm_pmd_folded(mm) __is_defined(__PAGETABLE_PMD_FOLDED) > #endif > > +#ifndef pgd_large > +#define pgd_large(x) 0 > +#endif > +#ifndef pud_large > +#define pud_large(x) 0 > +#endif > +#ifndef pmd_large > +#define pmd_large(x) 0 > +#endif > + > #endif /* _ASM_GENERIC_PGTABLE_H */ > -- > 2.20.1 >