Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2418108imj; Mon, 18 Feb 2019 05:45:50 -0800 (PST) X-Google-Smtp-Source: AHgI3IYC28D1NEDeljyxUv4yCYZ2CLpTMFmCV91Oo77EQLL8X9ge/jQVWlkGFbqT+CF4G6/0GbeM X-Received: by 2002:a17:902:5ac9:: with SMTP id g9mr25794288plm.205.1550497550518; Mon, 18 Feb 2019 05:45:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550497550; cv=none; d=google.com; s=arc-20160816; b=evoQmbog3VSe02+LuOBwegLjXRpO8F9/k9xG8l2VEG2cv5Rs+gitrCYk1ik9QYgw7o XNglCGcHNlPbt5SwDUX4xUDUQ+iTDHwI09FP0z0nFzOipluOl6HI49WSo6zGEZMDBtw4 woXP8Ac1octpMh/zsEMAoEsKpeaL5k0iSh714T3NwRE+f4a+zqW/oeTAKdhGMR1m+4wo WUhHFu7+F5iLTYii725x6lxrOfwiD6LB56i63elRiAO2XLXagGLfbN6up7W3im6q9UQp Ge0thci2OI3EeheHm/WNVZ8UVanUcedDnEPzBTOvB1+cfjbu9kaGZtQAsw34wBb/Dkpn ImKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=EVE1s1DQfwmPycFRXHsj6XbVOo8+26rZ/T0YzEz4eFA=; b=c7/Nq2qj9HX/dX0kKfQI7yioK9cjJVz62DlyQ3dxi11nGpPfK5bE3arUrPklUY3Qy8 upTUaBfxZHP0YVA48BRFjiyrN7P4XceW562UVWf20SDbbkV9GN5o0DqeeAYOYSy0fCuG AnV7AXNj8ZAKErPBzbT/FCPRW8eyU3FSUmLkzktg+mr0gsM4j8MHR0SGzDShlQxHVGuh 5EQEHY5GlgFSHPNTuHzG1gmzaiaqZCfS+LDsLWlzU0OKwaFUl87y142xeh4Ep4ovFYb7 sK85rWXWt/UY6xygj6v3tbZ5NutlehVNVuEcb9c4Yb0kijOX9YTDHdTenjM8Hn9QOtTC l6Sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q5si5262740pgc.425.2019.02.18.05.45.34; Mon, 18 Feb 2019 05:45:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730534AbfBRNIN (ORCPT + 99 others); Mon, 18 Feb 2019 08:08:13 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:41756 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728833AbfBRNIM (ORCPT ); Mon, 18 Feb 2019 08:08:12 -0500 Received: from marcel-macpro.fritz.box (p4FF9F361.dip0.t-ipconnect.de [79.249.243.97]) by mail.holtmann.org (Postfix) with ESMTPSA id 22981CF2C7; Mon, 18 Feb 2019 14:16:04 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: [PATCH 4/6] Bluetooth: mediatek: pass a pointer to mtk_hci_wmt_sync From: Marcel Holtmann In-Reply-To: <614e7741328e835071099ddcd4f9c2afd9528534.1550184473.git.sean.wang@mediatek.com> Date: Mon, 18 Feb 2019 14:08:10 +0100 Cc: robh+dt@kernel.org, mark.rutland@arm.com, Johan Hedberg , devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <7A2615D4-1497-4BE2-8E89-66447370E31E@holtmann.org> References: <614e7741328e835071099ddcd4f9c2afd9528534.1550184473.git.sean.wang@mediatek.com> To: Sean Wang X-Mailer: Apple Mail (2.3445.102.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sean, > Pass a structure pointer to mtk_hci_wmt_sync rather than several arguments > to avoid take up additional stack area and be better to read the code. > > Signed-off-by: Sean Wang > --- > drivers/bluetooth/btmtkuart.c | 63 ++++++++++++++++++++++++++--------- > 1 file changed, 48 insertions(+), 15 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel