Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ken Sloat <KSloat@aampglobal.com>
To:     "Eugen.Hristev@microchip.com" <Eugen.Hristev@microchip.com>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "Nicolas.Ferre@microchip.com" <Nicolas.Ferre@microchip.com>,
        "sakari.ailus@iki.fi" <sakari.ailus@iki.fi>,
        "hverkuil@xs4all.nl" <hverkuil@xs4all.nl>
Subject: RE: [PATCH] media: atmel: atmel-isc: reworked driver and formats
Thread-Topic: [PATCH] media: atmel: atmel-isc: reworked driver and formats
Thread-Index: AQHUxQm2DhFZfyQ1n0i/a5kxwOkcZ6Xlk30w
Date:   Mon, 18 Feb 2019 13:37:26 +0000
Message-ID: <BL0PR07MB4115ECEE3BED0B46C342F4A9AD630@BL0PR07MB4115.namprd07.prod.outlook.com>
References: <1550219467-9532-1-git-send-email-eugen.hristev@microchip.com>
In-Reply-To: <1550219467-9532-1-git-send-email-eugen.hristev@microchip.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: aampglobal.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8551840e-27a2-4799-23f6-08d695a638db
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2019 13:37:26.8868
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: e20e3a66-8b9e-46e9-b859-cb654c1ec6ea
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB5426
X-MS-Exchange-CrossPremises-AuthAs: Internal
X-MS-Exchange-CrossPremises-AuthMechanism: 04
X-MS-Exchange-CrossPremises-AuthSource: BL0PR07MB4115.namprd07.prod.outlook.com
X-MS-Exchange-CrossPremises-TransportTrafficType: Email
X-MS-Exchange-CrossPremises-TransportTrafficSubType: 
X-MS-Exchange-CrossPremises-SCL: 1
X-MS-Exchange-CrossPremises-messagesource: StoreDriver
X-MS-Exchange-CrossPremises-BCC: 
X-MS-Exchange-CrossPremises-originalclientipaddress: 96.59.174.230
X-MS-Exchange-CrossPremises-transporttraffictype: Email
X-MS-Exchange-CrossPremises-transporttrafficsubtype: 
X-MS-Exchange-CrossPremises-antispam-scancontext: DIR:Originating;SFV:NSPM;SKIP:0;
X-MS-Exchange-CrossPremises-processed-by-journaling: Journal Agent
X-OrganizationHeadersPreserved: BL0PR07MB5426.namprd07.prod.outlook.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Eugen.Hristev@microchip.com <Eugen.Hristev@microchip.com>
> Sent: Friday, February 15, 2019 3:38 AM
> To: linux-media@vger.kernel.org; linux-arm-kernel@lists.infradead.org; li=
nux-
> kernel@vger.kernel.org; mchehab@kernel.org;
> Nicolas.Ferre@microchip.com; Ken Sloat <KSloat@aampglobal.com>;
> sakari.ailus@iki.fi; hverkuil@xs4all.nl
> Cc: Eugen.Hristev@microchip.com
> Subject: [PATCH] media: atmel: atmel-isc: reworked driver and formats
>=20
> From: Eugen Hristev <eugen.hristev@microchip.com>
>=20
> This change is a redesign in the formats and the way the ISC is configure=
d
> w.r.t. sensor format and the output format from the ISC.
> I have changed the splitting between sensor output (which is also ISC inp=
ut)
> and ISC output.
> The sensor format represents the way the sensor is configured, and what I=
SC
> is receiving.
> The format configuration represents the way ISC is interpreting the data =
and
> formatting the output to the subsystem.
> Now it's much easier to figure out what is the ISC configuration for inpu=
t, and
> what is the configuration for output.
> The non-raw format can be obtained directly from sensor or it can be done
> inside the ISC. The controller format list will include a configuration f=
or each
> format.
> The old supported formats are still in place, if we want to dump the sens=
or
> format directly to the output, the try format routine will detect and con=
figure
> the pipeline accordingly.
> This also fixes the previous issues when the raw format was NULL which
> resulted in many crashes for sensors which did not have the expected/test=
ed
> formats.
>=20
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> Hello Ken and possibly others using ISC driver,
>=20
> I would appreciate if you could test this patch with your sensor, because=
 I do
> not wish to break anything in your setups.
> Feedback is appreciated if any errors appear, so I can fix them.
> I tested with ov5640, ov7670, ov7740(only in 4.19 because on latest it's
> broken for me...) Rebased this patch on top of mediatree.git/master Thank=
s!
>=20
> Eugen
>=20
Hi Eugen,

No problem I will try to test sometime this week on my setup. I appreciate =
you keeping me in the loop.

Thanks,
Ken