Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2430519imj; Mon, 18 Feb 2019 05:59:45 -0800 (PST) X-Google-Smtp-Source: AHgI3IYCOq7lBZwj1fLttT6S+ZcHjJa543OZILZMvCupl357CbWk48iFn4/LULo0GpEGFFfYdVzf X-Received: by 2002:a63:545:: with SMTP id 66mr18754170pgf.102.1550498385343; Mon, 18 Feb 2019 05:59:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550498385; cv=none; d=google.com; s=arc-20160816; b=mgTpAWXMqH4lCqrxBNRTzWGCI7xsgGqcV9MfJR17eaPKC6xWYEIosuRpDzJEm9G8e5 7ZiqGsl8uwpIOk6rwzLTGeDDlZvSMiSDc+kWQPVVoy8kCYa4LTgveHYwk+fBuhWyKfwY CiGIOn/VI1syo5eVnB63LWxPBjZEmH3gCNBseNdRF4DxqEZpfFs2s5C/1EwVAaIMDcqm 29xM39l1Q/O3wV9+gC5tkdoIguAObE119rzVrIxLpe6OINqZx0ZrlmS1nGRONnK+k4YG 1p/f5qFncPTadc09NmbxKqgW4bIioAlBmxgEiyspc3/3cRJYh3PTpZvZjFAP16DeIN/Q rprQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OM+RlrOA3cH/sXv9IcDP5n2pkoAz/msxODYNU68K1AI=; b=Yf5fBfPZGhrBt3MYrnG8WjUUkPaTtvRC7a3oROFmd7El851dQTLLFqC02uJOGIDR1Q f59xl8WMHLoKxpi4SqoZE0v3pdIE+fStssDfJtk0Syymuvn9XElixekSBaZG4hOpLpHz fT6NHGb/8V8ZHiQ4DUnpNpVeuYqFFzJupJDdLzdXisorTw1UJ8a1vBQqaGDe6OWq8d1r w4hNo/QADU2xmxVkE4P1RE+OWNyV7AoZfuv7IR6HhmHRkakFXn/YBoF2t04PKgdZ8Yta PiIdhNkWZrQPUrt6QKqhNLIT3vYfSA+GtTGEMJ2O6Yeh2tk6cvOi9ZTLgs5jxnegHYpN 39aQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Yzd8ZsS3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f20si12621500pfn.122.2019.02.18.05.59.29; Mon, 18 Feb 2019 05:59:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Yzd8ZsS3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388416AbfBRN6m (ORCPT + 99 others); Mon, 18 Feb 2019 08:58:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:39436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388375AbfBRN6k (ORCPT ); Mon, 18 Feb 2019 08:58:40 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61CB1217D9; Mon, 18 Feb 2019 13:58:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550498319; bh=qoVotWeowd3e/Gt3b5w+igFCFO0pgsA8cADah4dCbHQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yzd8ZsS3fltWd46KxockfTqBi1Vp1mRp8oQgbU4q2cdTSlGzQXtUDwzCs6dnv6RMM Sq0oGnX1uOTrrx6TmVk5bJ9yWYwYn0T3/pvygaD94/PJvo4VXgiSCw5obu9ValiTn9 7V+AAt1MBIO4EMGPl23T2z7FM64ET43uzWqTEO5w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jamie Lentin , Guenter Roeck , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Julien DAscenzio , Linus Walleij , Sasha Levin Subject: [PATCH 4.9 31/58] ARM: dts: kirkwood: Fix polarity of GPIO fan lines Date: Mon, 18 Feb 2019 14:43:52 +0100 Message-Id: <20190218133511.038736877@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190218133508.567416115@linuxfoundation.org> References: <20190218133508.567416115@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit b5f034845e70916fd33e172fad5ad530a29c10ab ] These two lines are active high, not active low. The bug was found when we changed the kernel to respect the polarity defined in the device tree. Fixes: 1b90e06b1429 ("ARM: kirkwood: Use devicetree to define DNS-32[05] fan") Cc: Jamie Lentin Cc: Guenter Roeck Cc: Jason Cooper Cc: Andrew Lunn Cc: Gregory Clement Cc: Sebastian Hesselbarth Cc: Julien D'Ascenzio Reviewed-by: Andrew Lunn Tested-by: Jamie Lentin Reported-by: Julien D'Ascenzio Tested-by: Julien D'Ascenzio Signed-off-by: Linus Walleij Signed-off-by: Gregory CLEMENT Signed-off-by: Sasha Levin --- arch/arm/boot/dts/kirkwood-dnskw.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/kirkwood-dnskw.dtsi b/arch/arm/boot/dts/kirkwood-dnskw.dtsi index d8fca9db46d0..dddbc0d03da5 100644 --- a/arch/arm/boot/dts/kirkwood-dnskw.dtsi +++ b/arch/arm/boot/dts/kirkwood-dnskw.dtsi @@ -35,8 +35,8 @@ compatible = "gpio-fan"; pinctrl-0 = <&pmx_fan_high_speed &pmx_fan_low_speed>; pinctrl-names = "default"; - gpios = <&gpio1 14 GPIO_ACTIVE_LOW - &gpio1 13 GPIO_ACTIVE_LOW>; + gpios = <&gpio1 14 GPIO_ACTIVE_HIGH + &gpio1 13 GPIO_ACTIVE_HIGH>; gpio-fan,speed-map = <0 0 3000 1 6000 2>; -- 2.19.1