Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2430629imj; Mon, 18 Feb 2019 05:59:54 -0800 (PST) X-Google-Smtp-Source: AHgI3IbQp55LrCiVvjBfi9abTvdbyWyVueznF90uDGPuGxKwqTapTv9TtciLNILajhxSBhRUcvJP X-Received: by 2002:a17:902:9a09:: with SMTP id v9mr20686214plp.225.1550498394511; Mon, 18 Feb 2019 05:59:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550498394; cv=none; d=google.com; s=arc-20160816; b=nemi8dk7DLjLrqroYoMic0vjCPfmINfKc+sxCUd8/69shq8OrqhZiFg/DZidGfHUYz F+giXjesbzAhONfCcbPWHixcN790HFcTofq+n4el+s/FuWVu9pdAM8AsAN4SovpqId82 QglwnGch5E4us+KAbzC9Bz0++BsY8j0kGO8UB+LAJi+IGIe0w5YbvERffN8VAbfVR4Nl 5CqCiU3582m9G6GYOpz/kkZ9npvMpGEpEGuiUi97HDjVPTtsh8H7SCnYzDBibB24Kbj2 3ZKTzFIxoLL3Ldi2/Nmvp0BW3nCVuN15LLbtifGQSOOJK4HYgvJZvVX4SIoBWh8RkdLt /X+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lOZfNWi0z/Ni8KT6vBZDha/xOAF+cZbeBdc8+KMubNI=; b=sKGk8/p/y6lGhRaYGpN4miUmmCohRhSpEYV+IwoD3/DxfffJOTHzw2MT+UgKh+fYXP jX1095M58FAi/B3XD9ZO6ZBiZC/nrFdVkOa0mnqHsEPttbJ4Lz9TQyW84XsbNbweivYx 3Y+0ouNL/3ye3djbZcbuZVtLie6VyN5ZdpQXhVzgemusTVmbcEpxoiqRpOZ0a81emkzX 9vuIN7ttfdH0FobvEGy+jLXdQ6jTb7J5J+2VTFk2qjgcDdq6uX8f1OlGg15H/z152jiR kp+HCU4uXnOYz7yfCdSgi6AJ7YaIyRTsdenD/JzRxkVMzPlk8PdU7GIHJeoKFZF95AhG 7ykg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W87+2bQZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v127si8648176pgb.459.2019.02.18.05.59.38; Mon, 18 Feb 2019 05:59:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W87+2bQZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388391AbfBRN6f (ORCPT + 99 others); Mon, 18 Feb 2019 08:58:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:39262 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388375AbfBRN6b (ORCPT ); Mon, 18 Feb 2019 08:58:31 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 27B50217D9; Mon, 18 Feb 2019 13:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550498310; bh=gt8js6bW8WLLjEi5Zh3UB7HXo/ikp0tVHO9urK7YR1c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W87+2bQZe8Cp46iGVYL+4yq8NCwPcjf4ywrTHwI5jMV/OCuehDGApOQa9M7qpluQU Pu4Sm2rQDbP/zPYyKDU8IevoOK5/yoHn3FlPRbQa0Uu7vPWqcMlAXJZZPbBHfOmcQt 5DC0pWPj7KQFATqHsnAHv7HdXGunkgaCYHUX09aw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomi Valkeinen , Andrzej Hajda , Sasha Levin Subject: [PATCH 4.9 28/58] drm/bridge: tc358767: fix output H/V syncs Date: Mon, 18 Feb 2019 14:43:49 +0100 Message-Id: <20190218133510.768733485@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190218133508.567416115@linuxfoundation.org> References: <20190218133508.567416115@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 7923e09c7a766e2d58de7fc395bb84c18e5bc625 ] The H and V syncs of the DP output are always set to active high. This patch fixes the syncs by configuring them according to the videomode. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda Signed-off-by: Andrzej Hajda Link: https://patchwork.freedesktop.org/patch/msgid/20190103115954.12785-7-tomi.valkeinen@ti.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/bridge/tc358767.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 16fa42984c50..fa3f2f039a74 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -96,6 +96,8 @@ #define DP0_STARTVAL 0x064c #define DP0_ACTIVEVAL 0x0650 #define DP0_SYNCVAL 0x0654 +#define SYNCVAL_HS_POL_ACTIVE_LOW (1 << 15) +#define SYNCVAL_VS_POL_ACTIVE_LOW (1 << 31) #define DP0_MISC 0x0658 #define TU_SIZE_RECOMMENDED (63) /* LSCLK cycles per TU */ #define BPC_6 (0 << 5) @@ -724,7 +726,9 @@ static int tc_set_video_mode(struct tc_data *tc, struct drm_display_mode *mode) tc_write(DP0_ACTIVEVAL, (mode->vdisplay << 16) | (mode->hdisplay)); - tc_write(DP0_SYNCVAL, (vsync_len << 16) | (hsync_len << 0)); + tc_write(DP0_SYNCVAL, (vsync_len << 16) | (hsync_len << 0) | + ((mode->flags & DRM_MODE_FLAG_NHSYNC) ? SYNCVAL_HS_POL_ACTIVE_LOW : 0) | + ((mode->flags & DRM_MODE_FLAG_NVSYNC) ? SYNCVAL_VS_POL_ACTIVE_LOW : 0)); tc_write(DPIPXLFMT, VS_POL_ACTIVE_LOW | HS_POL_ACTIVE_LOW | DE_POL_ACTIVE_HIGH | SUB_CFG_TYPE_CONFIG1 | DPI_BPP_RGB888); -- 2.19.1