Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2435205imj; Mon, 18 Feb 2019 06:03:17 -0800 (PST) X-Google-Smtp-Source: AHgI3IZfT0RN8PXYwhlKJhZAyNnYMPIwIrqhGxXxsPGamY0vG8QbJtQDcGWMnuJjz5eoMrlSlOFi X-Received: by 2002:a62:46db:: with SMTP id o88mr24478102pfi.248.1550498597654; Mon, 18 Feb 2019 06:03:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550498597; cv=none; d=google.com; s=arc-20160816; b=R8+pv/MHcIaRaTpnyDC2ctnzltVqo7k4NKYaqirGKMv17J0RMe8wOdM1q/qaAxPcCM 7s7SovXsgticBL4B52JzLqCfhaymZhXvA7yJkZvIrZGXkDxMhQUX0ULL2Lgd1P62k2ZJ WYUeNbV56wkEH+nUVfneub6bdTauN30VMiWrU+Aw6Mit9eUFe4WNmFfGF3D4ofk545sW I990Ny2dqcpFbY95dNIHx5bex75TIe5BFzPW6BvRB9KnUTsKYsme6/PysDGYfy6OlU8c 3HEnMyi90Em2M3bgdKOY/hKxVmHzHK/f9a/7Z4fsXg+rZJm72gXo05ZRL0ZftwCDY+AO Bi8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HSAdBaYfBMhN7DsLzo73GKjYsvlYBGt7B87Shoukxnw=; b=vZdMs7UdzxVHu3nkekVI4e430pofsLfSZ8xH6FzoFV5kFVCO0cQtMhMvFuivm4Vovr Cd1DB7kcA/2Nqha5BH/mJbBdSgfnlfUfDG0hD6BgfY/vknYEVguTuWdEl+vtS7HW3QzR ecDhroCAHF2ZzcjO2yAVEipr7ZpOyFy3uiLgWiFsjjBWN561BWAwt0Ewjd9Zx3/Gbu3W NF48DyskocHtK0jQqa05fI7qK09i0uiqG94n26RWIR7CEB+ZzNicm6czTM1zyZ0aes5C yhq8wOeYar2TMC4URVvBlEsXgk84eACP/zqTZezWL+sJw1Du3357eApxgh8khT9Dp+CB GQ9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wh2SyVyC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l9si12869161pgj.543.2019.02.18.06.03.01; Mon, 18 Feb 2019 06:03:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wh2SyVyC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389354AbfBROCJ (ORCPT + 99 others); Mon, 18 Feb 2019 09:02:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:43646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389317AbfBROCF (ORCPT ); Mon, 18 Feb 2019 09:02:05 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B7ABA2173C; Mon, 18 Feb 2019 14:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550498525; bh=mtUItnYdoMPJ2isFZzVGav2YxRSY8rNC0jwnyXUG/54=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wh2SyVyCZSUBazr07OVYYAuIH7S83Fz/BJgpgwMY2zOB6LL66T9f8iBpKWiKtK73j y6j1QjJrT/QP13JASEfhFBo+LZvGbASIOC9AobjJ9+AOFQaiqkPCn5MISE1BKzZaJ7 tFbHDvz2fZRms6oEBh25Hk7u740Bc68a30RqQhRc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Young Xiao , Jens Axboe , Sasha Levin Subject: [PATCH 4.4 019/143] sunvdc: Do not spin in an infinite loop when vio_ldc_send() returns EAGAIN Date: Mon, 18 Feb 2019 14:42:27 +0100 Message-Id: <20190218133529.860260792@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190218133529.099444112@linuxfoundation.org> References: <20190218133529.099444112@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit a11f6ca9aef989b56cd31ff4ee2af4fb31a172ec ] __vdc_tx_trigger should only loop on EAGAIN a finite number of times. See commit adddc32d6fde ("sunvnet: Do not spin in an infinite loop when vio_ldc_send() returns EAGAIN") for detail. Signed-off-by: Young Xiao Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/sunvdc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c index 4b911ed96ea3..31219fb9e7f4 100644 --- a/drivers/block/sunvdc.c +++ b/drivers/block/sunvdc.c @@ -40,6 +40,8 @@ MODULE_VERSION(DRV_MODULE_VERSION); #define WAITING_FOR_GEN_CMD 0x04 #define WAITING_FOR_ANY -1 +#define VDC_MAX_RETRIES 10 + static struct workqueue_struct *sunvdc_wq; struct vdc_req_entry { @@ -419,6 +421,7 @@ static int __vdc_tx_trigger(struct vdc_port *port) .end_idx = dr->prod, }; int err, delay; + int retries = 0; hdr.seq = dr->snd_nxt; delay = 1; @@ -431,6 +434,8 @@ static int __vdc_tx_trigger(struct vdc_port *port) udelay(delay); if ((delay <<= 1) > 128) delay = 128; + if (retries++ > VDC_MAX_RETRIES) + break; } while (err == -EAGAIN); if (err == -ENOTCONN) -- 2.19.1