Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2435921imj; Mon, 18 Feb 2019 06:03:50 -0800 (PST) X-Google-Smtp-Source: AHgI3IZRkZrMGlefMxwu6aA1ss6eofQzTN+Le2IQV5te/nPla0pf1NKfBSgXPEijUNPj7XdsilxF X-Received: by 2002:a17:902:5ac9:: with SMTP id g9mr25867780plm.205.1550498630808; Mon, 18 Feb 2019 06:03:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550498630; cv=none; d=google.com; s=arc-20160816; b=wSWPX6UJOSodLfIsPljvRkO/O5HCU7ZcYagFXcgCUO0byyvh6ZSNd+/acHZtUqr4YT COoAB6c93e7TALbR4ZGlMeUBnPFAJGdER+/sOTCQKV3EsyEeUM7XWztozkH8Olfl03+X yZfq5BoWe7aHJ4Anjj1XPl/QtmYmyLfLXvOpBPUngzwLUQQ9KsowTF/D7T004bLdbVSA SG7O5lRKYN7zdvY5u3YEszWd70EOLJR4r+bsZObQVloHCBfnctOAinke4OTb+tfYFgHA vjFnLeDhYnX66LXUkMpBBm9vScQrrp7U7hKNIaKy7gFZghfFPF3u3imQh69NDj4Cxzce iVmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vikwgVd/ZgYpz0LQW/gw3spv4ZLQwcr+wz7z/iezdsE=; b=M1QDJBzdl165BNph4QkXru+J+ggrzO/ar3qG4Zdb6NI5x/tQqrbMaGO0owruqVNH0l uZ5MNCacB8Zf0bi1Plrw+5b1CiiUskQrn/kGRtJd4/aAmBgWyTLLdew7XghqxzyM343I 570eJQwplZtcCb86eK1WV8yhE2n6C+SVzrwSRDYVldPyESu5NbX2+hgke63o18NXnWce TyWVcnkpTbMf26wgWBMHRzllVeTQapbkw7Sg6U0tofIW65A+rNjKrc8AXnoEksfvrVz4 dNmMLEGi+MRFlqtSSXbr6Ak8+p5uHKU0QC6og3Dc3Nfngtyu5MetgnrxV6HtASwH66n1 9E3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xf+NW1AW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si12685354ple.5.2019.02.18.06.03.34; Mon, 18 Feb 2019 06:03:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xf+NW1AW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389093AbfBROB2 (ORCPT + 99 others); Mon, 18 Feb 2019 09:01:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:42884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387590AbfBROBZ (ORCPT ); Mon, 18 Feb 2019 09:01:25 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 33543217D9; Mon, 18 Feb 2019 14:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550498484; bh=2cUT/pbCTMJGh5X1xrtfbHpml+Qqdq6SNoc2barg0Ow=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xf+NW1AWytDO3xSAo5V6q8tLpmx1p4hUemqlqk56sfH8ZS/0tBHJBywBT+te9YSXv n+naMZVM6TQd6jheZ9jbKrCXWhdY20MFNmAzQSSv4qzb+wR06CCHRvRolL5xn+8FF0 Fe0KTt3JS6WLz8AdUPHTbQCsMRDqTIWuwasPPpY0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lukas Wunner , Andy Duan , Fabio Estevam , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Sasha Levin Subject: [PATCH 4.4 009/143] serial: fsl_lpuart: clear parity enable bit when disable parity Date: Mon, 18 Feb 2019 14:42:17 +0100 Message-Id: <20190218133529.499699066@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190218133529.099444112@linuxfoundation.org> References: <20190218133529.099444112@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 397bd9211fe014b347ca8f95a8f4e1017bac1aeb ] Current driver only enable parity enable bit and never clear it when user set the termios. The fix clear the parity enable bit when PARENB flag is not set in termios->c_cflag. Cc: Lukas Wunner Signed-off-by: Andy Duan Reviewed-by: Fabio Estevam Acked-by: Uwe Kleine-König Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/fsl_lpuart.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index 01e2274b23f2..8b5ec9386f0f 100644 --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1267,6 +1267,8 @@ lpuart_set_termios(struct uart_port *port, struct ktermios *termios, else cr1 &= ~UARTCR1_PT; } + } else { + cr1 &= ~UARTCR1_PE; } /* ask the core to calculate the divisor */ @@ -1402,6 +1404,8 @@ lpuart32_set_termios(struct uart_port *port, struct ktermios *termios, else ctrl &= ~UARTCTRL_PT; } + } else { + ctrl &= ~UARTCTRL_PE; } /* ask the core to calculate the divisor */ -- 2.19.1