Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2455020imj; Mon, 18 Feb 2019 06:20:43 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ7hRvpyb9IgB+ANuAFwHR7nmz4EV5Yu/3v8+TwC0ftObyueOTcoojXC8a9m4dm+/oRcLW5 X-Received: by 2002:a17:902:bc89:: with SMTP id bb9mr25699582plb.212.1550499643053; Mon, 18 Feb 2019 06:20:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550499643; cv=none; d=google.com; s=arc-20160816; b=VngQDHwEsaEJ2vx+5WLsF9YQeDkbgBeboqlE50FNkdtuKmA4CIk/Kljs98JxOU2a2k b8dUF2XhV4twfiUWa1kU0Pd7iX4czZt/YT9fa9GfB4L2EvrEJoFgY0dU3DxChk56Y6Ca WtcSbZT8TiLp1vH7uKth/kKVKOUT+lx4/3EE7QuRo3yP3k214/KlJ4WtURBjKRdAshNF ZVFToNf6zyOqVtm2FL+6PRmCF0RogQ7AwYv24pqWOdVT0CqGyws4yURTFX1TU56aWH/O PS0aF5n5CAso3CKHDicf+gCUjqx/9WPne6No1MoNPug0r/Zi+wjidcOiyV3uHWlGijUG UHWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=yB9n1opB3S3ygm4JCYimoHmvGjjBUdNy6nLYT9ppeRQ=; b=h3mNdZVQYEcidOylwyvJACZ3h/JsLNti/ovU9gM/Ore4HC/NAQ5rV/SS85BSUNEoxc 8dWcdzzvwjmEEF5A2nDIzTHB7TQ8GgoBXPl0lwyHHCf2OD2Mwg9eNbJqCksIbrF/dE6F Ln1g6oZYtg9MWdin9ns/qIjJSlS0aSTi9G13lVZW1UJXeb35gA8BbZPV7G0OBdpXHd2W IPehPsA0ZNmuThPYwG/nmzgzfKgCKXUkO5mNnPZB+wZM2yX45By5iqsZETPHIHPwQDU7 uxJVnM8vTBzGJZvZthxx/+I5Tfb8rejSULlZUaTLfFpFVEkASM1c4R6JnbeiQzGu1smK NymA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x15si13427834pgq.378.2019.02.18.06.20.27; Mon, 18 Feb 2019 06:20:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389737AbfBROTf (ORCPT + 99 others); Mon, 18 Feb 2019 09:19:35 -0500 Received: from foss.arm.com ([217.140.101.70]:59640 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389442AbfBROTe (ORCPT ); Mon, 18 Feb 2019 09:19:34 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B64AF15AB; Mon, 18 Feb 2019 06:19:33 -0800 (PST) Received: from [10.1.196.69] (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 770F73F589; Mon, 18 Feb 2019 06:19:15 -0800 (PST) Subject: Re: [PATCH 03/13] mm: Add generic p?d_large() macros To: Peter Zijlstra Cc: x86@kernel.org, Arnd Bergmann , Ard Biesheuvel , Catalin Marinas , kirill@shutemov.name, Dave Hansen , Will Deacon , linux-kernel@vger.kernel.org, linux-mm@kvack.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , James Morse , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, kan.liang@linux.intel.com References: <20190215170235.23360-1-steven.price@arm.com> <20190215170235.23360-4-steven.price@arm.com> <20190218113134.GU32477@hirez.programming.kicks-ass.net> From: Steven Price Message-ID: Date: Mon, 18 Feb 2019 14:19:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190218113134.GU32477@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/02/2019 11:31, Peter Zijlstra wrote: > On Fri, Feb 15, 2019 at 05:02:24PM +0000, Steven Price wrote: >> From: James Morse >> >> Exposing the pud/pgd levels of the page tables to walk_page_range() means >> we may come across the exotic large mappings that come with large areas >> of contiguous memory (such as the kernel's linear map). >> >> For architectures that don't provide p?d_large() macros, provided a >> does nothing default. > > Kan was going to fix that for all archs I think.. The latest series I can find from Kan is still x86 specific. I'm happy to rebase onto something else if Kan has an implementation already (please point me in the right direction). Otherwise Kan is obviously free to base on these changes. Steve > See: > > http://lkml.kernel.org/r/20190204105409.GA17550@hirez.programming.kicks-ass.net > >> Signed-off-by: James Morse >> Signed-off-by: Steven Price >> --- >> include/asm-generic/pgtable.h | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h >> index 05e61e6c843f..7630d663cd51 100644 >> --- a/include/asm-generic/pgtable.h >> +++ b/include/asm-generic/pgtable.h >> @@ -1186,4 +1186,14 @@ static inline bool arch_has_pfn_modify_check(void) >> #define mm_pmd_folded(mm) __is_defined(__PAGETABLE_PMD_FOLDED) >> #endif >> >> +#ifndef pgd_large >> +#define pgd_large(x) 0 >> +#endif >> +#ifndef pud_large >> +#define pud_large(x) 0 >> +#endif >> +#ifndef pmd_large >> +#define pmd_large(x) 0 >> +#endif >> + >> #endif /* _ASM_GENERIC_PGTABLE_H */ >> -- >> 2.20.1 >> > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >