Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2455412imj; Mon, 18 Feb 2019 06:21:07 -0800 (PST) X-Google-Smtp-Source: AHgI3IbsC4I9hRnWYiPNTTah0DBT3E7R2dtl6+Rx4PfVAe2Euyw3u3V9wS3paAPo5Saoj88VFjPq X-Received: by 2002:a17:902:2a47:: with SMTP id i65mr25817194plb.237.1550499667187; Mon, 18 Feb 2019 06:21:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550499667; cv=none; d=google.com; s=arc-20160816; b=x4XB2Fj714RovR2D4l3DL8bOB8sgOawxbhf2RISgnsIfjmYyJgsKdkpDttbP3th4JS FceSPJ6AA6Q/31AibU6SCh+lPcbfU3LzJ7yNZt5BaFGvu2oxvI0H4ot62x7mmtkdZ1uP TzNbNT4dNWa4Wvo4xMxYMqGgLYPtvhGnk6GQBBG7g5azjm+5xp7fhDpPNK42EPSaiOlF JQV6WRkydX48e3alJLU6kWhj5vGM1trtmMFkBrkLFpGRwO9Kp9VO4YMLkGi4jPU5B1rr yeXlSbqeBe/UxoQLKxbgUdH41AJ/vPs715IWzdUJVs8LH8gdoyVPcqU2w/CLyYMzK5B4 MUVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Qy5zEnl89+gTOfb1k599eeWS6m+UhYsMNAj+w9l30y0=; b=BXfBaodPHAv46OA2Q5H6tVveQN1RNJ0OHvplYA6OHhf4RnzVJe2ZY3XPJgOZjttUom Qoro2dqx+9RpcUz7ni6aPBMCihvOLOquJvHAQPbM5E4yagqfSXvVpbg0yqAp3ZKF7kHc TY678VfwAnFAIx5tZxRamSzN6RzVbvZbY0+PCp9gpp4K6o3tdfeCj8eKdt5yJp1uDGwB O3Dr5cWYS5StglA2anjdfth/e/EBdH98OCVrb6RpLaXgdb/ziEjZ5xBWRtxhadDArafc 1O3Kh8HwNimYOX2L3SqQkLaNtNe3lA7Wo1mmFc1yG/riY8pMBSxQ6tGFK/6jaOOgN1J5 Ms2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j16si1124145pgk.441.2019.02.18.06.20.51; Mon, 18 Feb 2019 06:21:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387913AbfBROS6 (ORCPT + 99 others); Mon, 18 Feb 2019 09:18:58 -0500 Received: from mx-rz-3.rrze.uni-erlangen.de ([131.188.11.22]:60174 "EHLO mx-rz-3.rrze.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729530AbfBROS5 (ORCPT ); Mon, 18 Feb 2019 09:18:57 -0500 Received: from mx-rz-smart.rrze.uni-erlangen.de (mx-rz-smart.rrze.uni-erlangen.de [IPv6:2001:638:a000:1025::1e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx-rz-3.rrze.uni-erlangen.de (Postfix) with ESMTPS id 4435Zl3Tm1z20YZ; Mon, 18 Feb 2019 15:18:55 +0100 (CET) Authentication-Results: mx-rz-3.rrze.uni-erlangen.de; dkim=none reason="no signature"; dkim-adsp=none (unprotected policy); dkim-atps=neutral X-Virus-Scanned: amavisd-new at boeck4.rrze.uni-erlangen.de (RRZE) X-RRZE-Flag: Not-Spam X-RRZE-Submit-IP: 10.21.16.14 Received: from fau.de (faustud-010-021-016-014.pool.uni-erlangen.de [10.21.16.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: U2FsdGVkX18PaRWTgCmy6H93imKo++b70HiFiXKgrYg=) by smtp-auth.uni-erlangen.de (Postfix) with ESMTPSA id 4435Zj2hZLz20Yq; Mon, 18 Feb 2019 15:18:53 +0100 (CET) From: Jonas Rabenstein To: linux-perf-users@vger.kernel.org Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , Thomas Richter , Stephane Eranian , Jonas Rabenstein , linux-kernel@vger.kernel.org Subject: [PATCH] perf: fix documentation of the Flags section in perf.data Date: Mon, 18 Feb 2019 15:18:46 +0100 Message-Id: <20190218141846.2995-1-jonas.rabenstein@studium.uni-erlangen.de> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190217232246.GB26460@krava> References: <20190217232246.GB26460@krava> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to the current documentation the flags section is placed after the file header itself but the code assumes to find the flags section after the data section. This change updates the documentation to that assumption. --- tools/perf/Documentation/perf.data-file-format.txt | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt index 5f9a3924830b..593ef49b273c 100644 --- a/tools/perf/Documentation/perf.data-file-format.txt +++ b/tools/perf/Documentation/perf.data-file-format.txt @@ -43,11 +43,10 @@ struct perf_file_section { Flags section: -The header is followed by different optional headers, described by the bits set -in flags. Only headers for which the bit is set are included. Each header -consists of a perf_file_section located after the initial header. -The respective perf_file_section points to the data of the additional -header and defines its size. +For each of the optional features a perf_file_section it placed after the data +section if the feature bit is set in the perf_header flags bitset. The +respective perf_file_section points to the data of the additional header and +defines its size. Some headers consist of strings, which are defined like this: -- 2.19.2