Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2455828imj; Mon, 18 Feb 2019 06:21:30 -0800 (PST) X-Google-Smtp-Source: AHgI3IYNndZWqmhZYWd+AhhWEPS2QG0RBy1DWbXFchepRoLfXpqCFm5nc9DTfy1eb1VwWvrkx1Em X-Received: by 2002:a62:ca13:: with SMTP id n19mr15539326pfg.221.1550499690029; Mon, 18 Feb 2019 06:21:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550499690; cv=none; d=google.com; s=arc-20160816; b=SdpLsSpWR3tIeMbihIREmQQ5BqO+igPQyY2cRDhaczXXBXAbJjaJcwJWbfASLLNZ2U OBQtmNEDmE3IoXhFe2ib8l2qRjwhqzVPu7kjyp40xgBgQYMcJ7IxeKZAq1PQkiuEpaiT zDZsJT2KOzsSKY4ocsqtBH1xpgxUUN5UfZqT/m5ic73d6LwQc7m/ur304eqcVA0WK6FO brZwEi15ZzOAOvY41BbHRbmqEw3Cm4yfh16SY2kfqjCf8JR/hsE9DJCK0MRQHbT6HOq/ Y8y4L7Im860FGgUxWQ8y4RHF0MSsb/Be3Q/s3IRL1k5FejKOmStpBs7k9xru2GKzEulS ojkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=fYJnVxYaI8tzKr4MQExI2Hhm8BPHPiRQ3gkR7VBAd5I=; b=QdS8mdGmHDcXnyz5febgBkbp03NIv0hJgilecxEXnkJENwQO3FFJROKhjBp3GYl9+y 3OLlR/m7gzlNQw7qKjjh+YGGxmRMl4hZ2R1yn5hkxpSJiNR+00Tyvdj+C/Vl07pypEui YU5MDkfYwEE4dSfOCGtq3iG40rnU2ZCuZCLMA6LxYW5cp6+ZyMAjuj/tM5OVh0jq6eMN Zf0/JdlEcEeOVfzPv6CPCrTjL3v0ojRCe1mzgo/jIY+CObViMOQd7jIaCD2wldASk6IZ ImuQHN+41CcbbwAIhV+ePsl6rgieHhnxXAi3wldH4zU1mq1IgDt5OnFQKPSdMaFtI4wz NjtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1si2831597pgv.545.2019.02.18.06.21.14; Mon, 18 Feb 2019 06:21:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391122AbfBROUf (ORCPT + 99 others); Mon, 18 Feb 2019 09:20:35 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:59690 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390699AbfBROUc (ORCPT ); Mon, 18 Feb 2019 09:20:32 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B8AE015AD; Mon, 18 Feb 2019 06:20:28 -0800 (PST) Received: from [10.1.196.69] (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E1C283F589; Mon, 18 Feb 2019 06:20:10 -0800 (PST) Subject: Re: [PATCH 03/13] mm: Add generic p?d_large() macros To: Peter Zijlstra , Mark Rutland Cc: Dave Hansen , Arnd Bergmann , Ard Biesheuvel , Catalin Marinas , "x86@kernel.org" , Will Deacon , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , James Morse , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" References: <20190215170235.23360-1-steven.price@arm.com> <20190215170235.23360-4-steven.price@arm.com> <20190218111421.GC8036@lakrids.cambridge.arm.com> <20190218125327.GT32494@hirez.programming.kicks-ass.net> From: Steven Price Message-ID: Date: Mon, 18 Feb 2019 14:20:09 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190218125327.GT32494@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/02/2019 12:53, Peter Zijlstra wrote: > On Mon, Feb 18, 2019 at 11:14:23AM +0000, Mark Rutland wrote: >>> +#ifndef pgd_large >>> +#define pgd_large(x)0 >>> +#endif >>> +#ifndef pud_large >>> +#define pud_large(x)0 >>> +#endif >>> +#ifndef pmd_large >>> +#define pmd_large(x)0 >>> +#endif >> >> It might be worth a comment defining the semantics of these, e.g. how >> they differ from p?d_huge() and p?d_trans_huge(). > > Yes; I took it to mean any large page mapping, so it would explicitly > include huge and thp. Yes your interpretation is correct. I'll add a comment explaining the semantics. Thanks, Steve