Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2464961imj; Mon, 18 Feb 2019 06:30:19 -0800 (PST) X-Google-Smtp-Source: AHgI3IY6p1fXhZWd/C6S1QWtQCLPYFder+tNJwFrCpOSNLHYN1VhVbpitgl9GankgbgD0Jp4CvkK X-Received: by 2002:a17:902:368:: with SMTP id 95mr25585092pld.139.1550500219482; Mon, 18 Feb 2019 06:30:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550500219; cv=none; d=google.com; s=arc-20160816; b=lmQsuMvIC/T719TULLCjJElaCztHBoOGy/esqtCkDGQrJFE4G1q1BdLO/x9ugwP4/g ooQ84riQJ5gE1iWtxNP7x3WqEvIH6l68X5f1ahMbEKKfNqCs5UM5RsR8E63SvZMaWiRF /Uwral0Noj7TF4MVeG4aRJjdI03orZkzVP43JHCZza3/+DLRLWyuhQRUrR4OEkNHxXVv nqXSL6lfKtFuufMqhZX0/xdqT3WfmNIrINyzYaZgH3U0sQt+9rdKpMkKtj/V7heLPIHc rgL43/+s2S4QTZ96uQp+6BlproV7JmUxmkGr2W6ij+zVmaddMeZ2vDZjHfTNKqc1KLqD 2aWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Wi1aEDyz/7hJ6sdM7HCV0D5kH69OYRAO/v9c3VcESj4=; b=XC+pfTQyBKBoM9dGuUq1gu3Ke4QOtoCi/OObx6xO0ZsxLhN3CtngvireW0oUTDwAZi IqrIz4MbVGUComK4OqTNcea0XJArZ7GwpY84zdYYCb7McyuKzLYQWO0f7jTDQxsWY3Fh QWATr71Z+EnCW73J6P0lMRori7NTay3IVaOEYOl0VuRTHCcRDyAU7LjcoAY9a1iQG2BD jteZHJAEMGss7SQi2CJW9BcLrIMU+nIciAD51gpk4XDnGDsVVSMUvP7o4jPMhWyly/L6 +6RMGp6uDxh/xSMTJZUnWwSLtBch9MztghW/fQ4JPCDxsdKtgdWN1+zBhDaNufgrBzKP VKiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jzizNkE1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i20si12907147pgm.236.2019.02.18.06.30.03; Mon, 18 Feb 2019 06:30:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jzizNkE1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388621AbfBRN7i (ORCPT + 99 others); Mon, 18 Feb 2019 08:59:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:40604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731082AbfBRN7g (ORCPT ); Mon, 18 Feb 2019 08:59:36 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE1672070D; Mon, 18 Feb 2019 13:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550498376; bh=RRILu61irN4bFL2WiU+tmrp12Sb8Z1ma6krtLXf/SwU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jzizNkE1C82F/T5EKNmCe60nOVpIcabJJI9KpYIGLx6h3nJsDCeiMmJ4cu0APOwOk iIa4O7fnRoZvI0oCWKK9AzqqNPeX196QyoxDsVTJcC0c0q0beTfaCOX4usPWDMeI0V fPfctfMhzcCEfZ+IAMXgdgmWfavyIRQY31X3cUhc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomi Valkeinen , Andrzej Hajda , Sasha Levin Subject: [PATCH 4.9 27/58] drm/bridge: tc358767: reject modes which require too much BW Date: Mon, 18 Feb 2019 14:43:48 +0100 Message-Id: <20190218133510.679505608@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190218133508.567416115@linuxfoundation.org> References: <20190218133508.567416115@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 51b9e62eb6950c762162ab7eb8390990179be067 ] The current driver accepts any videomode with pclk < 154MHz. This is not correct, as with 1 lane and/or 1.62Mbps speed not all videomodes can be supported. Add code to reject modes that require more bandwidth that is available. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda Signed-off-by: Andrzej Hajda Link: https://patchwork.freedesktop.org/patch/msgid/20190103115954.12785-6-tomi.valkeinen@ti.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/bridge/tc358767.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index dbe403ea130d..16fa42984c50 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -1118,10 +1118,20 @@ static bool tc_bridge_mode_fixup(struct drm_bridge *bridge, static int tc_connector_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { + struct tc_data *tc = connector_to_tc(connector); + u32 req, avail; + u32 bits_per_pixel = 24; + /* DPI interface clock limitation: upto 154 MHz */ if (mode->clock > 154000) return MODE_CLOCK_HIGH; + req = mode->clock * bits_per_pixel / 8; + avail = tc->link.base.num_lanes * tc->link.base.rate; + + if (req > avail) + return MODE_BAD; + return MODE_OK; } -- 2.19.1