Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2474714imj; Mon, 18 Feb 2019 06:39:29 -0800 (PST) X-Google-Smtp-Source: AHgI3IbxeCJulSxOyDyeEZJbw1NXhANFBmUNk2X3xkZF8PNA2EtbazVEVG13z13chn9m/QS1IKHA X-Received: by 2002:a17:902:b784:: with SMTP id e4mr14051510pls.308.1550500769006; Mon, 18 Feb 2019 06:39:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550500768; cv=none; d=google.com; s=arc-20160816; b=cT/WybMbJRczv0ZH1ke8CL62nE7mf3DX2mUXAVzdMLI3F/KgLPcVVyJioDBw4QUraP C4B0EghyDje4trQgfsv7FDtZcD9uRz6GtxMEj/MaumMbqSb5GN+tMfSwqv7AbjiLrwo/ p/BIqPycmnPRyEqiTAUOl9LSNgM+zkJxIxitM/FCOapaceJy1VhiD9spEK7WF+Pe/kMQ GNqz9ZxdxOQL+Sq9+l8I0KVpNfv75zZWE6PRCMgmNubjh+9Bod5l2zZy9UbkQgo/NDJR tLJuj1hwzHXyGRfLt5hGS6FE8FzSKMXqepurHZaTD6gWxM/DWRcshWHpjN8VT9/AAqrf uaVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WYzlE0ZSmYa/Z5N7k2NwgwQULXurQdmTNQhgeH8Ga8k=; b=x2U/xqKSDmiM/L3KBsIixG7zdvYFCH2KW6BXays33V1x3euRB8hNElQO2gzALLTMCe 2w1n+salBlcGpDCxEnfRDz1ndYi4PEtfyZikTgm1KtIIqTHP7L/FBZkX6tHJVN4k2GJH aUp1oOLJJUzbPpZRmB/meNZaRFr1PfBsmJp0MBURStLz+bJYhEAdanIikC7TPlPZQm3V SWzIqaOfsOW1Vqpt13Nd3x83tqUKvuLgrC4uADbDeaPSMLwKNScJCkpmn/IIi3/S4Toj 3nIUyEb1/gfwaJjlvsw4rKbzNUpu/RA9t2XhwEkNV6bRxMJgPl1RzjOvY89Gbb6ujIe2 G/9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OuD8+0QS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 128si8348317pgb.373.2019.02.18.06.39.12; Mon, 18 Feb 2019 06:39:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OuD8+0QS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389573AbfBROg4 (ORCPT + 99 others); Mon, 18 Feb 2019 09:36:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:35682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731979AbfBRNzg (ORCPT ); Mon, 18 Feb 2019 08:55:36 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5381920842; Mon, 18 Feb 2019 13:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550498135; bh=EuMrBqlc1gM1YyNylSGlW0wc7sPTZcM4FYqwGL4x4+g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OuD8+0QSkiLNyewKvNf3zEJDmbq8QQBca//Qxr09fp1WyC5wRDrK/cKFyOw0oWYFt GtINkvYtY+wIbXnkJxxIynUC+WbI+lKGwNP8oSw/nE1eU328+An2dNdAmBc4tjkUkZ v1cUPhV5t8VqkSFTJ1IrtW9CFDYrgWv4wVsZh1q0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jamie Lentin , Guenter Roeck , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Julien DAscenzio , Linus Walleij , Sasha Levin Subject: [PATCH 4.14 35/62] ARM: dts: kirkwood: Fix polarity of GPIO fan lines Date: Mon, 18 Feb 2019 14:43:41 +0100 Message-Id: <20190218133508.953063650@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190218133505.801423074@linuxfoundation.org> References: <20190218133505.801423074@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit b5f034845e70916fd33e172fad5ad530a29c10ab ] These two lines are active high, not active low. The bug was found when we changed the kernel to respect the polarity defined in the device tree. Fixes: 1b90e06b1429 ("ARM: kirkwood: Use devicetree to define DNS-32[05] fan") Cc: Jamie Lentin Cc: Guenter Roeck Cc: Jason Cooper Cc: Andrew Lunn Cc: Gregory Clement Cc: Sebastian Hesselbarth Cc: Julien D'Ascenzio Reviewed-by: Andrew Lunn Tested-by: Jamie Lentin Reported-by: Julien D'Ascenzio Tested-by: Julien D'Ascenzio Signed-off-by: Linus Walleij Signed-off-by: Gregory CLEMENT Signed-off-by: Sasha Levin --- arch/arm/boot/dts/kirkwood-dnskw.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/kirkwood-dnskw.dtsi b/arch/arm/boot/dts/kirkwood-dnskw.dtsi index cbaf06f2f78e..eb917462b219 100644 --- a/arch/arm/boot/dts/kirkwood-dnskw.dtsi +++ b/arch/arm/boot/dts/kirkwood-dnskw.dtsi @@ -36,8 +36,8 @@ compatible = "gpio-fan"; pinctrl-0 = <&pmx_fan_high_speed &pmx_fan_low_speed>; pinctrl-names = "default"; - gpios = <&gpio1 14 GPIO_ACTIVE_LOW - &gpio1 13 GPIO_ACTIVE_LOW>; + gpios = <&gpio1 14 GPIO_ACTIVE_HIGH + &gpio1 13 GPIO_ACTIVE_HIGH>; gpio-fan,speed-map = <0 0 3000 1 6000 2>; -- 2.19.1