Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2714156imj; Mon, 18 Feb 2019 10:46:33 -0800 (PST) X-Google-Smtp-Source: AHgI3Ibad2pt7ZDMncwUSnwtK01zFBpRJ+NwEJCZCLyBfwmNrVait/MGMJtq5r2Y8Pw3zGvNtO1I X-Received: by 2002:a65:65c9:: with SMTP id y9mr20633883pgv.438.1550515593134; Mon, 18 Feb 2019 10:46:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550515593; cv=none; d=google.com; s=arc-20160816; b=CA24L1udNfzQ6nCCeUTHHn/EJLgQ3hxnJHR7JNPiqPFf2WntbLmB6g2M1qdb+ImZ9F lOtISQvR8Qys/46povpkEKEwvEwcgPmbfLbRAeyLt+O+7pwbVHV8fnMGyKFT4NSmDc36 EfYSa7TLBIC/RXoHFehkANzXq4g2VFk3q2KBE/rnJpECQFVKT/a9W4TSfsOjNhoO73NS rLYleWGPcQrAM8GMddNIMAKwmUaPeauhMgLMLpMJfdjBw5N9GOaCyTzbpN9KG8NX6Beo eHiVhVEEdWL0dBjrLYRfMVSOwbqVLAajYr+RJD3VcH00cAa8uxufwU8P557Xx3DPSN9u cY7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=t7ul6qFjAV6/5cm3WrDVGikFzQ/5NU91CimGKn19A2E=; b=bgON0j5P7fq07GvtBD+VPgRgOE5OuidlQ4zfFqQKyEbUlYON8fzs3IW0XyjDFTxBYe T2yd+n/WQHnSQPBAeNFpVr74VGcZF4tyuuSa8cbVuMrwcJArABcH46BHZeP8L0kgnzR+ fuwBiJlfIYR5o/es01eP/kUIXLPsQvGVkL+oG86t1/kKQDkLUXIBdubC6QQwnqpZ/LTQ MfMc5Sf1L3nI9tJfc1xxuY3uYV8ZATiToyw1L7SzxrJVnCusA361jr0qoVhiIJRy+417 rFIOm0pxmmnEwZKZ1mT/5t4qUTQF6ZPhY1qn4FMlXraAjmJhA4p6wva6CHT4UL81fgSN 4EIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f4si14822541plf.370.2019.02.18.10.46.17; Mon, 18 Feb 2019 10:46:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732441AbfBRPay (ORCPT + 99 others); Mon, 18 Feb 2019 10:30:54 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:33304 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731943AbfBRPax (ORCPT ); Mon, 18 Feb 2019 10:30:53 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C95D2A78; Mon, 18 Feb 2019 07:30:52 -0800 (PST) Received: from [10.1.196.69] (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F256A3F675; Mon, 18 Feb 2019 07:30:39 -0800 (PST) Subject: Re: [PATCH 01/13] arm64: mm: Add p?d_large() definitions To: Peter Zijlstra , Mark Rutland Cc: Dave Hansen , Arnd Bergmann , Ard Biesheuvel , Catalin Marinas , x86@kernel.org, Will Deacon , linux-kernel@vger.kernel.org, linux-mm@kvack.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , James Morse , Thomas Gleixner , linux-arm-kernel@lists.infradead.org References: <20190215170235.23360-1-steven.price@arm.com> <20190215170235.23360-2-steven.price@arm.com> <20190218112922.GT32477@hirez.programming.kicks-ass.net> <20190218142951.GA10145@lakrids.cambridge.arm.com> <20190218150657.GU32494@hirez.programming.kicks-ass.net> From: Steven Price Message-ID: Date: Mon, 18 Feb 2019 15:30:38 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190218150657.GU32494@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/02/2019 15:06, Peter Zijlstra wrote: > On Mon, Feb 18, 2019 at 02:29:52PM +0000, Mark Rutland wrote: >> I think that Peter means p?d_huge(x) should imply p?d_large(x), e.g. >> >> #define pmd_large(x) \ >> (pmd_sect(x) || pmd_huge(x) || pmd_trans_huge(x)) >> >> ... which should work regardless of CONFIG_HUGETLB_PAGE. > > Yep, that. I'm not aware of a situation where pmd_huge(x) is true but pmd_sect(x) isn't. Equally for pmd_huge(x) and pmd_trans_huge(x). What am I missing? Steve