Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <89716a4433cd83aea5f4200359b184b0ee2cc8bd.1549828313.git.bobbyeshleman@gmail.com>
 <CAGngYiXPsj-TAZxC43UtAZYTkbztFtDB-z4jW29CthmaoeNy_w@mail.gmail.com>
 <20190213021753.GA19621@bobby.localdomain> <CAGngYiUvEpSgESzFGJOtYjLi+_xmZ18GwiSTxaaMjEmjk2pu4Q@mail.gmail.com>
 <20190218152224.00007920@huawei.com>
In-Reply-To: <20190218152224.00007920@huawei.com>
From:   Sven Van Asbroeck <thesven73@gmail.com>
Date:   Mon, 18 Feb 2019 12:13:59 -0500
Message-ID: <CAGngYiXz=o6m41wsETbt7i9c6Ut=GsW2Kvf8cwhqSQnO6Jg4zA@mail.gmail.com>
Subject: Re: [PATCH 1/3] iio: light: Add driver for ap3216c
To:     Jonathan Cameron <jonathan.cameron@huawei.com>
Cc:     Robert Eshleman <bobbyeshleman@gmail.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-iio@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Jonathan,

First of all, thank you so much for taking the time for such a detailed
reply !

On Mon, Feb 18, 2019 at 10:22 AM Jonathan Cameron
<jonathan.cameron@huawei.com> wrote:
>
>
> So, what I'm reading above is worrying.   The interrupt is cleared
> by the read of the data registers?  I thought the datasheet allowed
> for an explicit clear?
>

I don't think there's any need to worry. The part allows us to choose between
clear-on-read, and explicit clear. Bobby's approach is fundamentally sound.

IMHO most of my suggestions were based on an incomplete understanding of
a) the interrupt in the device, and b) the event guarantees in iio.

I will respond to your larger reply properly soon.