Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp2752828imj; Mon, 18 Feb 2019 11:32:03 -0800 (PST) X-Google-Smtp-Source: AHgI3IbJe+QA2YQBPyY2nBVqU8hg1dLhZ/IQScIrDew/5PrUCjGgOGnojKn7YoH+xgR8Sf12XelT X-Received: by 2002:a62:4b4d:: with SMTP id y74mr25449138pfa.186.1550518323196; Mon, 18 Feb 2019 11:32:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550518323; cv=none; d=google.com; s=arc-20160816; b=UGTErP1e7tK5oDNpmkTillRZQup2zRfFNRVFvJ9UiZBX5miJZEp4C0NJBRq1aJ4oYF XETHvlxO/PXT2KnfzuhLDC2GjeQBnUv3kfhSMJqGtHdawCY1lELRZsVx1KKik5FF6vlG GA/BgxSnVi2d/YzOl4eE+i2/9UcohsezCepjc/jQqCZ4h/tRbdhqeE9ctpjNdG8p0XH8 03klmqAmYnlNJpSMfsXcdN36ulZ9io6UVm9y+FFr/PjmRRj2UwHotpoDL/ucsLbx6xE3 +H6ehwQ6+dNTl4bPkhr9b0cY+6CqhmX64fsPlPZR1ZPg2prrMKhVfEHZdNXWgmJI0Piq TsFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Lz107P4BMhmp2Ybd/5l12BPSYujlnGszI7ylzRy5yys=; b=wTVDSh34v6FxFQzz2PXGlaYkhtEHy7YRmCSAMMdzyaty6c2eblQdoepTkc5EBCHFra Fxx8kI1h1NHwlGo9Vm2N4cF3j1QuR+DrGdDq7zQu/wAbe2RSmp0UWT03muAb+0sdVT+Q dj2h98TGYfjYphgmYXos7E5fkHwDMKu70b1uVDSHZBzK8fYiDve46Ys17+izKHnqMO+y LMG6S1bEKBILtKTzDf00g2ecPvSw+BBDyu0H2DT04ZIKx3QlNIXX/FTaXTFBMiOWviH3 P+nho5EFuWrlZeszRpUN5sv2fBF+dH1wcKCq0s30FkS9UlhhNJ2LDHPiiuqcQ9dSOLpv z72g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=GVMoq9vT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y10si13743688pgl.152.2019.02.18.11.31.47; Mon, 18 Feb 2019 11:32:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=GVMoq9vT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728081AbfBRS6m (ORCPT + 99 others); Mon, 18 Feb 2019 13:58:42 -0500 Received: from mail-it1-f195.google.com ([209.85.166.195]:53326 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728023AbfBRS6m (ORCPT ); Mon, 18 Feb 2019 13:58:42 -0500 Received: by mail-it1-f195.google.com with SMTP id x131so387460itc.3 for ; Mon, 18 Feb 2019 10:58:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Lz107P4BMhmp2Ybd/5l12BPSYujlnGszI7ylzRy5yys=; b=GVMoq9vTM3n1FucY1lTCr+BkbnEVDi2EphLCWpkAqQFbyFQNIs5vE+ucVJAH14s6Q5 WHjErg07+WmhwRKwpHZuKxqoBBHEDQlC1XtDr2pyBy2o6ROCHDojSiz8VoooMpldo5rP o69FCSzZJbb6hh2eFJGR9hAbk4nNbGQ1MD26o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lz107P4BMhmp2Ybd/5l12BPSYujlnGszI7ylzRy5yys=; b=CPFZ5+zlQqqhtEWZgYRVNUFT5KEMT96OgLUHXPQ+ZlGS33vriux5Lq3GqLR060EjVG tZHuaaLvwmqdoZrw6PoU7MS4JAFx48wDq7gLdoBqe8Skil5QYwC8EK58Kq6TUC5ygOch /BNPHOkXQQNnolDIq2/8WoGfrGBH1FAO0hJjn2YYW2SjttCzuRlRYGmmFKdGnXB3iokj /WNl1DKak64xPClfDKFOfgOPpGRuud+0p1gA60b0jaEbk7r4+Z/3BP4n2DyAPPjiJQg9 LcfzTLnn4hnSN/k3VDvUOYIZMU8Gi5Z1QlKkOM7cdLz6t6o8XkggL1XcuuafUch7dAJB C2zQ== X-Gm-Message-State: AHQUAubjjA0DXR29sdDeJ91tlGKJoAVupyMLCpvsXIgQIG82Wbqzn34E UdQYXc9TI6XoVrbNl5STWmU8bxROG8nzj3eUv00keA== X-Received: by 2002:a02:a992:: with SMTP id q18mr13523899jam.70.1550516321179; Mon, 18 Feb 2019 10:58:41 -0800 (PST) MIME-Version: 1.0 References: <20190215170546.GA30950@embeddedor> <20190218085701.GR2665@phenom.ffwll.local> In-Reply-To: From: Daniel Vetter Date: Mon, 18 Feb 2019 19:58:29 +0100 Message-ID: Subject: Re: [PATCH] drm/drm_vm: Mark expected switch fall-throughs To: "Gustavo A. R. Silva" Cc: Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , dri-devel , Linux Kernel Mailing List , Kees Cook Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 18, 2019 at 7:02 PM Gustavo A. R. Silva wrote: > > Hi Daniel, > > On 2/18/19 2:57 AM, Daniel Vetter wrote: > > On Fri, Feb 15, 2019 at 11:05:46AM -0600, Gustavo A. R. Silva wrote: > >> In preparation to enabling -Wimplicit-fallthrough, mark switch > >> cases where we are expecting to fall through. > >> > >> Warning level 3 was used: -Wimplicit-fallthrough=3 > >> > >> Notice that, in this particular case, the code comment is modified > >> in accordance with what GCC is expecting to find. > >> > >> This patch is part of the ongoing efforts to enable > >> -Wimplicit-fallthrough. > >> > >> Signed-off-by: Gustavo A. R. Silva > > > > Queued for 5.2, thanks for your patch. > > -Daniel > > > > I wonder if you could take this one too, or give me some feedback > about it: > > https://patchwork.kernel.org/patch/10646783/ > > I've pinged twice, but I haven't received any responses. Dave? nouveau is kinda your thing, at least all the fallout :-) -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch