Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3049552imj; Mon, 18 Feb 2019 18:31:54 -0800 (PST) X-Google-Smtp-Source: AHgI3IYnVKyVVDCPebCMmO2KH9bxS3DLjrUGFZnRpOyzi+LAE6QGOtnW9ACxxEnxpzwA5mq4r1Ob X-Received: by 2002:a17:902:24a2:: with SMTP id w31mr28263869pla.216.1550543514301; Mon, 18 Feb 2019 18:31:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550543514; cv=none; d=google.com; s=arc-20160816; b=yXmZOfj4Aiw8cAdpJVdeEl6hOF1CxjX1dAxSTp8sW/rkddF3v+kDDYpgj8pIVbe/kt I+PPx4M3F9lyhUzZb7Y++nXCVmHSMD2GJPfy9H2YAg5S9uqkTLO+UpWFZlrd1IV/hLrF 5i7WeEX7LsqZXDTvLNojquPNqgPBRgSfrMpR7qUaeJPKo73wzYBt4eYAJ5Y0v+Jg1SsY SkOtlVxFmxkzymBRKHfs9wgLKTEvS0EPz0gs7gAQAkdRW/lCABtzUJabYCyFNE5WykEc KhxNbWCc4skDK3CJx06MZhc8y05wajbLHHHPNpGyjmNx40iB+Wp74dn7/q/ggHvRfgUM 5ong== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=D6kFl9Ll7Aa4YghBA05CYIbYcOKIJUGXfBawZGN+k7o=; b=0mR4uZdlicZFZTGHXm2P38CcjbeMSglBsLhwCHHBMSx1EWojG8DFRx+vkc1I1a6oDS 8aeAD8RUiviSMgHtY9HCFrlsn66CPhWLxVSCPmLOzqagEqDBPx2GpE7sBMoSlrSVVXZf sjvgLKPhfPifl5+Fx4hTbUCmg9fVcWQ5HM0RD7TYGSR1qfqHl1ht0GnGbKMc7G5kJ3jF qUKjWnDept5GqXbITj49bAHuKBrTXkm2b4iyjq9Ygv2oq5ZEBvd9UoST7o5oMzMlyFrm 5+R+ancs4FYdVNSRL56cqaOnKOLbeVo0IO7Fi1NBS6p0SNqvQ9+kOMWz7hdXKu39M68v RjkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d188si14351973pgc.97.2019.02.18.18.31.38; Mon, 18 Feb 2019 18:31:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729976AbfBRVB2 (ORCPT + 99 others); Mon, 18 Feb 2019 16:01:28 -0500 Received: from smtprelay0022.hostedemail.com ([216.40.44.22]:43696 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729486AbfBRVB1 (ORCPT ); Mon, 18 Feb 2019 16:01:27 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id EB3DF837F24C; Mon, 18 Feb 2019 21:01:25 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 20,1.5,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:599:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2328:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3868:3871:4037:4321:5007:10004:10400:10848:11026:11232:11658:11914:12043:12048:12114:12296:12438:12555:12740:12760:12895:13069:13095:13311:13357:13439:14659:14721:21080:21433:21611:21627:30054:30079:30091,0,RBL:47.151.153.53:@perches.com:.lbl8.mailshell.net-62.14.0.100 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:28,LUA_SUMMARY:none X-HE-Tag: comb75_6396683d9720e X-Filterd-Recvd-Size: 1640 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Mon, 18 Feb 2019 21:01:24 +0000 (UTC) Message-ID: Subject: Re: [PATCH 5/5] iio:potentiostat:lmp91000: add '\n' on dev_err From: Joe Perches To: Lucas Oshiro , jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, Anderson Reis Date: Mon, 18 Feb 2019 13:01:23 -0800 In-Reply-To: <20190218172236.7781-6-lucasseikioshiro@gmail.com> References: <20190218172236.7781-1-lucasseikioshiro@gmail.com> <20190218172236.7781-6-lucasseikioshiro@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-02-18 at 14:22 -0300, Lucas Oshiro wrote: > Add missing '\n' at the end of dev_err message on line 215. [] > diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c [] > @@ -212,7 +212,7 @@ static int lmp91000_read_config(struct lmp91000_data *data) > ret = of_property_read_u32(np, "ti,tia-gain-ohm", &val); > if (ret) { > if (!of_property_read_bool(np, "ti,external-tia-resistor")) { > - dev_err(dev, "no ti,tia-gain-ohm defined"); > + dev_err(dev, "no ti,tia-gain-ohm defined\n"); Perhaps a copy/paste error as the test is for external-tia-resistor and not tia-gain-ohm