Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3060513imj; Mon, 18 Feb 2019 18:49:21 -0800 (PST) X-Google-Smtp-Source: AHgI3IbzRhbWZSUSEI+o/90alOh9/0PTwednw6PxoLBFpYrfaMX1fEcPYBeFUHOVdOmHc4qVdXeG X-Received: by 2002:a62:b40b:: with SMTP id h11mr9502180pfn.108.1550544561746; Mon, 18 Feb 2019 18:49:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550544561; cv=none; d=google.com; s=arc-20160816; b=XSi8OD4uIIJWRNImqqBUERmQNpkgo8lcLMhGRu8YbXZ0LOlY+dVKDiJZr+sPQiZSwQ Xq7KmuxWTKPGTR5qF1QWk6MoSr91/A4id1qzrNTBh6GeNtAOC2e3bRmVktj/TeTzJASb yBNo0HtFuPKohdEGxT7a3Bh8J1oHEDR+gJ01SeVkO6cYx7WroHW0UaVo6mS07AuCGueU yXHascfSB2x3A2+tqlG6/Hy5HTfyXITTpMH106kU/jEe92VGMKqtT3qXFJfUY3Go0X52 HHTXVoQIr8mXEHNDOquMUJzXXWs3VfxMFHd1g8aJeA8LX5lVy8o7h+8j+BLhFzGqSBcS V0EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=y9/2G8O7995fqa+ntv/rPYfP1g/fzistA39RG4r7J98=; b=KdrPc2H3uvP3kwz9PmTMt+3u2CLzBgSeWrTJAmqqI/JFeriwuFB7Vv+F3EoxYlYDgQ 2rnG9hRg8GfdiDKohtJYl6jwckhoPmaxkoV82bfzlLP4ZrwZt4nkr/EuAp6Z4S/a22fX qXxiC+c8anEdMQwriQ4eFAazFW+nvPppcXfd7QhsUDWsvehNudjkgVFKjeEDOcnKc7Vi OnqOHi70xYK+GKkZAsnkJK3fuMNdxT6JedCtIZ+SMpyWqs+5MbffVkiEa0ubWfURTfOQ 6oFfKRBSze2FI+5UvW3Y3MS8vw/tQLJiKhysaQXbOIrdHVIjZ47iFOVerFZGM8WZ0x+6 tD2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x6si13940640pgp.367.2019.02.18.18.49.06; Mon, 18 Feb 2019 18:49:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733032AbfBSBph (ORCPT + 99 others); Mon, 18 Feb 2019 20:45:37 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:57252 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732665AbfBSBpe (ORCPT ); Mon, 18 Feb 2019 20:45:34 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 22176108DE85D; Mon, 18 Feb 2019 17:45:34 -0800 (PST) Date: Mon, 18 Feb 2019 17:45:33 -0800 (PST) Message-Id: <20190218.174533.1821639443595554040.davem@davemloft.net> To: salil.mehta@huawei.com Cc: yisen.zhuang@huawei.com, lipeng321@huawei.com, mehta.salil@opnsrc.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH net] net: hns: Fixes the missing put_device in positive leg for roce reset From: David Miller In-Reply-To: <20190218174032.22972-1-salil.mehta@huawei.com> References: <20190218174032.22972-1-salil.mehta@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Feb 2019 17:45:34 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Salil Mehta Date: Mon, 18 Feb 2019 17:40:32 +0000 > This patch fixes the missing device reference release-after-use in > the positive leg of the roce reset API of the HNS DSAF. > > Fixes: c969c6e7ab8c ("net: hns: Fix object reference leaks in hns_dsaf_roce_reset()") > Reported-by: John Garry > Signed-off-by: Salil Mehta Applied, thanks Salil.