Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3185602imj; Mon, 18 Feb 2019 22:07:06 -0800 (PST) X-Google-Smtp-Source: AHgI3IY4HPId4hQCB1VIPdAFbnJ6ldNP0tv16u0tdc18+hvmPlFDAznIPF61qXXrQmTiUKc3G8ti X-Received: by 2002:a63:7503:: with SMTP id q3mr20987272pgc.98.1550556426255; Mon, 18 Feb 2019 22:07:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550556426; cv=none; d=google.com; s=arc-20160816; b=mhZVmE0IFThhB0/EXo3izw9r40mW0wE7wxbynBykqfiFDr/76tKVk/LJ+qjLmWx0tY +k8yr+RUPbDLaXtwNsM3feAEJv/1HdjB0HJheBB9Ttxf/LRAzx46HlIpS+6EG6MFMsOl lRu8+Aj/k08V2Y8AOD7if6kb7U5/Hf5isC2mgixbKvryPXmBxeE412soIqzBsxLTGUy1 kJP7GBD2o7xvlKYSqp87Fl+5Uk7W47qnC430stBGQ/ZoaOZraSxliSdhIRHDWIOAnmg1 0+zT94YheUikcF5v7duPT3Sc7Hztes//07ufmygU9MP9a8RS3KfivJjX2wDBkipQRIqx zEcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=AlXQMPf5dGIVKoffuvDXzs0jRehP4FtGw5K79z3NUFw=; b=myTtVddb5LpKSANJezKwkCg2Q69hLEsUpAFn8OsuIqtCPJMrP0c/aAufWX9m9hWbmi bJN8ousevfPcfBR8PbC02CPEy/owcIpx2s2AQ6JOtD4yS1+Ud1nHvbzE/Rr74Iu0iwFp xg8RZb93MiM3PEUbaaa2/tCOv8TZAaLBVtae2f1/X5l5rKl7jTxiFwZo7X69J0uftgvI UCARpAqkhejVsI1phRGynu7Uvbr99hcXO6WiyjQ/efY0KLW9fvGsHpnIozqKtY+MSQy7 BSOvtnwa/oN7cRQcy6gm+9uZiXF6Na7t6+tpaDJVUs0FORAzDMIsnBZZp9Gl31FoFoe5 P7oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=k+shVbuy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b20si9207968plz.50.2019.02.18.22.06.51; Mon, 18 Feb 2019 22:07:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=k+shVbuy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726514AbfBSGFh (ORCPT + 99 others); Tue, 19 Feb 2019 01:05:37 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:53155 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbfBSGFg (ORCPT ); Tue, 19 Feb 2019 01:05:36 -0500 Received: by mail-wm1-f66.google.com with SMTP id m1so1250641wml.2 for ; Mon, 18 Feb 2019 22:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=AlXQMPf5dGIVKoffuvDXzs0jRehP4FtGw5K79z3NUFw=; b=k+shVbuyKWPt4f1ubogn5pMBlqZfz05F/3ymGovDlDJ5Uk/XF/mzVZvxqPavNozK23 S86Fr6d0OMWTgDEWXz6lr3/lb6t5VmGxiRysPA1bkSh1YfSlFurHrqW6BZiAGPAWdocv muytKG5jGnHY8hac/qJyL511TeDbAtGtpnvGLMeUAx1NJfiWmjHEt6bgSi3UrvIGLqOt fII67mt+cd5+r28cHyZrCiXjqQ45ujNKUS5Uas2//kFOWvCQKieprnOrfbDrdrqnReHY h4131eAJ0yLHZ4RvWEMFwscAwp1O4SbF1Z4CoP5fWAj4dRIzeUkxnkxiBiWWmnGWhBKF skmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=AlXQMPf5dGIVKoffuvDXzs0jRehP4FtGw5K79z3NUFw=; b=nADFxjoW0ol+zbyZsa0cK0m938M2sp5au9pQ7k1IFKhKl0pPWHgCX83gZI1ALu0TmN HZWzlULOgYPxZQlBFrH1qP1xsDdHHLYL9mr9zx+l/u3IHjpkbFdn/JTYfO+NxTQuVOvS d+mb3n7FAthKhrMD1ah8d2ZX2PFsnnlEw39L8iP2MGXaUiLpq44iC5XdLiInR99z9DEQ ibdb1BmCKakMidvgFdZ0awoVtErTSJNuneIAZ6yiE1pwrplYF9DM+0tkqpM50ZOxp9ZR kvvknaB+SHvo04z3oIK+dvV+H4AwHYXNacu47682IimLBW7wlN4MqgRmOLF6ksLVDnAk sX5Q== X-Gm-Message-State: AHQUAuazKicBWOXoBVnyNvM3VmtYL6AFgXkyc+1136fId7PD8OE8fWLx Q6/AZGz4hKTl13YmkdmMKg== X-Received: by 2002:a1c:7211:: with SMTP id n17mr1569134wmc.92.1550556334947; Mon, 18 Feb 2019 22:05:34 -0800 (PST) Received: from avx2 ([46.53.241.2]) by smtp.gmail.com with ESMTPSA id r6sm3784587wrx.48.2019.02.18.22.05.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Feb 2019 22:05:33 -0800 (PST) Date: Tue, 19 Feb 2019 09:05:31 +0300 From: Alexey Dobriyan To: joel@joelfernandes.org Cc: linux-kernel@vger.kernel.org, alexei.starovoitov@gmail.com Subject: Re: [PATCH v2 1/2] Provide in-kernel headers for making it easy to extend the kernel Message-ID: <20190219060531.GA3263@avx2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > /proc/kheaders.txz This is gross. > The feature is also buildable as a module just in case the user desires > it not being part of the kernel image. This makes it possible to load > and unload the headers on demand. A tracing program, or a kernel module > builder can load the module, do its operations, and then unload the > module to save kernel memory. Please explain how keeping headers on the filesystem is not OK due to "licensing and other issues" but keeping a module on the filesystem is OK. > > I can route it via bpf-next tree if there are no objections. Please don't. IKHD_ST IKHD_ED are bogus artifacts as others mentioned. proc_create(S_IFREG) is redundant. seq_file.h is not needed as is THIS_MODULE. I'd say such data should live in their own section for easy extraction with "objdump -j", something /proc/config.gz never did.