Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 04/15] ARM: milbeaut: Add basic support for Milbeaut
 m10v SoC
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Shinji Kanematsu <kanematsu.shinji@socionext.com>,
        Masami Hiramatsu <masami.hiramatsu@linaro.org>,
        Russell King <linux@armlinux.org.uk>,
        Jassi Brar <jaswinder.singh@linaro.org>,
        Takao Orito <orito.takao@socionext.com>,
        Kazuhiro Kasai <kasai.kazuhiro@socionext.com>
References: <1549628778-30785-1-git-send-email-sugaya.taichi@socionext.com>
 <CAK8P3a026P7tZpJ7gsZbf_MnJJ0eVv60ggGXYndX9kCDLpNy4Q@mail.gmail.com>
From:   "Sugaya, Taichi" <sugaya.taichi@socionext.com>
Message-ID: <7266af3b-aeec-4c29-c96e-ee0d21d3e867@socionext.com>
Date:   Tue, 19 Feb 2019 16:12:11 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <CAK8P3a026P7tZpJ7gsZbf_MnJJ0eVv60ggGXYndX9kCDLpNy4Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

Thank you for your comments.

On 2019/02/18 21:15, Arnd Bergmann wrote:
> On Fri, Feb 8, 2019 at 1:26 PM Sugaya Taichi
> <sugaya.taichi@socionext.com> wrote:
> 
>> +static int m10v_pm_enter(suspend_state_t state)
>> +{
>> +       switch (state) {
>> +       case PM_SUSPEND_STANDBY:
>> +               pr_err("STANDBY\n");
>> +               asm("wfi");
>> +               break;
>> +       case PM_SUSPEND_MEM:
>> +               pr_err("SUSPEND\n");
>> +               cpu_pm_enter();
>> +               cpu_suspend(0, m10v_die);
>> +               cpu_pm_exit();
>> +               break;
>> +       }
>> +       return 0;
>> +}
> 
> It looks like you left the pr_err() messages from bringup, they should probably
> be removed now.
> 

OK. remove the pr_err()s.


>> +static int __init m10v_pm_init(void)
>> +{
>> +       suspend_set_ops(&m10v_pm_ops);
>> +
>> +       return 0;
>> +}
>> +late_initcall(m10v_pm_init);
> 
> This requires a check to ensure you are actually on the right platform,
> otherwise you break suspend/resume in a multiplatform kernel running
> on anything other than milbeaut.
>

OK.
I think the solution is adding a "if statement with mlbeaut compatible" 
above suspend_set_ops(&m10v_pm_ops).

Thanks,
Sugaya Taichi


>         Arnd
>