Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 19 Feb 2019 14:07:23 +0100
From:   Michal Kubecek <mkubecek@suse.cz>
To:     Jakub Kicinski <jakub.kicinski@netronome.com>
Cc:     netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
        Andrew Lunn <andrew@lunn.ch>, Jiri Pirko <jiri@resnulli.us>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next v3 04/21] ethtool: helper functions for
 netlink interface
Message-ID: <20190219130723.GF23151@unicorn.suse.cz>
References: <cover.1550513384.git.mkubecek@suse.cz>
 <266b4ea3596de134329f8bbd5d13e282d1d27442.1550513384.git.mkubecek@suse.cz>
 <20190218121517.4d299f6e@cakuba.netronome.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190218121517.4d299f6e@cakuba.netronome.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 18, 2019 at 12:15:17PM -0800, Jakub Kicinski wrote:
> On Mon, 18 Feb 2019 19:21:44 +0100 (CET), Michal Kubecek wrote:
> > +/* create skb for a reply and fill device identification
> > + * payload: payload length (without netlink and genetlink header)
> > + * dev:     device the reply is about (may be null)
> > + * cmd:     ETHNL_CMD_* command for reply
> > + * info:    info for the received packet we respond to
> > + * ehdrp:   place to store payload pointer returned by genlmsg_new()
> > + * returns: skb or null on error
> > + */
> 
> nit: why not correct kdoc?

Good point. I'll fix that, together with the other things.

Michal

> 
> > +struct sk_buff *ethnl_reply_init(size_t payload, struct net_device *dev, u8 cmd,
> > +				 u16 dev_attrtype, struct genl_info *info,
> > +				 void **ehdrp)
> > +{
> > +	void *ehdr;
> > +	struct sk_buff *rskb;
> 
> nit: reverse xmas tree