Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3581755imj; Tue, 19 Feb 2019 06:05:50 -0800 (PST) X-Google-Smtp-Source: AHgI3IZRzqb4HMqPJ075vflvEFCpXtclJ111HCs+p4o70ZXv9NVH++M7wjJYzL1+U5+sNQLPcA5l X-Received: by 2002:a17:902:f20a:: with SMTP id gn10mr30997162plb.105.1550585150277; Tue, 19 Feb 2019 06:05:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550585150; cv=none; d=google.com; s=arc-20160816; b=ukvge3Z9fnyl77hBUwOIw2tG2Yb1r6S0gqLTIr986n1kbvwjC8eoZG9UCW51DTlJDG MbqNS5RDOq4Mi3BLx9H6P9v/WfNWQpi94KZb1Uo6LWQqfsL3MfIMqn78CnGwYm0AJv9i P4bo+jGo092qJ8svL/RarV4Ok7REMEOYb9VvDX4BejAeUEjEt9WOrcGUOPVYzGjTZQWZ qIhGCiiCdwIgxVktUfPCHgajb0FWHT6d/e3Ta7uub5fUrUXxS0cfe2oST6yojHb/aU/3 jN6/qC38rD1iSVymBLeiFSh8FrT2X6aTErqejgYmlD6d5XE0/3HgQ6eTN/NKLQFt0PGL gH8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=JY5q6UXbWcW5loB20ZV7hC17LjTz4HiZs0RmfCn4/pI=; b=nO+Hm6gUTKb05jMiCKNJLsL1KvxjlGdVH/s8+IbawkHKMEAGxfPbpuggAHXbVk8dmh T8iErwPDwmefPI46wFHQ7Qwd9o6iIzrb4LrbF15dOVhB0OWMzFjCiqwn+CHVCr2YnXrg RKGVoplwuf35kEg9uhRXm44GqQcRFnfZu2qRzTGu2enLg3RIkfAOd164t48ki00BlNMs 5a7+AJyT4g+fADlyIfcuabLCDqjn/i8MKWyU3XzUd/JSh42oYsx9xnDw08nGbD4k2JZd 5R42xnShQTnFGCWsLpvEjEGPKq3UVlQ+O2wGe1PTX/OJj1sGYicgL5GeQNgZCQ95RaOi I/dg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bb8si16160131plb.261.2019.02.19.06.05.33; Tue, 19 Feb 2019 06:05:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728355AbfBSOEN (ORCPT + 99 others); Tue, 19 Feb 2019 09:04:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47200 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725803AbfBSOEN (ORCPT ); Tue, 19 Feb 2019 09:04:13 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CC46F81F31; Tue, 19 Feb 2019 14:04:12 +0000 (UTC) Received: from krava (unknown [10.43.17.42]) by smtp.corp.redhat.com (Postfix) with SMTP id 9BE1E173C1; Tue, 19 Feb 2019 14:04:10 +0000 (UTC) Date: Tue, 19 Feb 2019 15:04:09 +0100 From: Jiri Olsa To: Jonas Rabenstein Cc: linux-perf-users@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Namhyung Kim , Andi Kleen , Thomas Richter , Stephane Eranian , linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf: fix HEADER_CMDLINE description in perf.data documentation Message-ID: <20190219140409.GD6435@krava> References: <20190218124648.GN31177@kernel.org> <20190218140203.1982-1-jonas.rabenstein@studium.uni-erlangen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190218140203.1982-1-jonas.rabenstein@studium.uni-erlangen.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 19 Feb 2019 14:04:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 18, 2019 at 03:02:03PM +0100, Jonas Rabenstein wrote: > The content of this feature header is a perf_header_string_list of > the argument vector and not a perf_header_string of the commandline. missing your Signed-off-by Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/Documentation/perf.data-file-format.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt > index dfb218feaad9..5f9a3924830b 100644 > --- a/tools/perf/Documentation/perf.data-file-format.txt > +++ b/tools/perf/Documentation/perf.data-file-format.txt > @@ -131,7 +131,7 @@ An uint64_t with the total memory in bytes. > > HEADER_CMDLINE = 11, > > -A perf_header_string with the perf command line used to collect the data. > +A perf_header_string_list with the perf arg-vector used to collect the data. > > HEADER_EVENT_DESC = 12, > > -- > 2.19.2 >