Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3649476imj; Tue, 19 Feb 2019 07:09:58 -0800 (PST) X-Google-Smtp-Source: AHgI3IYfWD3LJ723Wl5mhhyUV5dIpRfO5wq2/0N6IoziIZTv1ivSW/c20tjTmPMicRST/NYcuWKz X-Received: by 2002:a63:3dc8:: with SMTP id k191mr23027639pga.368.1550588997994; Tue, 19 Feb 2019 07:09:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550588997; cv=none; d=google.com; s=arc-20160816; b=No9y1B2wSSK9pXlm0DtgZtmEsBwKMiuv8+03vpiJZI8sdjPm/JphzhQ91By9P+gCT+ LapkuQpgqPB5Y7IKeAmw/7a7qGRf3GH0QjiiGUJQln+adTgBSHBNt3l0sQ3N8ztqc4if tScPvo17tztcW29c2LW8UcSXtVb1UFg+/3nBPqU3vRj2HUUsPskuILBmyTGFAvBmJ/Pg JfepfVa1ghnG4hDD1y1oV4trHLkJgLYRxR7Y1bRO6HqXAHx2MLpO/As+hfsDJ+feBnCH E2FBMy8Q7QdKEKPq8K1vY68ZCXOEpElfWFpXhryE8Z8xS9+p30ImEhE1oa9jFcarywKH 7Xag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version; bh=lVwRD+1f75F5+MiL8H/sbooRekaIpRakCSMxnXUrqo8=; b=nhv98XS++LJtm1ORBYRHx3oE72231IsLkJPwwL5pe+ft+Y2BkxO/NJfKk0JWg21EXm uP2lAd8CN3Yd8z4JBQIA44mStB2ZICb39zTc2Hu0gBAyUct6Sd9D7UeaeGorwld/t2dG lOwFCiNzvetTc99hvSvruR32mScwkpkk/8RbJ3ph6huzLRuG/UaKMFxBuOf55zbxp3qD WHqXxzrKp5TQfVtrCqDgKeS2uLUJpOptGGr4tm3GNhFB/rzmP6bHPAeZY5Qbmp6UlNsG OzbceXdncyRlrb+07zOQ44ueserqYkBsEwegNvfEpU/4yKQ4KZy+UcpWhq+HW0Lqljzd NNkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v3si15594025pff.158.2019.02.19.07.09.41; Tue, 19 Feb 2019 07:09:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728448AbfBSPI7 convert rfc822-to-8bit (ORCPT + 99 others); Tue, 19 Feb 2019 10:08:59 -0500 Received: from mail.fireflyinternet.com ([109.228.58.192]:65249 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725885AbfBSPI7 (ORCPT ); Tue, 19 Feb 2019 10:08:59 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 15630220-1500050 for multiple; Tue, 19 Feb 2019 15:08:54 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Colin King , Daniel Vetter , David Airlie , Joonas Lahtinen , Rodrigo Vivi , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org From: Chris Wilson In-Reply-To: <20190219150129.12728-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190219150129.12728-1-colin.king@canonical.com> Message-ID: <155058893121.30979.13044488959474735904@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH][next] drm/i915/selftests: fix memory leak of 'spin' Date: Tue, 19 Feb 2019 15:08:51 +0000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Colin King (2019-02-19 15:01:29) > From: Colin Ian King > > There is a memory leak of 'spin' on an error return path. Fix this by > kfree'ing spin before the return. > > Fixes: c06ee6ff2cbc ("drm/i915/selftests: Context SSEU reconfiguration tests") > Signed-off-by: Colin Ian King I hope already fixed by commit 2a4a2754039594c60b58b02b6781428a85f6d745 Author: Chris Wilson Date: Fri Feb 15 19:50:10 2019 +0000 drm/i915/selftests: Always free spinner on __sseu_prepare error Thanks, -Chris