Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3686576imj; Tue, 19 Feb 2019 07:46:12 -0800 (PST) X-Google-Smtp-Source: AHgI3IYKq2hxAUc/H+l/BMIzsEYNc4hHag40LKHNRoLcx/uZdZfnl8yV5FUni9Qk98O0miK43oHI X-Received: by 2002:a62:b511:: with SMTP id y17mr30217612pfe.199.1550591172582; Tue, 19 Feb 2019 07:46:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550591172; cv=none; d=google.com; s=arc-20160816; b=iNRXVMNBKoAc6YlWPtoIieBVcGm8BfkK5rjSBoAsVZZLfZZB5SaDf+Iui79M0qorX8 1gyINmEYOR8FNZpY2PVNRlE2tReOuh6IQHufUG4RQlbeI54FPXTZdsk7noXOk9za+fTE t0fjCRJHf205I3lkbWLkdOcS1Ui9KW0qER3HenORoHM/5A1M9ZuWRMb6u99Zo1L+KBeB TwSZ7uyZUlDNk3oQr510ZfltHdqPz8fTxs0gNUeyeon6SEudHkioXhFPeHznhw9kdlZ0 4pvNFAjHp+bhuMX/hZpNme/wpqD4yF1bdK1jxefBbODzz5oXPkuE9nj0UH3QLJWM/tjv HtWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=vNNhrAr9wFoAX91rpCnI2XrErmD0XxzeMWguPgy+FkU=; b=jXv3QnTrWugrB3CxkkvxxNDYPpo7AQ37fcnG0n1+gIJBu1b+BGuHhNn+pGJuP97N/G TfHAXSmDnTr7I5An/r5TwRhHtLwK/KBnJJglqEejNR1S9UzDm7q9vvu0JFbuI7TCWZSq RAq3YG533Oc0hGz1Z7QChDidXoP6BqbGc6YwlFm4UsmqzcnQruIU0dKUklRFitlGu4rN 2u1NzHuHI3869OvIs1YrnjOAuSXL8B5th9pMbF+4hjvWZZsZJLvhLgIWaPuc7qOwqcQO +2E/U6zfkq4Dd47Hni/g3FKToAr1NEWvStkneV/fb9jcg+JO/Qh/P2Wutl+kLeVFb9x8 9WkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r73si15893950pfb.221.2019.02.19.07.45.57; Tue, 19 Feb 2019 07:46:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728035AbfBSPp2 (ORCPT + 99 others); Tue, 19 Feb 2019 10:45:28 -0500 Received: from mx-rz-3.rrze.uni-erlangen.de ([131.188.11.22]:43570 "EHLO mx-rz-3.rrze.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726110AbfBSPpZ (ORCPT ); Tue, 19 Feb 2019 10:45:25 -0500 Received: from mx-rz-smart.rrze.uni-erlangen.de (mx-rz-smart.rrze.uni-erlangen.de [IPv6:2001:638:a000:1025::1e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx-rz-3.rrze.uni-erlangen.de (Postfix) with ESMTPS id 443lS33WNWz1yKZ; Tue, 19 Feb 2019 16:45:23 +0100 (CET) Authentication-Results: mx-rz-3.rrze.uni-erlangen.de; dkim=none reason="no signature"; dkim-adsp=none (unprotected policy); dkim-atps=neutral X-Virus-Scanned: amavisd-new at boeck5.rrze.uni-erlangen.de (RRZE) X-RRZE-Flag: Not-Spam X-RRZE-Submit-IP: 10.21.11.199 Received: from fau.de (faustud-010-021-011-199.pool.uni-erlangen.de [10.21.11.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: U2FsdGVkX18Y7z666ypNef2y22RainNqZDybl1ZZc7I=) by smtp-auth.uni-erlangen.de (Postfix) with ESMTPSA id 443lS12jcDz1xpY; Tue, 19 Feb 2019 16:45:21 +0100 (CET) From: Jonas Rabenstein To: linux-perf-users@vger.kernel.org Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , Thomas Richter , Stephane Eranian , Jonas Rabenstein , linux-kernel@vger.kernel.org Subject: [PATCH] perf: fix documentation of the Flags section in perf.data Date: Tue, 19 Feb 2019 16:45:15 +0100 Message-Id: <20190219154515.3954-2-jonas.rabenstein@studium.uni-erlangen.de> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190219154515.3954-1-jonas.rabenstein@studium.uni-erlangen.de> References: <20190219152413.GB31177@kernel.org> <20190219154515.3954-1-jonas.rabenstein@studium.uni-erlangen.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to the current documentation the flags section is placed after the file header itself but the code assumes to find the flags section after the data section. This change updates the documentation to that assumption. Acked-by: Jiri Olsa Signed-off-by: Jonas Rabenstein --- tools/perf/Documentation/perf.data-file-format.txt | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt index 5f9a3924830b..593ef49b273c 100644 --- a/tools/perf/Documentation/perf.data-file-format.txt +++ b/tools/perf/Documentation/perf.data-file-format.txt @@ -43,11 +43,10 @@ struct perf_file_section { Flags section: -The header is followed by different optional headers, described by the bits set -in flags. Only headers for which the bit is set are included. Each header -consists of a perf_file_section located after the initial header. -The respective perf_file_section points to the data of the additional -header and defines its size. +For each of the optional features a perf_file_section it placed after the data +section if the feature bit is set in the perf_header flags bitset. The +respective perf_file_section points to the data of the additional header and +defines its size. Some headers consist of strings, which are defined like this: -- 2.19.2