Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3687936imj; Tue, 19 Feb 2019 07:47:34 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ/7nIzN2f98ntk9HaYqI/5xtf4f2Ry16+BfQYWmvRB+5JQjOAx5ke0CivPqTROc3IewJ4O X-Received: by 2002:a63:d49:: with SMTP id 9mr24419683pgn.27.1550591254142; Tue, 19 Feb 2019 07:47:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550591254; cv=none; d=google.com; s=arc-20160816; b=I12oikmCYtoINyKlBiM8J4dzc1fc397XNS0MyVp6Oye21LLo4B/vYS4yuNkONURoSm yA5+GZ+dCF36QYU92qXRJ7HuwRrAmSRB+qQ/sm2SpOkHXZXmqam70EUlGwsbnKP+MFSs mYzXKRkPbzRyBV+2D+h6OQS2zBmKVt08kIlbLDPeaufpsvAHdu9BW5zpOiZBAcNczB8Z 7c2i9gQIoaVOCwlf41AMRaoPncY+x20kxZTAJo7ZTfJ4tQ/9omz+Vn93GDKJ+sz4mdmK bcIkXJosvTf2kTogUSEtdKLqBRjNAZQXvbJdJix/e8biVzxYZkfbCYTBL0boiBKnXZfD mnwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:mime-version:user-agent:date:organization :autocrypt:openpgp:subject:from:to:cc; bh=JbdKgSsDhbxEUlykLNyJL1t/JRPznZhjaYbrvYxicNE=; b=ZSyytKtnmFMkZ21WgKmTM4MTPbXdhxLrAyRwJl9lcxIeV62xYqC3b4kE5I4BHMNUFe XFOEHOZJkpzbHeuWjzg2wcgmFr6z2V5imhOvVOn0nYxZaki4ZkNHaEuVrNSKfaRM2Dib 5HOj4OtdvHAz5hHuxECe+GZhT7j6eEqrFzPrbLBHefnlh7KAa9JHcfiqxg53NyE2iLcN I1rqqhN9OpNOuSBMcEj57DaLiV/R2jiLQ6dR18cdjUH+d+V707ByMt8aRNNbdO8M6C/U Fk1opnjMU8Vf0j0xJlbt1OjNyeysKptLl/WtnmX+N/1JSCcM1RNGyUKIRN/HLOBK2qmb f28g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t75si15682066pfi.193.2019.02.19.07.47.18; Tue, 19 Feb 2019 07:47:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727566AbfBSPqu (ORCPT + 99 others); Tue, 19 Feb 2019 10:46:50 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38448 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726110AbfBSPqu (ORCPT ); Tue, 19 Feb 2019 10:46:50 -0500 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1JFcxwa066335 for ; Tue, 19 Feb 2019 10:46:49 -0500 Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qrmfg903g-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 19 Feb 2019 10:46:48 -0500 Received: from localhost by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 19 Feb 2019 15:46:47 -0000 Received: from b03cxnp07029.gho.boulder.ibm.com (9.17.130.16) by e35.co.us.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 19 Feb 2019 15:46:44 -0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x1JFkhLv28967000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Feb 2019 15:46:43 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BD149BE059; Tue, 19 Feb 2019 15:46:43 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2AA88BE04F; Tue, 19 Feb 2019 15:46:43 +0000 (GMT) Received: from oc8380061452.ibm.com (unknown [9.53.179.224]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 19 Feb 2019 15:46:43 +0000 (GMT) Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Nicholas Piggin , Rob Herring , Tyrel Datwyler , "Juliet M. Kim" , Nathan Lynch , Thomas Falcon , Michael Bringmann To: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org From: Michael Bringmann Subject: [PATCH] powerpc/pseries: Fix dn reference error in dlpar_cpu_remove_by_index Openpgp: preference=signencrypt Autocrypt: addr=mwb@linux.vnet.ibm.com; prefer-encrypt=mutual; keydata= mQENBFcY7GcBCADzw3en+yzo9ASFGCfldVkIg95SAMPK0myXp2XJYET3zT45uBsX/uj9/2nA lBmXXeOSXnPfJ9V3vtiwcfATnWIsVt3tL6n1kqikzH9nXNxZT7MU/7gqzWZngMAWh/GJ9qyg DTOZdjsvdUNUWxtiLvBo7y+reA4HjlQhwhYxxvCpXBeRoF0qDWfQ8DkneemqINzDZPwSQ7zY t4F5iyN1I9GC5RNK8Y6jiKmm6bDkrrbtXPOtzXKs0J0FqWEIab/u3BDrRP3STDVPdXqViHua AjEzthQbGZm0VCxI4a7XjMi99g614/qDcXZCs00GLZ/VYIE8hB9C5Q+l66S60PLjRrxnABEB AAG0LU1pY2hhZWwgVy4gQnJpbmdtYW5uIDxtd2JAbGludXgudm5ldC5pYm0uY29tPokBOAQT AQIAIgUCVxjsZwIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQSEdag3dpuTI0NAf8 CKYTDKQLgOSjVrU2L5rM4lXaJRmQV6oidD3vIhKSnWRvPq9C29ifRG6ri20prTHAlc0vycgm 41HHg0y2vsGgNXGTWC2ObemoZBI7mySXe/7Tq5mD/semGzOp0YWZ7teqrkiSR8Bw0p+LdE7K QmT7tpjjvuhrtQ3RRojUYcuy1nWUsc4D+2cxsnZslsx84FUKxPbLagDgZmgBhUw/sUi40s6S AkdViVCVS0WANddLIpG0cfdsV0kCae/XdjK3mRK6drFKv1z+QFjvOhc8QIkkxFD0da9w3tJj oqnqHFV5gLcHO6/wizPx/NV90y6RngeBORkQiRFWxTXS4Oj9GVI/UrkBDQRXGOxnAQgAmJ5Y ikTWrMWPfiveUacETyEhWVl7u8UhZcx3yy2te8O0ay7t9fYcZgIEfQPPVVus89acIXlG3wYL DDPvb21OprLxi+ZJ2a0S5we+LcSWN1jByxJlbWBq+/LcMtGAOhNLpysY1gD0Y4UW/eKS+TFZ 562qKC3k1dBvnV9JXCgeS1taYFxRdVAn+2DwK3nuyG/DDq/XgJ5BtmyC3MMx8CiW3POj+O+l 6SedIeAfZlZ7/xhijx82g93h07VavUQRwMZgZFsqmuxBxVGiav2HB+dNvs3PFB087Pvc9OHe qhajPWOP/gNLMmvBvknn1NToM9a8/E8rzcIZXoYs4RggRRYh6wARAQABiQEfBBgBAgAJBQJX GOxnAhsMAAoJEEhHWoN3abky+RUH/jE08/r5QzaNKYeVhu0uVbgXu5fsxqr2cAxhf+KuwT3T efhEP2alarxzUZdEh4MsG6c+X2NYLbD3cryiXxVx/7kSAJEFQJfA5P06g8NLR25Qpq9BLsN7 ++dxQ+CLKzSEb1X24hYAJZpOhS8ev3ii+M/XIo+olDBKuTaTgB6elrg3CaxUsVgLBJ+jbRkW yQe2S5f/Ja1ThDpSSLLWLiLK/z7+gaqwhnwjQ8Z8Y9D2itJQcj4itHilwImsqwLG7SxzC0NX IQ5KaAFYdRcOgwR8VhhkOIVd70ObSZU+E4pTET1WDz4o65xZ89yfose1No0+r5ht/xWOOrh8 53/hcWvxHVs= Organization: IBM Linux Technology Center Date: Tue, 19 Feb 2019 09:46:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19021915-0012-0000-0000-0000170D32BE X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010626; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000281; SDB=6.01163357; UDB=6.00607428; IPR=6.00943939; MB=3.00025659; MTD=3.00000008; XFM=3.00000015; UTC=2019-02-19 15:46:46 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19021915-0013-0000-0000-0000564264E7 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-19_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902190116 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org powerpc/pseries: Fix dn reference error in dlpar_cpu_remove_by_index() A reference to the device node of the CPU to be removed is released upon successful removal of the associated CPU device. If the call to remove the CPU device fails, dlpar_cpu_remove_by_index() still frees the reference and this leads to miscomparisons and/or addressing errors later on. This problem may be observed when trying to DLPAR 'hot-remove' a CPU from a system that has only a single CPU. The operation will fail because there is no other CPU to which the kernel operations may be migrated, but the refcount will still be decremented. Signed-off-by: Michael Bringmann diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c index 97feb6e..9537bb9 100644 --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c @@ -635,7 +635,8 @@ static int dlpar_cpu_remove_by_index(u32 drc_index) } rc = dlpar_cpu_remove(dn, drc_index); - of_node_put(dn); + if (!rc) + of_node_put(dn); return rc; }