Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3756750imj; Tue, 19 Feb 2019 08:55:53 -0800 (PST) X-Google-Smtp-Source: AHgI3Ia7CHQG46SiHaYLH7A2zmS+FsqElToyGXnEayUu4pI3aP/hH/eTsAXjURGRJ7P2nPHIqlW7 X-Received: by 2002:a17:902:f01:: with SMTP id 1mr31326101ply.41.1550595353362; Tue, 19 Feb 2019 08:55:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550595353; cv=none; d=google.com; s=arc-20160816; b=DfIBgpFnGavwhEgNAgWnNgFxuSeqcyx4h2rL9YRpNHk+KmOFO9jbg870/jI4GyJROJ JREMwFdAi8hlSVCJd8mE274lHwy2yj9/4i/NwPZGJ3VJkDsqL8JDqrFYuKrzSBY4K1dE y6OwpfFRs6xPHp7HNJU+M4t9NA1kproMVnKDIf86fIFSlXvE9RyvG66gSBriyCq5pWrK AJVV3r9nFpyVuvSPTPqCoMVzJf+MafpeYW3PehxJaompJkkK5c3Vl0dnKifZ4o6MmjNf c84vZEUyhLSofbUKh8X+KDYIo4tNUNkNul9h+4I7kgHHUEjpSdVdzvXj4iwHB9fqE+iK sDVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=Vh1JnJazjs0zKHsYRgD4ccPicOP/RVFRNtPRfjQjMNM=; b=T7pt6wEPQYu3/vPU7axFjVIV+nAgj4RCqMXoC2CH44iR45edO5/yMUEkb+GBsZW3Xy EpCgsOTA4DC4E3Ot1r+keREJmLdOuVGQy9XoX5jtg8MJlxuNgZPkLhfKHNamK1xlygBg 7qsmqydQkhDB2qGno8LpmMRoD5ARTfKn/E4iDeINXUndHTunBXM90C3MCYpC/OERFX07 SWOjgUjzy6m7j0Sac3kz1+uvJoX6GlM4glm5LmnwVZ3IhHohFEuT8l7tta9QguXASLTh YhCPoB2jV2GPTvDXHuf/+bF/oWj8m3fCdlWxowgcG1FSGfzwYpfF6LrW6UJDS4cJLxge I3jw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n18si15565041pgm.28.2019.02.19.08.55.38; Tue, 19 Feb 2019 08:55:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729319AbfBSQzJ (ORCPT + 99 others); Tue, 19 Feb 2019 11:55:09 -0500 Received: from www62.your-server.de ([213.133.104.62]:50732 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726244AbfBSQzJ (ORCPT ); Tue, 19 Feb 2019 11:55:09 -0500 Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1gw8C5-0003L5-Ta; Tue, 19 Feb 2019 17:24:29 +0100 Received: from [178.197.248.36] (helo=linux.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1gw8C5-000TCB-Ns; Tue, 19 Feb 2019 17:24:29 +0100 Subject: Re: [PATCH bpf-next v2] bpf: bpftool, fix documentation for attach types To: Alban Crequy , ast@kernel.org, quentin.monnet@netronome.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, john.fastabend@gmail.com, alban@kinvolk.io, iago@kinvolk.io References: <20190219141332.23103-1-alban@kinvolk.io> From: Daniel Borkmann Message-ID: Date: Tue, 19 Feb 2019 17:24:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190219141332.23103-1-alban@kinvolk.io> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.2/25365/Tue Feb 19 11:36:48 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/19/2019 03:13 PM, Alban Crequy wrote: > From: Alban Crequy > > bpftool has support for attach types "stream_verdict" and > "stream_parser" but the documentation was referring to them as > "skb_verdict" and "skb_parse". The inconsistency comes from commit > b7d3826c2ed6 ("bpf: bpftool, add support for attaching programs to > maps"). > > This patch changes the documentation to match the implementation: > - "bpftool prog help" > - man pages > - bash completion > > Signed-off-by: Alban Crequy Applied, thanks Alban!