Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp3870173imj; Tue, 19 Feb 2019 10:53:09 -0800 (PST) X-Google-Smtp-Source: AHgI3IYq3uD3HaqnnYF90BwfqE+l5rpEtufmPVEjS5El3L7uNA/zp6R2w6vy7ASiWNTOuYBJAyCR X-Received: by 2002:a62:6dc7:: with SMTP id i190mr30773171pfc.166.1550602389328; Tue, 19 Feb 2019 10:53:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550602389; cv=none; d=google.com; s=arc-20160816; b=C5TUWTGcwxLQeKgPQQw9m1cAIGLT6iYe+y834iLJjT+Ah35oQxP5TSntIJhZCqUoNO fXPv+SxEf3ezuOFvWu7NaaVrnC8vMuOsIA4phELTxxjZ9MdjPQZi2c0W6F/P+ep7do8p L8JfZEzgBlFsUICT6LNxelAakSRXiUwzz6khpU3uFbOVS1NbJMmEvtxm4Pfsh3Uc8A1Y 6aFuyzit+ndyvkuGYxiH8LyQdMvHE/YXvaThdVqfABcelj2jxjXyEQ8npDUsKeQF+4G4 E2sDcSk3TUpJy69tWK5JuFOYxR+RxPMoLWzuvG3R1ROyIgOqtUdYSrEJd1yJ7eE4XmPQ KcSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=fNQ9Icbc65m2b+SpDs+KXMxcqOB+7+mb5hMs2CkFVA4=; b=i6t9kkIQ0Jr7GOkduTOXa85iK585y+WwfjAIL7AkDBN01sX/bt/G79XpHzez0Ja8xM dbLRhrsk0dSbaO8AU0p5tO+aK6q2Dc62akLmQAIvr8wudIlRxcp4XJPw31yTEPRIH2hk M4pJgZa2BaoxJg43rZ31/8FP8uqaaXfiPVzPHj3nyHOM1WhBpt6Bee2qX+KQ6D/4Rzlr T+e0vlk7P7ApCW+5zbCd2g7dKSoJurei1T/Yiuokth8tC3ievwWiIAEXI6gfBmoIJ2mk ukXlmS/lMAuPVUEG+GGbG2N1gT0azA9gP/AkWZ/AzSM8rDsWlOFoJQ2jepr1C1e4gNBo Jcig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UNxfIOtY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p7si16107200pgh.84.2019.02.19.10.52.54; Tue, 19 Feb 2019 10:53:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UNxfIOtY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727426AbfBSSwV (ORCPT + 99 others); Tue, 19 Feb 2019 13:52:21 -0500 Received: from mail-yb1-f194.google.com ([209.85.219.194]:37825 "EHLO mail-yb1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725875AbfBSSwU (ORCPT ); Tue, 19 Feb 2019 13:52:20 -0500 Received: by mail-yb1-f194.google.com with SMTP id 2so8539720ybw.4; Tue, 19 Feb 2019 10:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fNQ9Icbc65m2b+SpDs+KXMxcqOB+7+mb5hMs2CkFVA4=; b=UNxfIOtYMSwXfnbssuX8E4Fe35S/R2FiQ55pz4IyiNTy9pq1fX6hi/Jwxi4LboKa6m QjO2Vp53u8DaIQXVlIZeT/5/bPGvPuj07dCgXyOxspj8N9KwHBI5er2jBG0Zgu8KzEO0 tuQ75XZHXlvJ3uxEecN0GULfVC5gQNQIcieqBaieScXiWcbnOzVy334+46wu5rQUie1E 0F6/+FVZu1h1BTfqNvgKgPAfQbQ8iLpKCifnxCGAnYODFeIXFuOJn+oV/ZdbaykJPl/g FiBdaqiy6aQoMHMaHI3ieMHKp93JiThy7enOBegDky7zgRlreOH0dy6IWmG1lJIosRQt 6exQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=fNQ9Icbc65m2b+SpDs+KXMxcqOB+7+mb5hMs2CkFVA4=; b=hExMSLgwqi0vqwQShl1MVMRssx7dm9986DpdCgYtx4pykW89it7I61/QxDy+Yx8Qpj JXl3J8AADCXwEpUo3k+LIUVLkmdYP8bB2K7Is9D2fpem64Sz1CXemUBnsZca8gMEtDZx STh4uHppDVRpPGKgazt+uhjYoGkDwayZNA26wTqR4YGsfl/4bZEIVKvB40gBqQRuqBMo +YME2dxoBgt4rqyiWYfh3WaSaS0ZkVQqtiurYp0aDcqSkWWLsxjjUO9/SYJZXUKWlWXB FidYt0xQcZVlsH20MqQfohqY/RWsFPRu4mZ7n6eLUdt4t7pFiGpa8Ul771Elmnyd8FpX F/Jw== X-Gm-Message-State: AHQUAuax9zDLYkBw8K8LIc3NKgxoATt8qklKZ1Nvg3aaL5EBKt/0vpo9 tZqXZC7ffFvYHCmmFvl4PDQ= X-Received: by 2002:a25:7284:: with SMTP id n126mr25751863ybc.504.1550602339366; Tue, 19 Feb 2019 10:52:19 -0800 (PST) Received: from [10.67.49.152] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id o4sm6457296ywe.102.2019.02.19.10.52.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Feb 2019 10:52:18 -0800 (PST) Subject: Re: [PATCH] hwrng: bcm2835 - fix probe as platform device To: Jonas Gorski , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Matt Mackall , Herbert Xu , Arnd Bergmann , Greg Kroah-Hartman , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Eric Anholt , Stefan Wahren References: <20190219121608.19406-1-jonas.gorski@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Tue, 19 Feb 2019 10:52:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190219121608.19406-1-jonas.gorski@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/19/19 4:16 AM, Jonas Gorski wrote: > BCM63XX (MIPS) does not use device tree, so there cannot be any > of_device_id, causing the driver to fail on probe: > > [ 0.904564] bcm2835-rng: probe of bcm63xx-rng failed with error -22 > > Fix this by checking for match data only if we are probing from device > tree. > > Fixes: 8705f24f7b57 ("hwrng: bcm2835 - Enable BCM2835 RNG to work on BCM63xx platforms") > Signed-off-by: Jonas Gorski Acked-by: Florian Fainelli Sorry about that, thanks for the fix! -- Florian