Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp4109666imj; Tue, 19 Feb 2019 15:44:21 -0800 (PST) X-Google-Smtp-Source: AHgI3IZLBv0KR1sNNYNZOFqc8frkqfefKxSSQF0LztHUhfjB3p7Z3U28+DVPm4N78VH2XGogGrOY X-Received: by 2002:a63:1204:: with SMTP id h4mr30120605pgl.51.1550619861702; Tue, 19 Feb 2019 15:44:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550619861; cv=none; d=google.com; s=arc-20160816; b=07VZjfrsg76yAfg05u/D8O9eUkyO1BiQ9Q4mohOSAZvj0zMv4RYMP2MxnKW0CI/oT8 0ShVIscvEXfQ3Gex6Vg0oK6Ca4Qx1dY2skhNpGTugXLeh3r+18Vd+JUE3jmoS6USE/mY 8hoa4VWPh2X1i+4LFk8+hzEq398jEljZKdF5eJi9EPWA/CvuheAjCSRuN/2ivggtAk0X r56ddu3aBSi8uNUea7Agngr5BqkOTbLJ85nuklOVBLf4feHWBWey570nwZpRKMuISNxY ROyssedXZzj3DF/9+yymgcvFAnlWGwbsAXz5fsT76/SZhI3EjsCPNya7Z3Btkcshur3O cBFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization; bh=YtoS1gcW1qRPSvK4jpGrqZNgKS+Ak11GL8m5Lxsduz8=; b=kZ8KKlhB+PUU1QVHgOb/4JpRGOCb1ltO6O+n/GrwpBMw+r7Cffx5a2zHXxEMSSqq4P rSOU53Hs0TdxNwt7FeuQRBCuIAYUVMjwPmy2/fhxot+pAVske0Hd9yPs1qcllKnLXTs1 reD8md7fSxrVcV+SnxByEnmrOx+b8qcMj2CptwpAvh1BWF5rH1VkPHqUR6YD5DBIVzJi FeuMNSoRsP5a02zz9YOOWACWEWHhpGQxIS1jGGjA6KIEkECM0TSOd7/BhK3ixLoRCcVU mpHYJVNiuNVxPrqvWlyIoJbuYk61gJP7xczSzHeXvvz48U6RhfU/8vx1FqQM6PGYddZn 0s1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s21si8737765pgv.299.2019.02.19.15.44.06; Tue, 19 Feb 2019 15:44:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730019AbfBSXmU (ORCPT + 99 others); Tue, 19 Feb 2019 18:42:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35740 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726405AbfBSXmU (ORCPT ); Tue, 19 Feb 2019 18:42:20 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC39E81F12; Tue, 19 Feb 2019 23:42:19 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-129.rdu2.redhat.com [10.10.121.129]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6B09E19C57; Tue, 19 Feb 2019 23:42:15 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <8736ojybw7.fsf@xmission.com> References: <8736ojybw7.fsf@xmission.com> <155024683432.21651.14153938339749694146.stgit@warthog.procyon.org.uk> To: ebiederm@xmission.com (Eric W. Biederman) Cc: dhowells@redhat.com, keyrings@vger.kernel.org, trond.myklebust@hammerspace.com, sfrench@samba.org, linux-security-module@vger.kernel.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, rgb@redhat.com, linux-kernel@vger.kernel.org, Linux Containers , linux-api@vger.kernel.org Subject: Re: [RFC PATCH 00/27] Containers and using authenticated filesystems MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <22054.1550619729.1@warthog.procyon.org.uk> Date: Tue, 19 Feb 2019 23:42:09 +0000 Message-ID: <22055.1550619729@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 19 Feb 2019 23:42:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric W. Biederman wrote: > So you missed the main mailing lists for discussion of this kind of > thing Yeah, sorry about that. I was primarily aiming it at Trond and Steve as I'd like to consider how to go about interpolating request_key() into NFS and CIFS so that they can make use of the key-related facilities that this makes available with AFS. And I was in a bit tight for time to mail it out before having to go out. I know, excuses... ;-) > and the maintainer. That would be me. I maintain keyrings. No one is listed in MAINTAINERS as owning namespaces. If you feel that should be you, please add a record. > Looking at your description you are introducing a container id. Yes. For audit logging, which was why I cc'd Richard. > You don't descibe which namespace your contianer id lives in. It doesn't. Not everything has to have a namespace. As you yourself pointed out, it should be globally unique, in which case the world is the namespace, maybe even the universe;-). > Without the container id living in a container this breaks > nested containers and process migration aka CRIU. As long as IDs are globally unique, why should break container migration? Having a kernel container object might even make CRIU easier. And what does "Without the container id living in a container" mean anyway? I have IDs attached to containers. A container can see the IDs of its child containers. There should be no problem with nesting. David