Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Zi Yan <ziy@nvidia.com>
To:     Mike Kravetz <mike.kravetz@oracle.com>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Michal Hocko <mhocko@kernel.org>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Mel Gorman <mgorman@techsingularity.net>,
        John Hubbard <jhubbard@nvidia.com>,
        Mark Hairgrove <mhairgrove@nvidia.com>,
        Nitin Gupta <nigupta@nvidia.com>,
        David Nellans <dnellans@nvidia.com>
Subject: Re: [RFC PATCH 00/31] Generating physically contiguous memory after
 page allocation
Date:   Tue, 19 Feb 2019 18:33:35 -0800
Message-ID: <FDDDB4C8-C5B5-46B0-9682-33AC063F7A46@nvidia.com>
In-Reply-To: <f4cf53a3-359b-8c66-ed15-112b3cf0f475@oracle.com>
References: <20190215220856.29749-1-zi.yan@sent.com>
 <f4cf53a3-359b-8c66-ed15-112b3cf0f475@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 19 Feb 2019, at 17:42, Mike Kravetz wrote:

> On 2/15/19 2:08 PM, Zi Yan wrote:
>
> Thanks for working on this issue!
>
> I have not yet had a chance to take a look at the code.  However, I do=20
> have
> some general questions/comments on the approach.

Thanks for replying. The code is very intrusive and has a lot of hacks,=20
so it is
OK for us to discuss the general idea first. :)


>> Patch structure
>> ----
>>
>> The patchset I developed to generate physically contiguous=20
>> memory/arbitrary
>> sized pages merely moves pages around. There are three components in=20
>> this
>> patchset:
>>
>> 1) a new page migration mechanism, called exchange pages, that=20
>> exchanges the
>> content of two in-use pages instead of performing two back-to-back=20
>> page
>> migration. It saves on overheads and avoids page reclaim and memory=20
>> compaction
>> in the page allocation path, although it is not strictly required if=20
>> enough
>> free memory is available in the system.
>>
>> 2) a new mechanism that utilizes both page migration and exchange=20
>> pages to
>> produce physically contiguous memory/arbitrary sized pages without=20
>> allocating
>> any new pages, unlike what khugepaged does. It works on per-VMA=20
>> basis, creating
>> physically contiguous memory out of each VMA, which is virtually=20
>> contiguous.
>> A simple range tree is used to ensure no two VMAs are overlapping=20
>> with each
>> other in the physical address space.
>
> This appears to be a new approach to generating contiguous areas. =20
> Previous
> attempts had relied on finding a contiguous area that can then be used=20
> for
> various purposes including user mappings.  Here, you take an existing=20
> mapping
> and make it contiguous.  [RFC PATCH 04/31] mm: add mem_defrag=20
> functionality
> talks about creating a (VPN, PFN) anchor pair for each vma and then=20
> using
> this pair as the base for creating a contiguous area.
>
> I'm curious, how 'fixed' is the anchor?  As you know, there could be a
> non-movable page in the PFN range.  As a result, you will not be able=20
> to
> create a contiguous area starting at that PFN.  In such a case, do we=20
> try
> another PFN?  I know this could result in much page shuffling.  I'm=20
> just
> trying to figure out how we satisfy a user who really wants a=20
> contiguous
> area.  Is there some method to keep trying?

Good question. The anchor is determined on a per-VMA basis, which can be=20
changed easily,
but in this patchiest, I used a very simple strategy =E2=80=94 making all V=
MAs=20
not overlapping
in the physical address space to get maximum overall contiguity and not=20
changing anchors
even if non-moveable pages are encountered when generating physically=20
contiguous pages.

Basically, first VMA1 in the virtual address space has its anchor as=20
(VMA1_start_VPN, ZONE_start_PFN),
second VMA1 has its anchor as (VMA2_start_VPN, ZONE_start_PFN +=20
VMA1_size), and so on.
This makes all VMA not overlapping in physical address space during=20
contiguous memory
generation. When there is a non-moveable page, the anchor will not be=20
changed, because
no matter whether we assign a new anchor or not, the contiguous pages=20
stops at
the non-moveable page. If we are trying to get a new anchor, more effort=20
is needed to
avoid overlapping new anchor with existing contiguous pages. Any=20
overlapping will
nullify the existing contiguous pages.

To satisfy a user who wants a contiguous area with N pages, the minimal=20
distance between
any two non-moveable pages should be bigger than N pages in the system=20
memory. Otherwise,
nothing would work. If there is such an area (PFN1, PFN1+N) in the=20
physical address space,
you can set the anchor to (VPN_USER, PFN1) and use exchange_pages() to=20
generate a contiguous
area with N pages. Instead, alloc_contig_pages(PFN1, PFN1+N, =E2=80=A6) cou=
ld=20
also work, but
only at page allocation time. It also requires the system has N free=20
pages when
alloc_contig_pages() are migrating the pages in (PFN1, PFN1+N) away, or=20
you need to swap
pages to make the space.

Let me know if this makes sense to you.

--
Best Regards,
Yan Zi