Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp138762imp; Tue, 19 Feb 2019 20:11:36 -0800 (PST) X-Google-Smtp-Source: AHgI3Iba7BitUNgMCDkZ5tm6RYDJP3Yid77SzsrCdUzw5ImlohVw6kzO3TVnJhf3QZ5HOmd7rew7 X-Received: by 2002:a65:40c5:: with SMTP id u5mr26748558pgp.46.1550635896361; Tue, 19 Feb 2019 20:11:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550635896; cv=none; d=google.com; s=arc-20160816; b=YDVaOy2CT00sBqTrexGsXehl/1oE6heYseZNG1AYizYIFlceHCE3nOTCj+aOqqamWC nLHTef68tQNXJ2rw+/YnW1Z3nj/bfu/C2IyGF9OGFLGoxA1ufC7Z73vvmnyO+kSnBj6c sHpIDNrdD8kbZJoN0Qs7lzdr4cn2KRNSsUX4Va9ColEH/YZQr4yQgOxGYDC4QRIHEqlw K4XbWoo6hPEY/8d26JBR/t0Rz9jwX9wiH0gBkUtbME5jQcqb2iU88QBb423kgMyRZYCQ Hz1kpm2FJrex3EGzvYVejPJqTWDVdu/vO/5JADo8On9Pb0PMR5E+jc5SkC5KFGmSBC3n qTyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=drfTJHzPts60OU2UVPCTk75mVYzRNAWN8AXkBD7SD4E=; b=zVenc/s5BWna5J2u36TrhpYBEu2XXXqL5fwdTEk+XEdNbViTF7QqmZHIhoK+CydK+U lUqCwWuLzxFPTKD7Ah/X1YeEIp/OYVsxI3ljSzcsprmPM402C+0aEx/2hdCt9Q7B84Ml UVHMVhJFwWbZ63m/x30SrlcAg+iVMKzOPMgaIkq675DV1CGu44v/S1egLZzHMRFyUKXS tLVoX8Sdd4IuHmH4Yudp0y2muKcFZTnS3Evg0hTfx0IcE0Fv68TNchzUlAfx8K6YUmI8 8oPDgYpfv4JGItKSnO9tnoWi1GvcC2OzpUYLHN1QpdkScrTBGTuftDMKSUf58P8OHk10 iPxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=dFHd4JFJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4si16831833pgi.74.2019.02.19.20.11.21; Tue, 19 Feb 2019 20:11:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=dFHd4JFJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728754AbfBTEJX (ORCPT + 99 others); Tue, 19 Feb 2019 23:09:23 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:43999 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730484AbfBTEJS (ORCPT ); Tue, 19 Feb 2019 23:09:18 -0500 Received: by mail-qk1-f196.google.com with SMTP id f196so1117024qke.10 for ; Tue, 19 Feb 2019 20:09:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=drfTJHzPts60OU2UVPCTk75mVYzRNAWN8AXkBD7SD4E=; b=dFHd4JFJYLQJ3HEvhUwYXW9ZIeJxyqGF6bYwovIxTGblGeWB5rpH5YbnuoSW9HHdbm xzXziNe4l2jWrIU+Bd4ybUsUBbSpfPY0iQ2ZeCfUv/rC2r4pvl68w26Z0VpVCnqQJJ6F 6qVmAvq86ZwQJi8B2uWEZXBIRxIeakOQRBLOc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=drfTJHzPts60OU2UVPCTk75mVYzRNAWN8AXkBD7SD4E=; b=nn0OCqiwtvGI4kW5rEVZ+iYIYFw6ffP1DxZrQcUFVZZIM2uwRIUFGcuSBfXjL9wFDm U1kaZrokxMQzcGKRCHPO+8ZUv4oxMMxXEQLJ/nPB4yZ7XsAZjiokqiFA2w+LdyUaR4IH rgXzGI5P3yHfDgYZx4kAZKBwus6dKZLUuKHvGYyi2e40y5/uCMQGMY7sX5yGg9OdUbUB OrzKoODmG+PbtOLMKzCq+4a0Hq9CdjTiHHE705HJz4/0A3wPOIkNT3W5EiGm/vihODj/ 2U3G/XQt0LiGzdalb0vcV6w4RebJbx/zS17hHdfVipUlj5/4IZqKwqo999v8Vn+de4PT 6ACg== X-Gm-Message-State: AHQUAubQaSCStavQWXP1RH5Gv0XfCcB+ZzAce/UCRJx+D8DFHu1igLJ4 3YVrHohCEGlfLcKTKvk4z2yRp51wMJc= X-Received: by 2002:aed:21cb:: with SMTP id m11mr5888083qtc.257.1550635757081; Tue, 19 Feb 2019 20:09:17 -0800 (PST) Received: from joelaf.cam.corp.google.com ([2620:0:1004:1100:cca9:fccc:8667:9bdc]) by smtp.gmail.com with ESMTPSA id s19sm2024593qth.80.2019.02.19.20.09.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Feb 2019 20:09:16 -0800 (PST) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org, rcu@vger.kernel.org Cc: Joel Fernandes , paulmck@linux.ibm.com Subject: [RFC 5/5] rcuwait: Replace rcu_assign_pointer with smp_store_release Date: Tue, 19 Feb 2019 23:08:27 -0500 Message-Id: <20190220040827.136184-6-joel@joelfernandes.org> X-Mailer: git-send-email 2.21.0.rc0.258.g878e2cd30e-goog In-Reply-To: <20190220040827.136184-1-joel@joelfernandes.org> References: <20190220040827.136184-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joel Fernandes This suppresses a sparse error generated to the recently added rcu_assign_pointer sparse check: >> kernel//locking/percpu-rwsem.c:162:9: sparse: error: incompatible types in comparison expression (different address spaces) Signed-off-by: Joel Fernandes --- include/linux/rcuwait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/rcuwait.h b/include/linux/rcuwait.h index 90bfa3279a01..da613efee45c 100644 --- a/include/linux/rcuwait.h +++ b/include/linux/rcuwait.h @@ -44,7 +44,7 @@ extern void rcuwait_wake_up(struct rcuwait *w); */ \ WARN_ON(current->exit_state); \ \ - rcu_assign_pointer((w)->task, current); \ + smp_store_release(&((w)->task), current); \ for (;;) { \ /* \ * Implicit barrier (A) pairs with (B) in \ -- 2.21.0.rc0.258.g878e2cd30e-goog