Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 20 Feb 2019 09:16:29 +0100
From:   Michal Kubecek <mkubecek@suse.cz>
To:     Jakub Kicinski <jakub.kicinski@netronome.com>
Cc:     netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
        Andrew Lunn <andrew@lunn.ch>, Jiri Pirko <jiri@resnulli.us>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next v3 05/21] ethtool: netlink bitset handling
Message-ID: <20190220081629.GG23151@unicorn.suse.cz>
References: <cover.1550513384.git.mkubecek@suse.cz>
 <5f70eb8055a26f60f2282d7c1d193619a96c40a1.1550513384.git.mkubecek@suse.cz>
 <20190219182759.0abf08ae@cakuba.netronome.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190219182759.0abf08ae@cakuba.netronome.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 19, 2019 at 06:27:59PM -0800, Jakub Kicinski wrote:
> On Mon, 18 Feb 2019 19:21:49 +0100 (CET), Michal Kubecek wrote:
> > +		else if (is_u32)
> > +			bitmap_from_arr32(val, bitmap, nbits);
> > +		else
> > +			bitmap_copy(val, bitmap, nbits);
> > +		nla_for_each_nested(bit_attr, tb[ETHA_BITSET_BITS], rem) {
> > +			*err = ethnl_update_bit(val, mask, nbits, bit_attr,
> > +						is_list, names, legacy, info);
> > +			if (*err < 0)
> > +				goto out_free;
> > +		}
> > +		if (bitmask)
> > +			__bitmap_to_any(bitmask, mask, nbits, is_u32);
> > +	} else {
> > +		unsigned int change_words = DIV_ROUND_UP(change_bits, 32);
> > +
> > +		*err = 0;
> > +		if (change_bits == 0 && tb[ETHA_BITSET_MASK])
> > +			goto out_free;
> > +		*err = -EINVAL;
> > +		if (!tb[ETHA_BITSET_VALUE])
> > +			goto out_free;
> 
> !tb[ETHA_BITSET_BITS] && !tb[ETHA_BITSET_VALUE] is already rejected
> above.

Thank you. I'll drop this test.

Michal