Received: by 2002:ac0:a679:0:0:0:0:0 with SMTP id p54csp342505imp; Wed, 20 Feb 2019 01:01:24 -0800 (PST) X-Google-Smtp-Source: AHgI3IZtyRlwSG+ZNVqE/kbkMzfLGu6LJMmgXKJwjdEAmae0Xy88x8Nqh/uLCse8RN637uBbDt+g X-Received: by 2002:a17:902:b181:: with SMTP id s1mr6258921plr.321.1550653284191; Wed, 20 Feb 2019 01:01:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550653284; cv=none; d=google.com; s=arc-20160816; b=GRyOEfKqTZU840DmseRIwKiwBd+FlITyHWk8XYTJHCYkovijxbyVJd4tJokmC15Ben bASz5Li9e90fPb+PJ+qgMeEWpQzTLS7RSrAbF5Pjk90Z1DU+jofYADBxRBG8i690Qzv1 d4f/7uvC4W4WO+yWY47UquA9PJ7reFnZHODAdRYSrM31ifwl2u4K2OioZ3AXeB2eG+w/ Q8AVYuzZ9Rrnelxo9HfnmtyBHrqiia/mFP0eRteL/e233Z7gHIhfn04JZOPeKi1kM+jb 9340CijvOkQYf8WQTFCz00XabxeBEL9Rewgwv9pmXer1Q6Z9h9wTNivP5yl0NP4MuEZi oXpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CjKmjPfJ4deNl/Uc5pnYReNXv8ZpR/lmREuriH2mTXA=; b=Tl2dAcoE1aWrv2CY4Rk1OiGoYrz6LsdKadHt0+iV4NV4MUlMF1HXvB8GhijimGoIh1 7gpPefecwPGx7D5irtD24eImXwn1Lvqq3KCkNXLgmdShVzwNl3bi1Dthb0XvlqqSLnO5 9taUuoQ2ME8tsF7SrrKrgyCMaBSIUhb2W9J/xa3ro1cyqfYG8JhK/VcBGmGifWGf90Fp KN4EmaM124bhEWwJZ83isah6CMruYQ2DvhwPfwzRGSioJI9i54H3mPMeDHELd0pOZXPS B/vsiW8hkTZVgUdOe+k7UOT+3l6p17eH4QEavba2KbogLdGDB225e1npKe4QzK7Wdczc IX8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=NW0gGVek; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si19329053plv.138.2019.02.20.01.01.08; Wed, 20 Feb 2019 01:01:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=NW0gGVek; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbfBTI7y (ORCPT + 99 others); Wed, 20 Feb 2019 03:59:54 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:34152 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726060AbfBTI7x (ORCPT ); Wed, 20 Feb 2019 03:59:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CjKmjPfJ4deNl/Uc5pnYReNXv8ZpR/lmREuriH2mTXA=; b=NW0gGVekTZYz+CaI6KxBF1awP AuzILpqn3DVOhgLgUpIY618lcgB/qIlHJfWOs04ZA7PMGe2Zh3W1JROTjpOMUqpDYL+4S6s7TNFU6 a4pd/v/A5VREEpt3CnolKw4maoJTH1/2ZComMveu0BrNGhwNBWVuGk6ns2erjhUh19ltoZ9K8m8rt zmsSl8M2xDvJr6ipcJ5Qg7MAB57/hdcXs4o4bdx+xLXUQFUocQpzZTO3IqSweYTS5Rai3WyyZdqqD QrGKQU8o8S8z9wUPrQxDe/RizwxLhEV63KTvBiLjYvGgI1fhjsq88EUusN9b9lJ2qtxxOQomwrNCn cNgjsroMQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gwNjJ-0000XQ-CH; Wed, 20 Feb 2019 08:59:49 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 59B5F202BC402; Wed, 20 Feb 2019 09:59:47 +0100 (CET) Date: Wed, 20 Feb 2019 09:59:47 +0100 From: Peter Zijlstra To: Olof Johansson Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/nmi: ratelimit unknown nmi logs Message-ID: <20190220085947.GA17969@hirez.programming.kicks-ass.net> References: <20190220014836.20510-1-olof@lixom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190220014836.20510-1-olof@lixom.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 19, 2019 at 05:48:36PM -0800, Olof Johansson wrote: > Getting notified of unknown NMIs is obviously important, but getting > notified on every single one, especially on larger systems with slow > (serial) console causes more harm than good when it's a known noisy > non-relevant event. > > So, let's ratelimit to avoid locking up the system. What kind of bonghit broken crap system is that? That is; this _really_ should not happen, and this is a bandaid, not fixing the cause.